Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build(deps): bump simple-icons from 1.11.0 to 1.12.0 #3801

Closed

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Jul 29, 2019

Bumps simple-icons from 1.11.0 to 1.12.0.

Commits
Maintainer changes

This version was pushed to npm by ericcornelissen, a new releaser for simple-icons since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it). To ignore the version in this PR you can just close it
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

@dependabot-preview dependabot-preview bot added the dependencies Related to dependency updates label Jul 29, 2019
@shields-cd shields-cd had a problem deploying to shields-staging-pr-3801 July 29, 2019 07:57 Failure
@calebcartwright
Copy link
Member

@dependabot rebase

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/simple-icons-1.12.0 branch from 03a1c1f to a037bb9 Compare July 29, 2019 12:15
@shields-cd shields-cd had a problem deploying to shields-staging-pr-3801 July 29, 2019 12:15 Failure
@calebcartwright
Copy link
Member

Stack trace from the circle failures below

TypeError: Cannot read property 'replace' of undefined
    at Object.keys.forEach.key (/home/circleci/project/lib/load-simple-icons.js:15:28)
    at Array.forEach (<anonymous>)
    at loadSimpleIcons (/home/circleci/project/lib/load-simple-icons.js:7:28)
    at Object.<anonymous> (/home/circleci/project/lib/logos.js:8:51)
    at Module._compile (module.js:653:30)
    at Object.Module._extensions..js (module.js:664:10)
    at Module.load (module.js:566:32)
    at tryModuleLoad (module.js:506:12)
    at Function.Module._load (module.js:498:3)
    at Module.require (module.js:597:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/home/circleci/project/core/base-service/coalesce-badge.js:6:5)
    at Module._compile (module.js:653:30)
    at Object.Module._extensions..js (module.js:664:10)
    at Module.load (module.js:566:32)
    at tryModuleLoad (module.js:506:12)
    at Function.Module._load (module.js:498:3)
    at Module.require (module.js:597:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/home/circleci/project/core/base-service/base.js:14:23)
    at Module._compile (module.js:653:30)
    at Object.Module._extensions..js (module.js:664:10)
    at Module.load (module.js:566:32)
    at tryModuleLoad (module.js:506:12)
    at Function.Module._load (module.js:498:3)
    at Module.require (module.js:597:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/home/circleci/project/core/base-service/loader.js:7:21)
    at Module._compile (module.js:653:30)
    at Object.Module._extensions..js (module.js:664:10)
    at Module.load (module.js:566:32)
    at tryModuleLoad (module.js:506:12)
    at Function.Module._load (module.js:498:3)
    at Module.require (module.js:597:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/home/circleci/project/core/server/server.js:14:32)
    at Module._compile (module.js:653:30)
    at Object.Module._extensions..js (module.js:664:10)
    at Module.load (module.js:566:32)
    at tryModuleLoad (module.js:506:12)
    at Function.Module._load (module.js:498:3)
    at Module.require (module.js:597:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/home/circleci/project/core/server/in-process-server-test-helpers.js:4:16)
    at Module._compile (module.js:653:30)
    at Object.Module._extensions..js (module.js:664:10)
    at Module.load (module.js:566:32)
    at tryModuleLoad (module.js:506:12)
    at Function.Module._load (module.js:498:3)
    at Module.require (module.js:597:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/home/circleci/project/core/service-test-runner/cli.js:57:30)
    at Module._compile (module.js:653:30)
    at Object.Module._extensions..js (module.js:664:10)
    at Module.load (module.js:566:32)
    at tryModuleLoad (module.js:506:12)
    at Function.Module._load (module.js:498:3)
    at Module.require (module.js:597:17)
    at require (internal/module.js:11:18)
    at /home/circleci/project/node_modules/mocha/lib/mocha.js:330:36
    at Array.forEach (<anonymous>)
    at Mocha.loadFiles (/home/circleci/project/node_modules/mocha/lib/mocha.js:327:14)
    at Mocha.run (/home/circleci/project/node_modules/mocha/lib/mocha.js:804:10)
    at Object.exports.singleRun (/home/circleci/project/node_modules/mocha/lib/cli/run-helpers.js:207:16)
    at exports.runMocha (/home/circleci/project/node_modules/mocha/lib/cli/run-helpers.js:300:13)
    at Object.exports.handler.argv [as handler] (/home/circleci/project/node_modules/mocha/lib/cli/run.js:296:3)
    at Object.runCommand (/home/circleci/project/node_modules/mocha/node_modules/yargs/lib/command.js:242:26)
    at Object.parseArgs [as _parseArgs] (/home/circleci/project/node_modules/mocha/node_modules/yargs/yargs.js:1087:28)
    at Object.parse (/home/circleci/project/node_modules/mocha/node_modules/yargs/yargs.js:566:25)
    at Object.exports.main (/home/circleci/project/node_modules/mocha/lib/cli/cli.js:63:6)
    at Object.<anonymous> (/home/circleci/project/node_modules/mocha/bin/_mocha:10:23)
    at Module._compile (module.js:653:30)
    at Object.Module._extensions..js (module.js:664:10)
    at Module.load (module.js:566:32)
    at tryModuleLoad (module.js:506:12)
    at Function.Module._load (module.js:498:3)
    at Function.Module.runMain (module.js:694:10)
    at startup (bootstrap_node.js:204:16)
    at bootstrap_node.js:625:3

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/simple-icons-1.12.0 branch from a037bb9 to 8148d15 Compare August 5, 2019 23:23
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/simple-icons-1.12.0 branch from 8148d15 to d1023e0 Compare August 5, 2019 23:48
@chris48s
Copy link
Member

chris48s commented Aug 9, 2019

I've updated this to get the tests passing, but the other important thing in this release is the addition of the .slug property. We can merge this as it stands without breaking anything. Adopting the slug is going to be involved so is best addressed elsewhere. I'm going to move the conversation of that to #3641

@ericcornelissen
Copy link

Hey @chris48s just wanted to point out that we noticed the issue with the function being part of the enumeration of all icons as well and it was fixed in simple-icons/simple-icons#1555, which we plan to release this weekend 😉

@chris48s
Copy link
Member

Thanks for letting us know 👍 Given this is unexpected behaviour, lets just ignore this version then

@chris48s chris48s closed this Aug 10, 2019
@dependabot-preview
Copy link
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot-preview dependabot-preview bot deleted the dependabot/npm_and_yarn/simple-icons-1.12.0 branch August 10, 2019 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Related to dependency updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants