-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a diagnostic page for testing logos #2890
Conversation
It can be helpful to have some diagnostic pages for development and quality control. I added one here for the logos, which renders all the named logos in ?style=flat and ?style=social.
|
On staging this hit Are you thinking this is something to expose to end users, or something for local development use? |
No, not end users, but it's useful in development. It would be nice if we didn't run into rate limits like this on staging! |
The page is doing its job!
Confirmed. I guess there is some pending work to recolor those logos so they are visible on the social badge. Added: lgtm and travis are mentioned at #2510 (comment) |
Yes - there are definitely some light logo on light background issues with our bespoke logo set It would be quite nice to make this view (and potentially other 'debug' views we might want to declare) available in dev, but not in production. I've slightly lost track of this in the settings re-organisation, but at the point we build the front-end, do we have an env var available that indicates prod/dev? i.e: can we declare the route conditionally on |
That sounds good. Let's get #2906 merged and then revisit this. |
We still may need to solve the rate limiting, though even with it, I think this page remains more useful than not. |
It can be helpful to have some diagnostic pages for development and quality control. I added one here for the logos, which renders all the named logos in ?style=flat and ?style=social.