Refactor [GemDownloads] for readability; improve error messages #2870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| @@ -159,7 +169,7 @@ module.exports = class GemDownloads extends BaseJsonService { | |||
| pattern: 'dt/:gem', | |||
There was a problem hiding this comment.
Could we add some title descriptors/differentiators? May just be me since I've never done much with Ruby but it wasn't immediately clear to me which example was which. I know those weren't changed in this PR, just a general thought
There was a problem hiding this comment.
Ha, I just tried to do this and I'm actually not sure what the differences are. dt is total downloads, and I think dtv is downloads for latest version. But then I'm not sure what the difference is between that and dv with stable.
There was a problem hiding this comment.
@chris48s Do you know off hand what these three routes represent?
Either way, let's tackle this in a follow-on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1960