-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate [Coverity] to new service model #2550
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for having a look at this one. I've left a few minor comments, but its looking good
message: 'passed', | ||
}) | ||
) | ||
.expectJSON({ name: 'coverity', value: 'passing' }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to mock a response for each case, we could usefully make the calls with the ?style=_shields_test
param here and test the colouring logic too. There's an example of this in the docs https://github.com/badges/shields/blob/master/doc/service-tests.md#5-mocking-responses
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! I was wondering about color validation. Will add this (I should probably update some other service tests to include this as well)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another approach which can be taken here is a Sazerac-based test of render
in a .spec.js
file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added color validation via ?style=shields_test
, will keep in mind the Sazerac-based tests too going forward
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice one :)
Everything I've seen indicates that Coverity On Demand has been decommissioned for a while, although I haven't seen any official announcements from Coverity/Snyopsys. If anyone knows otherwise please let me know, but for now I believe deprecation is the best course of action.
All of the on-demand endpoints are down/inaccessible:
And the few online references I have found for Coverity On Demand speak about it in the past tense, like this from the Coverity Wikipedia page: