Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete BaseHTTPService and implement new BaseXmlService (affects [eclipse-marketplace f-droid]; also testing on [uptimerobot circleci]) #2037

Merged
merged 15 commits into from
Sep 3, 2018
Merged
25 changes: 0 additions & 25 deletions lib/all-badge-examples.js
Original file line number Diff line number Diff line change
Expand Up @@ -735,16 +735,6 @@ const allBadgeExamples = [
previewUrl: '/vscode-marketplace/d/ritwickdey.LiveServer.svg',
keywords: ['vscode-marketplace'],
},
{
title: 'Eclipse Marketplace',
previewUrl: '/eclipse-marketplace/dt/notepad4e.svg',
keywords: ['eclipse', 'marketplace'],
},
{
title: 'Eclipse Marketplace',
previewUrl: '/eclipse-marketplace/dm/notepad4e.svg',
keywords: ['eclipse', 'marketplace'],
},
{
title: 'JetBrains IntelliJ plugins',
previewUrl: '/jetbrains/plugin/d/1347-scala.svg',
Expand Down Expand Up @@ -1390,11 +1380,6 @@ const allBadgeExamples = [
previewUrl: '/vscode-marketplace/v/ritwickdey.LiveServer.svg',
keywords: ['vscode-marketplace'],
},
{
title: 'Eclipse Marketplace',
previewUrl: '/eclipse-marketplace/v/notepad4e.svg',
keywords: ['eclipse', 'marketplace'],
},
{
title: 'iTunes App Store',
previewUrl: '/itunes/v/803453959.svg',
Expand Down Expand Up @@ -1619,16 +1604,6 @@ const allBadgeExamples = [
previewUrl:
'/swagger/valid/2.0/https/raw.githubusercontent.com/OAI/OpenAPI-Specification/master/examples/v2.0/json/petstore-expanded.json.svg',
},
{
title: 'Eclipse Marketplace',
previewUrl: '/eclipse-marketplace/favorites/notepad4e.svg',
keywords: ['eclipse', 'marketplace'],
},
{
title: 'Eclipse Marketplace',
previewUrl: '/eclipse-marketplace/last-update/notepad4e.svg',
keywords: ['eclipse', 'marketplace'],
},
{
title: 'Vaadin Directory',
previewUrl: '/vaadin-directory/status/vaadinvaadin-grid.svg',
Expand Down
12 changes: 0 additions & 12 deletions lib/error-helper.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,18 +50,6 @@ checkErrorResponse.asPromise = function(errorMessages = {}) {
}
}

async function asJson({ buffer, res }) {
try {
return JSON.parse(buffer)
} catch (err) {
throw new InvalidResponse({
prettyMessage: 'unparseable json response',
underlyingError: err,
})
}
}

module.exports = {
checkErrorResponse,
asJson,
}
93 changes: 43 additions & 50 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
"dot": "~1.1.2",
"emojic": "^1.1.14",
"escape-string-regexp": "^1.0.5",
"fast-xml-parser": "^3.12.0",
"fsos": "^1.1.3",
"glob": "^7.1.1",
"gm": "^1.23.0",
Expand Down
22 changes: 0 additions & 22 deletions services/base-http.js

This file was deleted.

Loading