Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce no extensions in require #1999

Merged
merged 3 commits into from
Sep 1, 2018
Merged

Enforce no extensions in require #1999

merged 3 commits into from
Sep 1, 2018

Conversation

paulmelnikow
Copy link
Member

This removes remaining .js extensions from require() expressions and automatically enforces this rule.

@paulmelnikow paulmelnikow added the developer-experience Dev tooling, test framework, and CI label Aug 29, 2018
@shields-ci
Copy link

shields-ci commented Aug 29, 2018 •
edited
Loading

Warnings
⚠️

This PR modified service code for apm but not its test code.
That's okay so long as it's refactoring existing code.
⚠️

This PR modified service code for gem but not its test code.
That's okay so long as it's refactoring existing code.
⚠️

This PR modified service code for npm but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖

✨ Thanks for your contribution to Shields, @paulmelnikow!

Generated by 🚫 dangerJS

PyvesB
PyvesB previously approved these changes Sep 1, 2018
View reviewed changes
Copy link
Member

@PyvesB PyvesB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

PyvesB
PyvesB previously approved these changes Sep 1, 2018
View reviewed changes
Copy link
Member

@PyvesB PyvesB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A conflict needed manual resolution, so I have to approve this again. 😄

@paulmelnikow
Copy link
Member Author

And another one! 😝

@paulmelnikow paulmelnikow merged commit 454575c into badges:master Sep 1, 2018
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

@paulmelnikow paulmelnikow deleted the no-extensions-in-require branch September 1, 2018 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PyvesB PyvesB PyvesB approved these changes

Assignees
No one assigned
Labels
developer-experience Dev tooling, test framework, and CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulmelnikow @shields-ci @PyvesB