Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Elm package badge #1979

Closed
wants to merge 1 commit into from
Closed

Fix Elm package badge #1979

wants to merge 1 commit into from

Conversation

j-maas
Copy link
Contributor

@j-maas j-maas commented Aug 26, 2018

With the release of Elm 0.19.0, the package file changed (from elm-package.json to elm.json), which breaks the badge.

Fix usage of obsolete `elm-package.json`.
Rename default label to reflect obsoletion of `elm-package` in favor of `elm package`.
@shields-ci
Copy link

Warnings
⚠️

This PR modified the server but none of the service tests. That's okay so long as it's refactoring existing code. Otherwise, please consider adding tests to the service: https://github.com/badges/shields/blob/master/doc/service-tests.md#readme

Messages
📖

✨ Thanks for your contribution to Shields, @y0hy0h!

Generated by 🚫 dangerJS

@paulmelnikow
Copy link
Member

Hi! Thanks for this fix.

#1958 will move this code out of server.js, and this will need to wait until that lands. At that time this change can be re-applied in services/elm-package/elm-package.service.js.

@paulmelnikow paulmelnikow added bug Bugs in badges and the frontend service-badge New or updated service badge labels Aug 26, 2018
@paulmelnikow
Copy link
Member

#1958 is merged.

@y0hy0h would you like to open a new PR applying this fix to services/elm-package/elm-package.service.js? Drop [elm-package] into the PR title and the tests will be run automatically.

It would be great to get the fix deployed ASAP!

@j-maas
Copy link
Contributor Author

j-maas commented Aug 27, 2018

@paulmelnikow Done! Thanks for your guidance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs in badges and the frontend service-badge New or updated service badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants