Optionally persist [Github] tokens in Redis #1939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Save the tokens things change instead of on a timer. Use EventEmitter to keep the components loosely coupled. This is easier to reason about, much easier to test, and better supports adapting to backends which support atomic operations. This switches from json-autosave, which was a bit difficult to read and also hard to test, to fsos, the lower-level utility it’s built on.
8 tasks
|
I will review this when #1906 is merged. 😉 |
2 tasks
Generated by 🚫 dangerJS |
# Conflicts: # lib/token-persistence.js # lib/token-persistence.spec.js # services/github/github-constellation.js
PyvesB
reviewed
Aug 19, 2018
CONTRIBUTING.md
Outdated
| @@ -130,6 +130,10 @@ e.g. **[Travis] Fix timeout issues** | |||
|
|
|||
| When changing other code, please add unit tests. | |||
|
|
|||
| To run the integration tests, you must have redis installed and in your PATH. | |||
| Use `brew install redis`, `yum install redis`, etc. Ths test runner will | |||
| }) | ||
| } | ||
|
|
||
| beforeEach(function() {}) |
There was a problem hiding this comment.
I'm guessing this should be deleted? 😄
PyvesB
approved these changes
Aug 19, 2018
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fairly simple addition of a Redis-backed TokenPersistence. When GithubConstellation is initialized, it will create a FsTokenPersistence or a RedisTokenPersistence based on configuration. Have added tests of the Redis backend as an integration test, and ensured the server starts up correctly when a
REDIS_URLis configured.This is based off #1906 and the diff will clean up when that lands. Tests are failing due to #1938.
Ref: #1848