Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent merging exclusive service tests #1926

Merged
merged 5 commits into from
Aug 16, 2018
Merged

Prevent merging exclusive service tests #1926

merged 5 commits into from
Aug 16, 2018

Conversation

paulmelnikow
Copy link
Member

@paulmelnikow paulmelnikow added the developer-experience Dev tooling, test framework, and CI label Aug 16, 2018
@paulmelnikow paulmelnikow requested a review from chris48s August 16, 2018 15:56
@shields-ci
Copy link

shields-ci commented Aug 16, 2018 •
edited
Loading

Messages
📖

✨ Thanks for your contribution to Shields, @paulmelnikow!

Generated by 🚫 dangerJS

@paulmelnikow
Copy link
Member Author

Comment above from @shields-ci:

Fails
🚫

an only() was left in tests: services/github/github.tester.js
Messages
📖

✨ Thanks for your contribution to Shields, @paulmelnikow!

Generated by 🚫 dangerJS

@paulmelnikow paulmelnikow mentioned this pull request Aug 16, 2018
Merged
7 tasks
chris48s
chris48s approved these changes Aug 16, 2018
View reviewed changes
Copy link
Member

@chris48s chris48s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one 👍

@paulmelnikow paulmelnikow merged commit 9119c23 into badges:master Aug 16, 2018
@paulmelnikow paulmelnikow deleted the no-exclusive-tests branch August 16, 2018 18:06
@shields-deployment
Copy link

This pull request was merged to master branch. Now this change is waiting for deployment.
Deploys usually happen every few weeks. After deployment changes are copied to gh-pages branch.

This badge displays deployment status:

@snyk-bot snyk-bot mentioned this pull request Jun 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris48s chris48s chris48s approved these changes

Assignees
No one assigned
Labels
developer-experience Dev tooling, test framework, and CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulmelnikow @shields-ci @chris48s