Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-8 fix isValidStyle test failures #1544

Merged
merged 1 commit into from
Mar 6, 2018
Merged

node-8 fix isValidStyle test failures #1544

merged 1 commit into from
Mar 6, 2018

Conversation

RedSparr0w
Copy link
Member

@RedSparr0w RedSparr0w commented Mar 5, 2018 •
edited
Loading

Fix unit test failures with isValidStyle https://circleci.com/gh/badges/shields/2840
as noted in #1543

@shields-ci
Copy link

shields-ci commented Mar 5, 2018 •
edited
Loading

Messages
📖

✨ Thanks for your contribution to Shields, @RedSparr0w!

Generated by 🚫 dangerJS

@RedSparr0w RedSparr0w changed the title node-8 test fix attempt node-8 fix isValidStyle test failures Mar 5, 2018
@RedSparr0w RedSparr0w mentioned this pull request Mar 5, 2018
Merged
6 tasks
paulmelnikow
paulmelnikow approved these changes Mar 6, 2018
View reviewed changes
Copy link
Member

@paulmelnikow paulmelnikow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@RedSparr0w RedSparr0w merged commit bb4ff9e into badges:node-8 Mar 6, 2018
paulmelnikow added a commit that referenced this pull request Mar 12, 2018
@paulmelnikow
New API for registering services: #963 #1423 #1425 #1450 #1451 #1544 #…
2d65153 
…1543

This merges the `node-8` branch. The heavy lift was by @Daniel15 with refactoring from me and a patch by @RedSparr0w.

* New API for registering services (#963)
* Disable Node 6 tests on node-8 branch (#1423)
* BaseService: Factor out methods _regex and _namedParamsForMatch (#1425)
    - Adjust test grouping
    - Rename data -> queryParams, text -> message
* BaseService tests: Use Chai (#1450)
* BaseService: make serviceData and badgeData explicit and declarative (#1451)
* fix isValidStyle test (#1544)
* Run tests in Node 9, not Node 6 (#1543)
@RedSparr0w RedSparr0w deleted the node-8-test branch January 21, 2019 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulmelnikow paulmelnikow paulmelnikow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RedSparr0w @shields-ci @paulmelnikow