Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update danger to the latest version 🚀 #1414

Merged
merged 4 commits into from
Jan 6, 2018

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Jan 3, 2018

Version 3.0.0 of danger was just published.

Dependency danger
Current Version 2.1.10
Type devDependency

The version 3.0.0 is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

It might be worth looking into these changes and trying to get this project onto the latest version of danger.

If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.


FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴

@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-1414 January 3, 2018 15:07 Inactive
@platan
Copy link
Member

platan commented Jan 3, 2018

Unfortunately package-lock.json hasn't been updated. I've created an issue for this case #1415

@paulmelnikow
Copy link
Member

The CI needs to be updated too. There's a new CLI syntax. It's failing silently here, which I mentioned at danger/danger-js#465.

@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-1414 January 6, 2018 05:03 Inactive
@shields-ci
Copy link

shields-ci commented Jan 6, 2018

Messages
📖

✨ Thanks for your contribution to Shields, @Greenkeeper[bot]!

Generated by 🚫 dangerJS

@paulmelnikow paulmelnikow merged commit 2013968 into master Jan 6, 2018
@paulmelnikow paulmelnikow deleted the greenkeeper/danger-3.0.0 branch January 6, 2018 05:09
@paulmelnikow paulmelnikow added the dependencies Related to dependency updates label Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Related to dependency updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants