Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use template strings in make-badge #1296

Merged
merged 1 commit into from
Nov 30, 2017
Merged

Use template strings in make-badge #1296

merged 1 commit into from
Nov 30, 2017

Conversation

paulmelnikow
Copy link
Member

@paulmelnikow paulmelnikow added the core Server, BaseService, GitHub auth, Shared helpers label Nov 30, 2017
PyvesB
PyvesB reviewed Nov 30, 2017
View reviewed changes
Copy link
Member

@PyvesB PyvesB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! It's a shame we can't use multi-line template strings without breaking indentation in JavaScript.

@paulmelnikow
Copy link
Member Author

Thanks! We could do it in JSX… though probably not worth it. Sometimes I use arrays of lines, and .join('\n') which can be pretty clean.

@paulmelnikow paulmelnikow merged commit af0799a into badges:master Nov 30, 2017
@paulmelnikow paulmelnikow deleted the make-badge-template-strings branch November 30, 2017 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PyvesB PyvesB PyvesB left review comments

Assignees
No one assigned
Labels
core Server, BaseService, GitHub auth, Shared helpers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulmelnikow @PyvesB