Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High-level code walkthrough #2684

Closed
paulmelnikow opened this issue Jan 8, 2019 · 7 comments
Closed

High-level code walkthrough #2684

paulmelnikow opened this issue Jan 8, 2019 · 7 comments
Labels
documentation Developer and end-user documentation

Comments

@paulmelnikow
Copy link
Member

It would be helpful to provide a high-level walk-through of the code. This has been asked for in a couple forms in the past: #114 #811.

After #2661 we'll have some pretty decent documentation of the production hosting which explains the architecture of the system pretty well.

@paulmelnikow paulmelnikow added the documentation Developer and end-user documentation label Jan 8, 2019
This was referenced Jan 8, 2019
@paulmelnikow
Copy link
Member Author

I have a draft of this in the "High-level code walkthrough" section:

https://docs.google.com/document/d/11RCKeEqMQmKnh8Ij0sywRZPE66wxQBwHqiE9-OAZqhQ/edit#heading=h.bq9faurn4rs.

It's so much faster to iterate on copy in Google Docs. @chris48s and @calebcartwright, could I ask you to review / comment / edit that section? (Comments welcome from anyone else too!)

Once you guys are happy with it, I'll reformat it in Markdown and we can push through a PR.

The rest of that document is a work in progress. Comments are certainly welcome! Though it's not necessarily ready for review.

@calebcartwright
Copy link
Member

Wow! You have been busy. I did not realize how much you already had out there.

@calebcartwright
Copy link
Member

Also I goofed up a comment 🤦‍♂️ No big deal but you will know it when you see it 😉 Apologies in advance

@paulmelnikow
Copy link
Member Author

Wow! You have been busy. I did not realize how much you already had out there.

Yea! Mostly I organized a bunch of notes I've been collecting over the past couple years, and also pasted in bits I've written or seen other people write since I started the document.

@paulmelnikow
Copy link
Member Author

@chris48s @calebcartwright Is there anything else you think needs updating before I move the code walkthrough into Markdown?

@calebcartwright
Copy link
Member

I thought it was good to go already on my first read. Will give it another read here shortly or tomorrow

@chris48s
Copy link
Member

@chris48s @calebcartwright Is there anything else you think needs updating before I move the code walkthrough into Markdown?

I reckon its good to submit a PR for it 👍

paulmelnikow added a commit that referenced this issue Jan 27, 2019
Updated based on comments received in the Google Doc.

Close #2684
paulmelnikow added a commit that referenced this issue Jan 27, 2019
Updated based on comments received in the Google Doc.

Close #2684
paulmelnikow added a commit that referenced this issue Jan 27, 2019
Updated based on comments received in the Google Doc.

Close #2684
paulmelnikow added a commit that referenced this issue Jan 27, 2019
Updated based on comments received in the Google Doc.

Close #2684
paulmelnikow added a commit that referenced this issue Jan 27, 2019
Updated based on comments received in the Google Doc.

Close #2684
paulmelnikow added a commit that referenced this issue Jan 28, 2019
Updated based on comments received in the Google Doc.

Close #2684
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Developer and end-user documentation
Projects
None yet
Development

No branches or pull requests

3 participants