Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add query param validation to new-style services which don't have it yet #2675

Closed
paulmelnikow opened this issue Jan 7, 2019 · 0 comments
Closed

Add query param validation to new-style services which don't have it yet #2675

paulmelnikow opened this issue Jan 7, 2019 · 0 comments
Labels
good first issue New contributors, join in! service-badge New or updated service badge

Comments

@paulmelnikow
Copy link
Member

paulmelnikow commented Jan 7, 2019 •
edited
Loading

We've a few services which validate query params by invoking _validateQueryParams on BaseService returning a queryParamSchema from route.

The ones that don't yet should have it added!
@paulmelnikow paulmelnikow added good first issue New contributors, join in! service-badge New or updated service badge labels Jan 7, 2019
@paulmelnikow paulmelnikow mentioned this issue Jan 7, 2019
Closed
paulmelnikow added a commit that referenced this issue Mar 5, 2019
@paulmelnikow
Add query param validation to remaining new-style services [azuredevo…
a070da3 
…ps appveyor npm]

Remove now-obsolete code.

Close #2675
@paulmelnikow paulmelnikow mentioned this issue Mar 5, 2019
Merged
paulmelnikow added a commit that referenced this issue Mar 6, 2019
@paulmelnikow
Add query param validation to remaining new-style services [azuredevo…
388b0ee 
…ps appveyor npm] (#3164)

Remove now-obsolete code.

Close #2675
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue New contributors, join in! service-badge New or updated service badge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@paulmelnikow