Skip to content

Commit

Permalink
Fix TLS errors preventing Redis connections in production (#3899)
Browse files Browse the repository at this point in the history
ioredis 4.14.0 introduced an issue where custom TLS options are no longer honored. I reported it here: redis/ioredis#947

This has been preventing the server from using GitHub tokens, however I'm not sure whether or not this has been causing noticeable issues.

For now let's downgrade to the latest working version, which I've confirmed working via the script (checked in).
  • Loading branch information
paulmelnikow authored Aug 20, 2019
1 parent 316749b commit af81095
Show file tree
Hide file tree
Showing 3 changed files with 30 additions and 4 deletions.
6 changes: 3 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"glob": "^7.1.4",
"graphql": "^14.4.2",
"graphql-tag": "^2.10.1",
"ioredis": "^4.14.0",
"ioredis": "4.13.1",
"joi-extension-semver": "3.0.0",
"js-yaml": "^3.13.1",
"jsonpath": "~1.0.2",
Expand Down
26 changes: 26 additions & 0 deletions scripts/redis-connectivity-test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
'use strict'

const config = require('config').util.toObject()
console.log(config)
const GithubConstellation = require('../services/github/github-constellation')

const { persistence } = new GithubConstellation({
persistence: config.public.persistence,
service: config.public.services.github,
private: config.private,
})

async function main() {
const tokens = await persistence.initialize()
console.log(`${tokens.length} tokens loaded`)
await persistence.stop()
}

;(async () => {
try {
await main()
} catch (e) {
console.error(e)
process.exit(1)
}
})()

0 comments on commit af81095

Please sign in to comment.