Merge branch 'master' into coverity

services/amo/amo.service.js

@@ -150,6 +150,12 @@ class AmoUsers extends LegacyService {
   static registerLegacyRouteHandler() {}
 }
 
+// This legacy service should be rewritten to use e.g. BaseJsonService.
+//
+// Tips for rewriting:
+// https://github.com/badges/shields/blob/master/doc/rewriting-services.md
+//
+// Do not base new services on this code.
 class Amo extends LegacyService {
   static registerLegacyRouteHandler({ camp, cache }) {
     camp.route(

services/bintray/bintray.service.js

@@ -6,6 +6,12 @@ const { addv: versionText } = require('../../lib/text-formatters')
 const { version: versionColor } = require('../../lib/color-formatters')
 const serverSecrets = require('../../lib/server-secrets')
 
+// This legacy service should be rewritten to use e.g. BaseJsonService.
+//
+// Tips for rewriting:
+// https://github.com/badges/shields/blob/master/doc/rewriting-services.md
+//
+// Do not base new services on this code.
 module.exports = class Bintray extends LegacyService {
   static get category() {
     return 'version'

services/bitrise/bitrise.service.js

@@ -3,6 +3,12 @@
 const LegacyService = require('../legacy-service')
 const { makeBadgeData: getBadgeData } = require('../../lib/badge-data')
 
+// This legacy service should be rewritten to use e.g. BaseJsonService.
+//
+// Tips for rewriting:
+// https://github.com/badges/shields/blob/master/doc/rewriting-services.md
+//
+// Do not base new services on this code.
 module.exports = class Bitrise extends LegacyService {
   static get category() {
     return 'build'

services/bower/bower-license.service.js

@@ -4,6 +4,12 @@ const LegacyService = require('../legacy-service')
 const { makeBadgeData: getBadgeData } = require('../../lib/badge-data')
 const serverSecrets = require('../../lib/server-secrets')
 
+// This legacy service should be rewritten to use e.g. BaseJsonService.
+//
+// Tips for rewriting:
+// https://github.com/badges/shields/blob/master/doc/rewriting-services.md
+//
+// Do not base new services on this code.
 module.exports = class BowerLicense extends LegacyService {
   static get category() {
     return 'license'

services/bower/bower-version.service.js

@@ -6,6 +6,12 @@ const { addv: versionText } = require('../../lib/text-formatters')
 const { version: versionColor } = require('../../lib/color-formatters')
 const serverSecrets = require('../../lib/server-secrets')
 
+// This legacy service should be rewritten to use e.g. BaseJsonService.
+//
+// Tips for rewriting:
+// https://github.com/badges/shields/blob/master/doc/rewriting-services.md
+//
+// Do not base new services on this code.
 module.exports = class BowerVersion extends LegacyService {
   static get category() {
     return 'version'

services/bugzilla/bugzilla.service.js

@@ -10,6 +10,12 @@ const documentation = `
 </p>
 `
 
+// This legacy service should be rewritten to use e.g. BaseJsonService.
+//
+// Tips for rewriting:
+// https://github.com/badges/shields/blob/master/doc/rewriting-services.md
+//
+// Do not base new services on this code.
 module.exports = class Bugzilla extends LegacyService {
   static get category() {
     return 'issue-tracking'

services/buildkite/buildkite.service.js

@@ -4,6 +4,12 @@ const LegacyService = require('../legacy-service')
 const { makeBadgeData: getBadgeData } = require('../../lib/badge-data')
 const { checkErrorResponse } = require('../../lib/error-helper')
 
+// This legacy service should be rewritten to use e.g. BaseJsonService.
+//
+// Tips for rewriting:
+// https://github.com/badges/shields/blob/master/doc/rewriting-services.md
+//
+// Do not base new services on this code.
 module.exports = class Buildkite extends LegacyService {
   static get category() {
     return 'build'

services/bundlephobia/bundlephobia.service.js

@@ -4,7 +4,12 @@ const prettyBytes = require('pretty-bytes')
 const LegacyService = require('../legacy-service')
 const { makeBadgeData: getBadgeData } = require('../../lib/badge-data')
 
-// Bundle size for npm packages.
+// This legacy service should be rewritten to use e.g. BaseJsonService.
+//
+// Tips for rewriting:
+// https://github.com/badges/shields/blob/master/doc/rewriting-services.md
+//
+// Do not base new services on this code.
 module.exports = class Bundlephobia extends LegacyService {
   static get category() {
     return 'size'

services/chrome-web-store/chrome-web-store.service.js

@@ -137,6 +137,12 @@ class ChromeWebStoreRating extends LegacyService {
   static registerLegacyRouteHandler() {}
 }
 
+// This legacy service should be rewritten to use e.g. BaseJsonService.
+//
+// Tips for rewriting:
+// https://github.com/badges/shields/blob/master/doc/rewriting-services.md
+//
+// Do not base new services on this code.
 class ChromeWebStore extends LegacyService {
   static registerLegacyRouteHandler({ camp, cache }) {
     camp.route(

services/cocoapods/cocoapods-apps.service.js

@@ -8,6 +8,12 @@ const {
   downloadCount: downloadCountColor,
 } = require('../../lib/color-formatters')
 
+// This legacy service should be rewritten to use e.g. BaseJsonService.
+//
+// Tips for rewriting:
+// https://github.com/badges/shields/blob/master/doc/rewriting-services.md
+//
+// Do not base new services on this code.
 module.exports = class CocoapodsApps extends LegacyService {
   static get category() {
     return 'other'

services/cocoapods/cocoapods-downloads.service.js

@@ -8,6 +8,12 @@ const {
   downloadCount: downloadCountColor,
 } = require('../../lib/color-formatters')
 
+// This legacy service should be rewritten to use e.g. BaseJsonService.
+//
+// Tips for rewriting:
+// https://github.com/badges/shields/blob/master/doc/rewriting-services.md
+//
+// Do not base new services on this code.
 module.exports = class CocoapodsDownloads extends LegacyService {
   static get category() {
     return 'downloads'

services/cocoapods/cocoapods-metrics.service.js

@@ -7,6 +7,12 @@ const {
   coveragePercentage: coveragePercentageColor,
 } = require('../../lib/color-formatters')
 
+// This legacy service should be rewritten to use e.g. BaseJsonService.
+//
+// Tips for rewriting:
+// https://github.com/badges/shields/blob/master/doc/rewriting-services.md
+//
+// Do not base new services on this code.
 module.exports = class CocoapodsMetrics extends LegacyService {
   static get category() {
     return 'quality'

services/cocoapods/cocoapods.service.js

@@ -6,6 +6,12 @@ const { checkErrorResponse } = require('../../lib/error-helper')
 const { addv: versionText } = require('../../lib/text-formatters')
 const { version: versionColor } = require('../../lib/color-formatters')
 
+// This legacy service should be rewritten to use e.g. BaseJsonService.
+//
+// Tips for rewriting:
+// https://github.com/badges/shields/blob/master/doc/rewriting-services.md
+//
+// Do not base new services on this code.
 module.exports = class CocoapodsVersionPlatformLicense extends LegacyService {
   static registerLegacyRouteHandler({ camp, cache }) {
     camp.route(

services/codeclimate/codeclimate.service.js

@@ -8,6 +8,12 @@ const {
   colorScale,
 } = require('../../lib/color-formatters')
 
+// This legacy service should be rewritten to use e.g. BaseJsonService.
+//
+// Tips for rewriting:
+// https://github.com/badges/shields/blob/master/doc/rewriting-services.md
+//
+// Do not base new services on this code.
 module.exports = class Codeclimate extends LegacyService {
   static registerLegacyRouteHandler({ camp, cache }) {
     camp.route(

services/codecov/codecov.service.js

@@ -7,6 +7,12 @@ const {
   coveragePercentage: coveragePercentageColor,
 } = require('../../lib/color-formatters')
 
+// This legacy service should be rewritten to use e.g. BaseJsonService.
+//
+// Tips for rewriting:
+// https://github.com/badges/shields/blob/master/doc/rewriting-services.md
+//
+// Do not base new services on this code.
 module.exports = class Codecov extends LegacyService {
   static get category() {
     return 'quality'

services/codeship/codeship.service.js

@@ -3,6 +3,12 @@
 const LegacyService = require('../legacy-service')
 const { makeBadgeData: getBadgeData } = require('../../lib/badge-data')
 
+// This legacy service should be rewritten to use e.g. BaseJsonService.
+//
+// Tips for rewriting:
+// https://github.com/badges/shields/blob/master/doc/rewriting-services.md
+//
+// Do not base new services on this code.
 module.exports = class Codeship extends LegacyService {
   static get category() {
     return 'build'

services/continuousphp/continuousphp.service.js

@@ -3,6 +3,12 @@
 const LegacyService = require('../legacy-service')
 const { makeBadgeData: getBadgeData } = require('../../lib/badge-data')
 
+// This legacy service should be rewritten to use e.g. BaseJsonService.
+//
+// Tips for rewriting:
+// https://github.com/badges/shields/blob/master/doc/rewriting-services.md
+//
+// Do not base new services on this code.
 module.exports = class ContinuousPhp extends LegacyService {
   static get category() {
     return 'build'

services/cookbook/cookbook.service.js

@@ -6,6 +6,13 @@ const { addv: versionText } = require('../../lib/text-formatters')
 const { version: versionColor } = require('../../lib/color-formatters')
 
 // For Chef cookbook.
+//
+// This legacy service should be rewritten to use e.g. BaseJsonService.
+//
+// Tips for rewriting:
+// https://github.com/badges/shields/blob/master/doc/rewriting-services.md
+//
+// Do not base new services on this code.
 module.exports = class Cookbook extends LegacyService {
   static get category() {
     return 'version'

services/coveralls/coveralls.service.js

@@ -6,6 +6,12 @@ const {
   coveragePercentage: coveragePercentageColor,
 } = require('../../lib/color-formatters')
 
+// This legacy service should be rewritten to use e.g. BaseJsonService.
+//
+// Tips for rewriting:
+// https://github.com/badges/shields/blob/master/doc/rewriting-services.md
+//
+// Do not base new services on this code.
 module.exports = class Coveralls extends LegacyService {
   static get category() {
     return 'quality'

services/cpan/cpan.service.js

@@ -5,6 +5,12 @@ const { makeBadgeData: getBadgeData } = require('../../lib/badge-data')
 const { addv: versionText } = require('../../lib/text-formatters')
 const { version: versionColor } = require('../../lib/color-formatters')
 
+// This legacy service should be rewritten to use e.g. BaseJsonService.
+//
+// Tips for rewriting:
+// https://github.com/badges/shields/blob/master/doc/rewriting-services.md
+//
+// Do not base new services on this code.
 module.exports = class Cpan extends LegacyService {
   static get route() {
     return { base: 'cpan' }

services/david/david.service.js

@@ -3,6 +3,12 @@
 const LegacyService = require('../legacy-service')
 const { makeBadgeData: getBadgeData } = require('../../lib/badge-data')
 
+// This legacy service should be rewritten to use e.g. BaseJsonService.
+//
+// Tips for rewriting:
+// https://github.com/badges/shields/blob/master/doc/rewriting-services.md
+//
+// Do not base new services on this code.
 module.exports = class David extends LegacyService {
   static get category() {
     return 'dependencies'

services/discourse/discourse.service.js

@@ -4,6 +4,12 @@ const LegacyService = require('../legacy-service')
 const { makeBadgeData: getBadgeData } = require('../../lib/badge-data')
 const { metric } = require('../../lib/text-formatters')
 
+// This legacy service should be rewritten to use e.g. BaseJsonService.
+//
+// Tips for rewriting:
+// https://github.com/badges/shields/blob/master/doc/rewriting-services.md
+//
+// Do not base new services on this code.
 module.exports = class Discourse extends LegacyService {
   static get category() {
     return 'chat'

services/dub/dub-download.service.js

@@ -12,6 +12,12 @@ const {
   downloadCount: downloadCountColor,
 } = require('../../lib/color-formatters')
 
+// This legacy service should be rewritten to use e.g. BaseJsonService.
+//
+// Tips for rewriting:
+// https://github.com/badges/shields/blob/master/doc/rewriting-services.md
+//
+// Do not base new services on this code.
 module.exports = class DubDownload extends LegacyService {
   static get category() {
     return 'downloads'

services/dub/dub-license-version.service.js

@@ -59,6 +59,12 @@ class DubLicense extends LegacyService {
   static registerLegacyRouteHandler() {}
 }
 
+// This legacy service should be rewritten to use e.g. BaseJsonService.
+//
+// Tips for rewriting:
+// https://github.com/badges/shields/blob/master/doc/rewriting-services.md
+//
+// Do not base new services on this code.
 class DubLicenseVersion extends LegacyService {
   static registerLegacyRouteHandler({ camp, cache }) {
     camp.route(

services/github/github-commit-activity.service.js

@@ -11,6 +11,12 @@ const {
   checkErrorResponse: githubCheckErrorResponse,
 } = require('./github-helpers')
 
+// This legacy service should be rewritten to use e.g. BaseJsonService.
+//
+// Tips for rewriting:
+// https://github.com/badges/shields/blob/master/doc/rewriting-services.md
+//
+// Do not base new services on this code.
 module.exports = class GithubCommitActivity extends LegacyService {
   static get category() {
     return 'activity'

services/github/github-commit-status.service.js

@@ -7,6 +7,12 @@ const {
   checkErrorResponse: githubCheckErrorResponse,
 } = require('./github-helpers')
 
+// This legacy service should be rewritten to use e.g. BaseJsonService.
+//
+// Tips for rewriting:
+// https://github.com/badges/shields/blob/master/doc/rewriting-services.md
+//
+// Do not base new services on this code.
 module.exports = class GithubCommitStatus extends LegacyService {
   static get category() {
     return 'issue-tracking'

services/github/github-commits-since.service.js

@@ -10,6 +10,12 @@ const { documentation } = require('./github-helpers')
 
 const keywords = ['GitHub', 'commit']
 
+// This legacy service should be rewritten to use e.g. BaseJsonService.
+//
+// Tips for rewriting:
+// https://github.com/badges/shields/blob/master/doc/rewriting-services.md
+//
+// Do not base new services on this code.
 module.exports = class GithubCommitsSince extends LegacyService {
   static get category() {
     return 'activity'

services/github/github-contributors.service.js

@@ -11,6 +11,12 @@ const {
   checkErrorResponse: githubCheckErrorResponse,
 } = require('./github-helpers')
 
+// This legacy service should be rewritten to use e.g. BaseJsonService.
+//
+// Tips for rewriting:
+// https://github.com/badges/shields/blob/master/doc/rewriting-services.md
+//
+// Do not base new services on this code.
 module.exports = class GithubContributors extends LegacyService {
   static get category() {
     return 'activity'

services/github/github-downloads.service.js

@@ -11,6 +11,12 @@ const {
   checkErrorResponse: githubCheckErrorResponse,
 } = require('./github-helpers')
 
+// This legacy service should be rewritten to use e.g. BaseJsonService.
+//
+// Tips for rewriting:
+// https://github.com/badges/shields/blob/master/doc/rewriting-services.md
+//
+// Do not base new services on this code.
 module.exports = class GithubDownloads extends LegacyService {
   static get category() {
     return 'downloads'

services/github/github-followers.service.js

@@ -10,6 +10,12 @@ const {
   checkErrorResponse: githubCheckErrorResponse,
 } = require('./github-helpers')
 
+// This legacy service should be rewritten to use e.g. BaseJsonService.
+//
+// Tips for rewriting:
+// https://github.com/badges/shields/blob/master/doc/rewriting-services.md
+//
+// Do not base new services on this code.
 module.exports = class GithubFollowers extends LegacyService {
   static get category() {
     return 'social'