Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with backup-manager v1.1.1 #46

Merged
merged 1 commit into from
Feb 22, 2016
Merged

Fix compatibility with backup-manager v1.1.1 #46

merged 1 commit into from
Feb 22, 2016

Conversation

NicolasMahe
Copy link
Contributor

Fix DbBackupCommand fire function to work with backup-manager v1.1.1.

The backupProcedure->run function needs an array of Destination object instead of the plain destination and destinationPath since this commit: backup-manager/backup-manager@533c547

Also fix issue #45.

@roccobenditz
Copy link

👍

That solved the issue! Already merged into my production code.
Thanks.

@v920749
Copy link

v920749 commented Feb 9, 2016

please merge it

@DanKeeble
Copy link

This should be merged asap.

@REBELinBLUE
Copy link

👍

@drbyte
Copy link

drbyte commented Feb 17, 2016

👍 Agreed, this needs to be merged.

@robindv
Copy link

robindv commented Feb 17, 2016

👍

1 similar comment
@rleger
Copy link

rleger commented Feb 19, 2016

+1

whoacowboy added a commit to digitalagua/laravel that referenced this pull request Feb 21, 2016
I was getting this error 

backup-manager#45

because of this change

backup-manager#46
mitchellvanw added a commit that referenced this pull request Feb 22, 2016
Fix compatibility with backup-manager v1.1.1
@mitchellvanw mitchellvanw merged commit d7e6d12 into backup-manager:master Feb 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants