Allow appConfig to be provided as a string

[maxnitze]

Description of the Bug

Providing the value for backstage.appConfig as a string does technically work, but is not allowed by the schema.

Description of the change

Allow key backstage.appConfig to be of type object or string.

Existing or Associated Issue(s)

None

Additional Information

The template app-config-configmap.yaml uses the common.tplvalues.render helper function from the bitnami common chart.

charts/charts/backstage/templates/app-config-configmap.yaml

Lines 7 to 8 in b1d86d3

	app-config.yaml: |
	{{- include "common.tplvalues.render" ( dict "value" .Values.backstage.appConfig "context" $) | nindent 4 }}

That helper function supports both, string-type and object-type values.

https://github.com/bitnami/charts/blob/35bc6b1d5d87dfc3875ed09a45bffd2bddc9ee6d/bitnami/common/templates/_tplvalues.tpl#L2-L13

Checklist

• Chart version bumped in Chart.yaml according to semver.
• Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
• JSON Schema generated.
• List tests pass for Chart using the Chart Testing tool and the ct lint command.

[tumido]

Hi @maxnitze! Thank you for opening a PR! 🙂

Yeah, sure, why not... LGTM 👍

IMO I would still advise using object syntax because YAML is a terrible language and for example, indent levels are not obvious in multiline string values. But I'm all for letting users choose what path they want to go. 🙂

[maxnitze]

Thanks for the fast approval. In theory I agree with your comment about object vs. string.

But in case of the common.tplvalues.render helper using the string-typed value is a little more powerful than the object-typed. You can use the full "power" of the templating engine. We, for example, define some variables at the top to be used multiple times, like the baseUrl. You could also in- or exclude whole blocks of your configuration based on other values.

Also it was possible in the old version of the chart (we just update from 0.17.1) to use this and it is not anymore :)

Anyways. Thanks for taking care!

[tumido]

Oh... I totally didn't think of that @maxnitze! Yup, that makes great sense actually. Thank you! 🙂