-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't allow override of turtle id #78
Comments
I agree! "Private", as per I'm surprised that all the browsers support it, and so quickly. |
I haven't used the private class fields. It looks well supported, https://caniuse.com/mdn-javascript_classes_private_class_fields |
This is more difficult than it seemed. Turns out use of private variables is class based but AS makes heavy use of prototypal methods. So this basically depends on: #83 |
Could it be renamed to something less common like __id__ ?
…On Wed, Oct 4, 2023, 9:53 AM Owen Densmore ***@***.***> wrote:
This is more difficult than it seemed. Turns out use of private variables
is class based but AS makes heavy use of prototypal methods. So this
basically depends on: #83
<#83>
—
Reply to this email directly, view it on GitHub
<#78 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADADQRUJODL37PYQY553XLX5WBA3AVCNFSM6AAAAAA4DOQXQWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBXGE4TGOBUHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
It turns out that it turtle list is sorted by id, and if you set the id it will mess some internal things, like turtle removal.
Maybe the turtle id should be private, or have a setter that gives you a warning to avoid shooting yourself in the foot?
The text was updated successfully, but these errors were encountered: