Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multi module Jacoco test coverage check #44

Merged
merged 6 commits into from
Mar 21, 2024

Conversation

ghkdqhrbals
Copy link
Member

@ghkdqhrbals ghkdqhrbals commented Mar 20, 2024

  1. apply plugin jacoco-report-aggregation
  2. dependency 추가
implementation project(":bm-agent")
jacocoAggregation project(":bm-agent")

를 통해 agent 의 테스트 커버리지 또한 하나의 리포트로 받아볼 수 있도록 하였습니다.

현재 /bm-agent/build.gradle 내부 jacocoTestCoverageVerification task 테스트 커버리지 limit 을 0.00 으로 설정하였습니다.

임시로 0.00 으로 설정한 것이며 이 부분을 0.60 으로 맞추고 개발을 진행하셔야합니다 :)

jacocoTestCoverageVerification {
    violationRules {
        rule {
            // Set the path to the source files
            classDirectories.setFrom(tasks.jacocoTestReport.classDirectories)
            element = 'CLASS'
            enabled = true

            limit {
                counter = 'LINE'
                value = 'COVEREDRATIO'
                minimum = 0.00 <-- 0.60 으로 변경 필요
            }
            limit {
                counter = 'METHOD'
                value = 'COVEREDRATIO'
                minimum = 0.00 <-- 0.60 으로 변경 필요
            }
        }
    }
}

@ghkdqhrbals ghkdqhrbals self-assigned this Mar 20, 2024
@ghkdqhrbals ghkdqhrbals requested a review from LeeJeongGi March 20, 2024 19:39
Copy link

📝 Test code-coverage reports

There is no coverage information present for the Files changed

Total Project Coverage 75.1% 🍏

Copy link
Member

@LeeJeongGi LeeJeongGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빠른 작업 감사드립니다! :)

@ghkdqhrbals ghkdqhrbals merged commit 721d99a into develop Mar 21, 2024
1 check passed
@ghkdqhrbals ghkdqhrbals deleted the feature/jacoco-aggregate branch March 21, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants