feat : banchmark Performance add #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
webClient 모킹 관련 문제를 #42 에서 정의하였습니다. |
…emplate # Conflicts: # .github/workflows/gradle-ci.yaml
# Conflicts: # bm-agent/src/main/java/org/benchmarker/bmagent/sse/SseManageService.java # bm-controller/build.gradle # bm-controller/src/main/java/org/benchmarker/bmcontroller/common/beans/RequestCounter.java # bm-controller/src/main/java/org/benchmarker/bmcontroller/common/beans/RequestCounterResetScheduler.java # bm-controller/src/main/java/org/benchmarker/bmcontroller/common/beans/WebClientConfig.java # bm-controller/src/main/java/org/benchmarker/bmcontroller/template/controller/TestResultTemplateApiController.java # bm-controller/src/main/java/org/benchmarker/bmcontroller/template/controller/dto/TempSaveTestResultDto.java # bm-controller/src/main/java/org/benchmarker/bmcontroller/template/controller/dto/TestResultResponseDto.java # bm-controller/src/main/java/org/benchmarker/bmcontroller/template/model/HttpStatusCode.java # bm-controller/src/main/java/org/benchmarker/bmcontroller/template/model/TemplateResult.java # bm-controller/src/main/java/org/benchmarker/bmcontroller/template/model/TestErrorLog.java # bm-controller/src/main/java/org/benchmarker/bmcontroller/template/model/TestMttfb.java # bm-controller/src/main/java/org/benchmarker/bmcontroller/template/model/TestResult.java # bm-controller/src/main/java/org/benchmarker/bmcontroller/template/model/TestStatus.java # bm-controller/src/main/java/org/benchmarker/bmcontroller/template/model/TestTps.java # bm-controller/src/main/java/org/benchmarker/bmcontroller/template/repository/TestErrorLogRepository.java # bm-controller/src/main/java/org/benchmarker/bmcontroller/template/repository/TestMttfbRepository.java # bm-controller/src/main/java/org/benchmarker/bmcontroller/template/repository/TestResultRepository.java # bm-controller/src/main/java/org/benchmarker/bmcontroller/template/repository/TestStatusRepository.java # bm-controller/src/main/java/org/benchmarker/bmcontroller/template/repository/TestTpsRepository.java # bm-controller/src/main/java/org/benchmarker/bmcontroller/template/service/AbstractTestResultService.java # bm-controller/src/main/java/org/benchmarker/bmcontroller/template/service/ITestResultService.java # bm-controller/src/main/java/org/benchmarker/bmcontroller/template/service/TestResultService.java # bm-controller/src/test/java/org/benchmarker/bmcontroller/template/controller/TestResultTemplateApiControllerTest.java # bm-controller/src/test/java/org/benchmarker/bmcontroller/template/service/TestResultServiceTest.java
ghkdqhrbals
reviewed
Mar 21, 2024
| // when(testResultService.measurePerformance("userGroup", testTemplateResponseDto.getId(), "start")).thenReturn(request); | ||
| // | ||
| // // then | ||
| // mockMvc.perform(post("/api/groups/{group_id}/templates/{template_id}?action={action}" |
There was a problem hiding this comment.
이 부분의 API 는 PreftestController 를 호출하고 있습니다.
따라서 TemplateApiController 를 테스트하는 부분이 아니라고 판단하여 주석처리 진행하였습니다 :)
PreftestController 는 따로 테스트 추가하여 PR 에 올리겠습니다.
ghkdqhrbals
reviewed
Mar 21, 2024
There was a problem hiding this comment.
deploy 와 feature/template 브랜치 싱크 완료
package 불일치 문제와 import 부분 모두 수정완료했습니다. 이제 정상적으로 테스트 수행이 가능할거에요.
그리고 현재 template 브랜치가 조금 길게 작업되고 있는것 같아서 지금까지 완료된 부분은 바로 deploy 에 squash and merge 하시면 될 것 같습니다. 이후 feature/agent 로 분기하고, 기존 target server 에 요청 전송하는 파트를 agent 로 옮기기 및 테스트 코드 구현하시면 됩니다 :)
코드 이쁘게 잘 작성해주셔서 너무 편하네요ㅎㅎ. 감사드립니다.
ghkdqhrbals
approved these changes
Mar 21, 2024
|
제가 해야할 작업을 새벽에 미리해주시다니,,, 감사합니다!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
혼자 고민하는 시간이 너무 길어지는거 같아서,, 우선 코드 올립니다..!
테스트 코드 작성하면서 정상적으로 동작하는지 확인하고 있는중인데 테스트코드 작성하는거 자체가 쉽지 않습니다!!
도움이 필요합니다 :(