feat: multiple users matching with multiple group #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 Test code-coverage reports
|
LeeJeongGi
approved these changes
Mar 11, 2024
bm-controller/src/main/java/org/benchmarker/user/controller/dto/UserInfo.java
Show resolved
Hide resolved
📝 Test code-coverage reports
|
ghkdqhrbals
added a commit
that referenced
this pull request
Mar 17, 2024
* dev: implement join-table for user & group * dev: implement join-table repo for user & group * dev: userGroupInfo dto set * dev: add userInfo test * dev: implement userUpdateDto * chore: add some default test consts * dev: many user can be connected with many groups, also vise versa * fix: change all test based on changed user & group model * dev: delete unused test * dev: UserRegisterDto now return list of group * dev: UserInfo contain user group list * dev: eager fetching join table * dev: dto direct transfer to service layer * dev: test add based on changed model * dev: test add based on changed user & group model * dev: mapping to join table * dev: add userGroupJoin in initClass * dev: add userGroupJoin in initial dataloader * chore: change directory * chore: remove unused groupInfo * dev: remove explicit throwing exception * dev: add deleteByUserId JPA methods * dev: add join table removal process * dev: matching pre-define restAPIs resource and add Patch & Delete operation * dev: restAPIs test with valid url resource * chore: remove unused test * dev: initialize admin and defaultgroup * chore: update comments * dev: add jsonIgnore * dev: add role column in group join table * dev: configure jpql for finding groupJoin * dev: clarify json property * chore: remove unused imports * chore: change package path * chore: change package path * dev: add user deletion method * chore: change package path * chore: change package path * dev: add USER_NOT_IN_GROUP errorcode * dev: add dto for group adding * dev: implement restApi for create & get group * dev: add groupRole for managing group * dev: change admin defaultGroup LEADER role * dev: add USER_ALREADY_IN_GROUP errorcode * dev: group info dto set * dev: group update dto set * dev: implement group managing service * dev: implement group delete & post and additional managing process * dev: user signup and create group as LEADER mem. * test: group api controller test impl. * test: user creation for test * dev: code refactoring * test: add role for test user * test: add group service test initializer * test: refactoring & impl. group restAPIs test * fix: remove dup. url path like /api/api * chore: add some comments * dev: mockMvc alwaysDo print * dev: group role additional param added * dev: Modifying deletion method added * test: user creation helper added * dev: user deletion * test: remove unused test * chore: add comment on each methods * test: test group service layer * test: add additional params * chore: conflict handling * chore: change Builder pattern
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
USER_GROUP_JOINtable for join User and GroupmockMvcwill always print req/resp by adding.alwaysDo(print())USER_NOT_IN_GROUP,USER_ALREADY_IN_GROUP