New features and prep for release 0.3.1 #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added git ignore file * Added project workspace * Added tab bar template project * Added DrawerKit empty framework * Added basic view controllers and storyboards * Fixed broken outlets * Added implementation of DrawerKit. A few bits to complete still. * Hooked up the view controllers to the custom presentation. * Added clamping to the three possible resting positions of the drawer * Added more configuration to the presenting VC * Fixed a few glitches related to allowing partial expansion or not, and some refactoring. * Removed the two timing configurations and now using only one for all animations. * Added support for not having the gesture recognisers. * Fixed a potential division by zero. * Adding more configuration controls to presenting VC. WIP. * Added debug mode. * Added some TODOs * Renamed a function to make it clear it's a debugging feature. * Minor refactoring. * Renamed some source files for better clarity of intention. * Removed source headers. * Changed the presented VC to make a larger drawer (easier to play with). * Changed some parameters as per Sam's input. * Improved behaviour of corner rounding at the two edges of the screen. Still not a perfect solution because the animator's completion block is, surprisingly, not always called. Apparently, that's a bug in UIViewPropertyAnimator. * Made the logic for the drawer behaviour easier to read, because Sergey doesn't like `guard` with boolean statements. ;) * Moved some code closer to where it's actually used. * Minor formatting. * Added a fix to the corner-radius animation issue whereby the corner radius would not be set to zero because the property animator's completion would not always be called. Now we force it to zero on presentationTransitionDidEnd() (for the appropriate drawer ending positions). * Disabled automatic code signing. * The heights of the bands surrounding the resting position of the drawer are now given in absolute rather than relative terms. * Oopsie... committed a compiler error. Fixed now. * Added a scrollview to the presented view controller in the demo app, for testing how scrolling interacts with the drag gesture recogniser in the presentation controller. * Added an interaction controller, the first step in fixing the non-interactive presentation/dismissal itself. * Renamed TransitionAnimator to AnimationController. * Renamed a file to match the extension it's about. * Duh, it was supposed to be AnimationController, not AnimatorController. * Implemented interactive controller for the presentation and dismissal, and cleaned up the code for the animation controller (it doesn't need to know anything about the drawers). * Added license file and CocoaPods podspec. Not passing lint just yet. * Removed indirect access to configuration parameters. * Removed currently unused source file TransitionGeometry. * Fixed company name in the license file. * Cleared the team entry in the demo app. * Demo app: adding controls for all the configurable parameters. WIP. * Added control for manipulating cubic Bezier control points, CubicBezierView. * Added all the controls to the presenter VC. * Fixed a TODO comment. * Make sure that durationInSeconds is a positive value. * Removed all references to coversStatusBar since that hasn't been implemented yet. * Make sure that flickSpeedThreshold is a non-negative value. Also, if zero, disables support for flicking. * Make sure that upperMarkGap and lowerMarkGap are non-negative values. * Only add debugging mark lines if at least one of upperMarkGap and lowerMarkGap is a positive value. * Make sure that maximumCornerRadius is a non-negative value. * Only animate the corner radius if maximumCornerRadius is strictly positive. * Make sure that numberOfTapsForOutsideDrawerDismissal is a non-negative value. * Resolved an issue with animating rounding the presented view corners. * Simplified the demo app to its bare essentials. No more configuration controls to the wazoo. * Added based documentation to the library. * Preliminary version of README. WIP. * Removed unused assets. * Added some pseudo-code to the README, to explain the presentation/dismissal logic. * Code style change. * Removed unnecessary [weak self] capture lists. * Changed default value of durationInSeconds from 0.8 to 0.3 seconds. * Fixed a botched global search/replace in DrawerConfiguration+Equatable. * Renamed evil local gr variables to less evil names. * Fixed guard statements as per comments. * Removed a comment. * Removed a protocol extension. * Make sure that the height of the partially expanded drawer is non-negative. * Added documentation to all exposed public entities. * Style change as per comments. * Fixed documentation. * Updated README file. * Tweaked the README file. * Decreased the deployment target requirement, from 10.3 to 10.0. * Removed hidden extension in the LICENSE file. * Fixed source_files entry in the podspec. Removed the exclude_files entry. * Added a .swift-version file with the appropriate version of Swift to pod lib lint the pod. * Fixed the homepage in the podspec. * Fixed a bug when running under iOS 10 in which the initial presentation animation doesn't complete, therefore not invoking viewDidAppear, which causes the drawer not to show up at all. The work-around means that the initial presentation and dismissal aren't interactive but Product signed off on that decision. The drawers work fine under iOS 11. * Style change. * Killed the use of IUO references. * Changed author email address in the podspec. * Added support for Carthage. * [ci skip] Removed a commented out section from the README. Also, an excuse to turn CI off since DrawerKit fails it for lack of configuration for testing. * Added CircleCI config file. (#9) * Added CircleCI config file. * Changed circle.yml to "test" with the simulator, which disables testing * Let's try this one more time, shall we? * And again * Fixed circle.yml * And again * Fixed circle.yml * Fixed circle.yml. * Added CircleCI badge to README. * Simplified circle.yml build command. * Added dependency management commands to circle.yml * Fixed podspec source item. (#12) * Fixed podspec source item. * Missed the s in https. * DrawerKit release 0.0.1 (#13) (#14) * Added git ignore file * Added project workspace * Added tab bar template project * Added DrawerKit empty framework * Added basic view controllers and storyboards * Fixed broken outlets * Added implementation of DrawerKit. A few bits to complete still. * Hooked up the view controllers to the custom presentation. * Added clamping to the three possible resting positions of the drawer * Added more configuration to the presenting VC * Fixed a few glitches related to allowing partial expansion or not, and some refactoring. * Removed the two timing configurations and now using only one for all animations. * Added support for not having the gesture recognisers. * Fixed a potential division by zero. * Adding more configuration controls to presenting VC. WIP. * Added debug mode. * Added some TODOs * Renamed a function to make it clear it's a debugging feature. * Minor refactoring. * Renamed some source files for better clarity of intention. * Removed source headers. * Changed the presented VC to make a larger drawer (easier to play with). * Changed some parameters as per Sam's input. * Improved behaviour of corner rounding at the two edges of the screen. Still not a perfect solution because the animator's completion block is, surprisingly, not always called. Apparently, that's a bug in UIViewPropertyAnimator. * Made the logic for the drawer behaviour easier to read, because Sergey doesn't like `guard` with boolean statements. ;) * Moved some code closer to where it's actually used. * Minor formatting. * Added a fix to the corner-radius animation issue whereby the corner radius would not be set to zero because the property animator's completion would not always be called. Now we force it to zero on presentationTransitionDidEnd() (for the appropriate drawer ending positions). * Disabled automatic code signing. * The heights of the bands surrounding the resting position of the drawer are now given in absolute rather than relative terms. * Oopsie... committed a compiler error. Fixed now. * Added a scrollview to the presented view controller in the demo app, for testing how scrolling interacts with the drag gesture recogniser in the presentation controller. * Added an interaction controller, the first step in fixing the non-interactive presentation/dismissal itself. * Renamed TransitionAnimator to AnimationController. * Renamed a file to match the extension it's about. * Duh, it was supposed to be AnimationController, not AnimatorController. * Implemented interactive controller for the presentation and dismissal, and cleaned up the code for the animation controller (it doesn't need to know anything about the drawers). * Added license file and CocoaPods podspec. Not passing lint just yet. * Removed indirect access to configuration parameters. * Removed currently unused source file TransitionGeometry. * Fixed company name in the license file. * Cleared the team entry in the demo app. * Demo app: adding controls for all the configurable parameters. WIP. * Added control for manipulating cubic Bezier control points, CubicBezierView. * Added all the controls to the presenter VC. * Fixed a TODO comment. * Make sure that durationInSeconds is a positive value. * Removed all references to coversStatusBar since that hasn't been implemented yet. * Make sure that flickSpeedThreshold is a non-negative value. Also, if zero, disables support for flicking. * Make sure that upperMarkGap and lowerMarkGap are non-negative values. * Only add debugging mark lines if at least one of upperMarkGap and lowerMarkGap is a positive value. * Make sure that maximumCornerRadius is a non-negative value. * Only animate the corner radius if maximumCornerRadius is strictly positive. * Make sure that numberOfTapsForOutsideDrawerDismissal is a non-negative value. * Resolved an issue with animating rounding the presented view corners. * Simplified the demo app to its bare essentials. No more configuration controls to the wazoo. * Added based documentation to the library. * Preliminary version of README. WIP. * Removed unused assets. * Added some pseudo-code to the README, to explain the presentation/dismissal logic. * Code style change. * Removed unnecessary [weak self] capture lists. * Changed default value of durationInSeconds from 0.8 to 0.3 seconds. * Fixed a botched global search/replace in DrawerConfiguration+Equatable. * Renamed evil local gr variables to less evil names. * Fixed guard statements as per comments. * Removed a comment. * Removed a protocol extension. * Make sure that the height of the partially expanded drawer is non-negative. * Added documentation to all exposed public entities. * Style change as per comments. * Fixed documentation. * Updated README file. * Tweaked the README file. * Decreased the deployment target requirement, from 10.3 to 10.0. * Removed hidden extension in the LICENSE file. * Fixed source_files entry in the podspec. Removed the exclude_files entry. * Added a .swift-version file with the appropriate version of Swift to pod lib lint the pod. * Fixed the homepage in the podspec. * Fixed a bug when running under iOS 10 in which the initial presentation animation doesn't complete, therefore not invoking viewDidAppear, which causes the drawer not to show up at all. The work-around means that the initial presentation and dismissal aren't interactive but Product signed off on that decision. The drawers work fine under iOS 11. * Style change. * Killed the use of IUO references. * Changed author email address in the podspec. * Added support for Carthage. * [ci skip] Removed a commented out section from the README. Also, an excuse to turn CI off since DrawerKit fails it for lack of configuration for testing. * Added CircleCI config file. (#9) * Added CircleCI config file. * Changed circle.yml to "test" with the simulator, which disables testing * Let's try this one more time, shall we? * And again * Fixed circle.yml * And again * Fixed circle.yml * Fixed circle.yml. * Added CircleCI badge to README. * Simplified circle.yml build command. * Added dependency management commands to circle.yml * Fixed podspec source item. (#12) * Fixed podspec source item. * Missed the s in https. * Add gif and fixes the circle CI badge. (#17) * Adds a gif and fixes the circleci badge. * Moved the gif down a bit. * Removed extra space below the gif. * Changes version from 0.0.1 to 0.1. (#18) * Add missing link to Carthage (#15) * Fix to README (#21) * Changed version number from 0.0.1 to 0.1.1 in the dependency management sections of the README file. * Fix README as per David's suggestion. * Update podspec in preparation for release 0.1.2. * Revert "Update podspec in preparation for release 0.1.2." This reverts commit df1c07a. * Add 4 UI tests to check the Drawer Kit demo app is working (#22) - Open the drawer - Close the drawer - Slide to full screen - Tap close on fully open drawer * Run UI Tests as part of the CircleCI build (#25) * Experiment in running the UI tests as part of the circleci build * Fixed name in scheme * Change simulator being used to match local environment * Add scheme for demo with UI tests * Between a branch build and the merge the version available for the simulator seems to have changed. This updates the yml file to reflect this (#26) * New features (#27) * Update README.md (#23) * Fixed version number in Carthage section. * Renamed some properties and functions, for better clarity of intention. * More renaming along the same lines as the last commit. * Added support for tapping on the drawer to fully present it * More renaming. * Turned on debug mode in the demo app. * Make sure that quantities are always in their expected ranges. * Introduced an enumeration for drawer states * Removed extra blank line * Replaced the DrawerPresenting protocol with a new protocol, DrawerCoordinating, and made it so that objects other than view controllers can also coordinate the presentation of drawers. * Changed some configuration parameters in the demo app. * Tweaked the demo. * Added ChangeLog and updated ReadMe. * More changes to ReadMe. * Updated podspec. * More changes to the ChangeLog and ReadMe files. * Fixed guard indentation, as per comments. * Fixed guard indentations, as per comments.
* Added git ignore file * Added project workspace * Added tab bar template project * Added DrawerKit empty framework * Added basic view controllers and storyboards * Fixed broken outlets * Added implementation of DrawerKit. A few bits to complete still. * Hooked up the view controllers to the custom presentation. * Added clamping to the three possible resting positions of the drawer * Added more configuration to the presenting VC * Fixed a few glitches related to allowing partial expansion or not, and some refactoring. * Removed the two timing configurations and now using only one for all animations. * Added support for not having the gesture recognisers. * Fixed a potential division by zero. * Adding more configuration controls to presenting VC. WIP. * Added debug mode. * Added some TODOs * Renamed a function to make it clear it's a debugging feature. * Minor refactoring. * Renamed some source files for better clarity of intention. * Removed source headers. * Changed the presented VC to make a larger drawer (easier to play with). * Changed some parameters as per Sam's input. * Improved behaviour of corner rounding at the two edges of the screen. Still not a perfect solution because the animator's completion block is, surprisingly, not always called. Apparently, that's a bug in UIViewPropertyAnimator. * Made the logic for the drawer behaviour easier to read, because Sergey doesn't like `guard` with boolean statements. ;) * Moved some code closer to where it's actually used. * Minor formatting. * Added a fix to the corner-radius animation issue whereby the corner radius would not be set to zero because the property animator's completion would not always be called. Now we force it to zero on presentationTransitionDidEnd() (for the appropriate drawer ending positions). * Disabled automatic code signing. * The heights of the bands surrounding the resting position of the drawer are now given in absolute rather than relative terms. * Oopsie... committed a compiler error. Fixed now. * Added a scrollview to the presented view controller in the demo app, for testing how scrolling interacts with the drag gesture recogniser in the presentation controller. * Added an interaction controller, the first step in fixing the non-interactive presentation/dismissal itself. * Renamed TransitionAnimator to AnimationController. * Renamed a file to match the extension it's about. * Duh, it was supposed to be AnimationController, not AnimatorController. * Implemented interactive controller for the presentation and dismissal, and cleaned up the code for the animation controller (it doesn't need to know anything about the drawers). * Added license file and CocoaPods podspec. Not passing lint just yet. * Removed indirect access to configuration parameters. * Removed currently unused source file TransitionGeometry. * Fixed company name in the license file. * Cleared the team entry in the demo app. * Demo app: adding controls for all the configurable parameters. WIP. * Added control for manipulating cubic Bezier control points, CubicBezierView. * Added all the controls to the presenter VC. * Fixed a TODO comment. * Make sure that durationInSeconds is a positive value. * Removed all references to coversStatusBar since that hasn't been implemented yet. * Make sure that flickSpeedThreshold is a non-negative value. Also, if zero, disables support for flicking. * Make sure that upperMarkGap and lowerMarkGap are non-negative values. * Only add debugging mark lines if at least one of upperMarkGap and lowerMarkGap is a positive value. * Make sure that maximumCornerRadius is a non-negative value. * Only animate the corner radius if maximumCornerRadius is strictly positive. * Make sure that numberOfTapsForOutsideDrawerDismissal is a non-negative value. * Resolved an issue with animating rounding the presented view corners. * Simplified the demo app to its bare essentials. No more configuration controls to the wazoo. * Added based documentation to the library. * Preliminary version of README. WIP. * Removed unused assets. * Added some pseudo-code to the README, to explain the presentation/dismissal logic. * Code style change. * Removed unnecessary [weak self] capture lists. * Changed default value of durationInSeconds from 0.8 to 0.3 seconds. * Fixed a botched global search/replace in DrawerConfiguration+Equatable. * Renamed evil local gr variables to less evil names. * Fixed guard statements as per comments. * Removed a comment. * Removed a protocol extension. * Make sure that the height of the partially expanded drawer is non-negative. * Added documentation to all exposed public entities. * Style change as per comments. * Fixed documentation. * Updated README file. * Tweaked the README file. * Decreased the deployment target requirement, from 10.3 to 10.0. * Removed hidden extension in the LICENSE file. * Fixed source_files entry in the podspec. Removed the exclude_files entry. * Added a .swift-version file with the appropriate version of Swift to pod lib lint the pod. * Fixed the homepage in the podspec. * Fixed a bug when running under iOS 10 in which the initial presentation animation doesn't complete, therefore not invoking viewDidAppear, which causes the drawer not to show up at all. The work-around means that the initial presentation and dismissal aren't interactive but Product signed off on that decision. The drawers work fine under iOS 11. * Style change. * Killed the use of IUO references. * Changed author email address in the podspec. * Added support for Carthage. * [ci skip] Removed a commented out section from the README. Also, an excuse to turn CI off since DrawerKit fails it for lack of configuration for testing. * Added CircleCI config file. (#9) * Added CircleCI config file. * Changed circle.yml to "test" with the simulator, which disables testing * Let's try this one more time, shall we? * And again * Fixed circle.yml * And again * Fixed circle.yml * Fixed circle.yml. * Added CircleCI badge to README. * Simplified circle.yml build command. * Added dependency management commands to circle.yml * Fixed podspec source item. (#12) * Fixed podspec source item. * Missed the s in https. * DrawerKit release 0.0.1 (#13) (#14) * Added git ignore file * Added project workspace * Added tab bar template project * Added DrawerKit empty framework * Added basic view controllers and storyboards * Fixed broken outlets * Added implementation of DrawerKit. A few bits to complete still. * Hooked up the view controllers to the custom presentation. * Added clamping to the three possible resting positions of the drawer * Added more configuration to the presenting VC * Fixed a few glitches related to allowing partial expansion or not, and some refactoring. * Removed the two timing configurations and now using only one for all animations. * Added support for not having the gesture recognisers. * Fixed a potential division by zero. * Adding more configuration controls to presenting VC. WIP. * Added debug mode. * Added some TODOs * Renamed a function to make it clear it's a debugging feature. * Minor refactoring. * Renamed some source files for better clarity of intention. * Removed source headers. * Changed the presented VC to make a larger drawer (easier to play with). * Changed some parameters as per Sam's input. * Improved behaviour of corner rounding at the two edges of the screen. Still not a perfect solution because the animator's completion block is, surprisingly, not always called. Apparently, that's a bug in UIViewPropertyAnimator. * Made the logic for the drawer behaviour easier to read, because Sergey doesn't like `guard` with boolean statements. ;) * Moved some code closer to where it's actually used. * Minor formatting. * Added a fix to the corner-radius animation issue whereby the corner radius would not be set to zero because the property animator's completion would not always be called. Now we force it to zero on presentationTransitionDidEnd() (for the appropriate drawer ending positions). * Disabled automatic code signing. * The heights of the bands surrounding the resting position of the drawer are now given in absolute rather than relative terms. * Oopsie... committed a compiler error. Fixed now. * Added a scrollview to the presented view controller in the demo app, for testing how scrolling interacts with the drag gesture recogniser in the presentation controller. * Added an interaction controller, the first step in fixing the non-interactive presentation/dismissal itself. * Renamed TransitionAnimator to AnimationController. * Renamed a file to match the extension it's about. * Duh, it was supposed to be AnimationController, not AnimatorController. * Implemented interactive controller for the presentation and dismissal, and cleaned up the code for the animation controller (it doesn't need to know anything about the drawers). * Added license file and CocoaPods podspec. Not passing lint just yet. * Removed indirect access to configuration parameters. * Removed currently unused source file TransitionGeometry. * Fixed company name in the license file. * Cleared the team entry in the demo app. * Demo app: adding controls for all the configurable parameters. WIP. * Added control for manipulating cubic Bezier control points, CubicBezierView. * Added all the controls to the presenter VC. * Fixed a TODO comment. * Make sure that durationInSeconds is a positive value. * Removed all references to coversStatusBar since that hasn't been implemented yet. * Make sure that flickSpeedThreshold is a non-negative value. Also, if zero, disables support for flicking. * Make sure that upperMarkGap and lowerMarkGap are non-negative values. * Only add debugging mark lines if at least one of upperMarkGap and lowerMarkGap is a positive value. * Make sure that maximumCornerRadius is a non-negative value. * Only animate the corner radius if maximumCornerRadius is strictly positive. * Make sure that numberOfTapsForOutsideDrawerDismissal is a non-negative value. * Resolved an issue with animating rounding the presented view corners. * Simplified the demo app to its bare essentials. No more configuration controls to the wazoo. * Added based documentation to the library. * Preliminary version of README. WIP. * Removed unused assets. * Added some pseudo-code to the README, to explain the presentation/dismissal logic. * Code style change. * Removed unnecessary [weak self] capture lists. * Changed default value of durationInSeconds from 0.8 to 0.3 seconds. * Fixed a botched global search/replace in DrawerConfiguration+Equatable. * Renamed evil local gr variables to less evil names. * Fixed guard statements as per comments. * Removed a comment. * Removed a protocol extension. * Make sure that the height of the partially expanded drawer is non-negative. * Added documentation to all exposed public entities. * Style change as per comments. * Fixed documentation. * Updated README file. * Tweaked the README file. * Decreased the deployment target requirement, from 10.3 to 10.0. * Removed hidden extension in the LICENSE file. * Fixed source_files entry in the podspec. Removed the exclude_files entry. * Added a .swift-version file with the appropriate version of Swift to pod lib lint the pod. * Fixed the homepage in the podspec. * Fixed a bug when running under iOS 10 in which the initial presentation animation doesn't complete, therefore not invoking viewDidAppear, which causes the drawer not to show up at all. The work-around means that the initial presentation and dismissal aren't interactive but Product signed off on that decision. The drawers work fine under iOS 11. * Style change. * Killed the use of IUO references. * Changed author email address in the podspec. * Added support for Carthage. * [ci skip] Removed a commented out section from the README. Also, an excuse to turn CI off since DrawerKit fails it for lack of configuration for testing. * Added CircleCI config file. (#9) * Added CircleCI config file. * Changed circle.yml to "test" with the simulator, which disables testing * Let's try this one more time, shall we? * And again * Fixed circle.yml * And again * Fixed circle.yml * Fixed circle.yml. * Added CircleCI badge to README. * Simplified circle.yml build command. * Added dependency management commands to circle.yml * Fixed podspec source item. (#12) * Fixed podspec source item. * Missed the s in https. * Add gif and fixes the circle CI badge. (#17) * Adds a gif and fixes the circleci badge. * Moved the gif down a bit. * Removed extra space below the gif. * Changes version from 0.0.1 to 0.1. (#18) * Add missing link to Carthage (#15) * Fix to README (#21) * Changed version number from 0.0.1 to 0.1.1 in the dependency management sections of the README file. * Fix README as per David's suggestion. * Update podspec in preparation for release 0.1.2. * Revert "Update podspec in preparation for release 0.1.2." This reverts commit df1c07a. * Add 4 UI tests to check the Drawer Kit demo app is working (#22) - Open the drawer - Close the drawer - Slide to full screen - Tap close on fully open drawer * Run UI Tests as part of the CircleCI build (#25) * Experiment in running the UI tests as part of the circleci build * Fixed name in scheme * Change simulator being used to match local environment * Add scheme for demo with UI tests * Between a branch build and the merge the version available for the simulator seems to have changed. This updates the yml file to reflect this (#26) * New features (#27) * Update README.md (#23) * Fixed version number in Carthage section. * Renamed some properties and functions, for better clarity of intention. * More renaming along the same lines as the last commit. * Added support for tapping on the drawer to fully present it * More renaming. * Turned on debug mode in the demo app. * Make sure that quantities are always in their expected ranges. * Introduced an enumeration for drawer states * Removed extra blank line * Replaced the DrawerPresenting protocol with a new protocol, DrawerCoordinating, and made it so that objects other than view controllers can also coordinate the presentation of drawers. * Changed some configuration parameters in the demo app. * Tweaked the demo. * Added ChangeLog and updated ReadMe. * More changes to ReadMe. * Updated podspec. * More changes to the ChangeLog and ReadMe files. * Fixed guard indentation, as per comments. * Fixed guard indentations, as per comments. * New features and preparation for release 0.3.0 (#30) * Update README.md (#23) * Fixed version number in Carthage section. * Renamed some properties and functions, for better clarity of intention. * More renaming along the same lines as the last commit. * Added support for tapping on the drawer to fully present it * More renaming. * Turned on debug mode in the demo app. * Make sure that quantities are always in their expected ranges. * Introduced an enumeration for drawer states * Removed extra blank line * Replaced the DrawerPresenting protocol with a new protocol, DrawerCoordinating, and made it so that objects other than view controllers can also coordinate the presentation of drawers. * Changed some configuration parameters in the demo app. * Large refactoring work in preparation for adding concurrent animations. * WIP on concurrent animations * Replaced the suffix Signature with Handler in DrawerAnimationActions. * Added a number of TODO comments * Minor change, for clarity. * Changed some config params in the demo app. * Turns out it's ok to simply return false in these two comparisons. * Fixed code formatting. * Fixed a subtle bug whereby UIKit animations that ended at positions differing by as much as 0.5 points were considered to have ended at different points when they should have ended at the same position. * Fixed a bug whereby scaling animated in only one direction. * Added example animations from the collapsed state to the fully expanded state, and back. * Added support for automatically adding a handle view and automatically animating it. * Added support for not covering a portion of the screen when fully expanding the drawer. * Removed TODOs that have been handled already. * Small refactoring. * More refactoring. * Added previous gif. * Display the gifs at the same size. * Removed an extraneous comment. * Minor English corrections. * Renamed some properties to avoid abbreviations. Not all abbreviations could be removed, however, because Swift doesn't allow functions and properties to have the same name. * Merge master into dev (#32) * Update README.md (#23) * Release 0.2.0 (#28) * Added git ignore file * Added project workspace * Added tab bar template project * Added DrawerKit empty framework * Added basic view controllers and storyboards * Fixed broken outlets * Added implementation of DrawerKit. A few bits to complete still. * Hooked up the view controllers to the custom presentation. * Added clamping to the three possible resting positions of the drawer * Added more configuration to the presenting VC * Fixed a few glitches related to allowing partial expansion or not, and some refactoring. * Removed the two timing configurations and now using only one for all animations. * Added support for not having the gesture recognisers. * Fixed a potential division by zero. * Adding more configuration controls to presenting VC. WIP. * Added debug mode. * Added some TODOs * Renamed a function to make it clear it's a debugging feature. * Minor refactoring. * Renamed some source files for better clarity of intention. * Removed source headers. * Changed the presented VC to make a larger drawer (easier to play with). * Changed some parameters as per Sam's input. * Improved behaviour of corner rounding at the two edges of the screen. Still not a perfect solution because the animator's completion block is, surprisingly, not always called. Apparently, that's a bug in UIViewPropertyAnimator. * Made the logic for the drawer behaviour easier to read, because Sergey doesn't like `guard` with boolean statements. ;) * Moved some code closer to where it's actually used. * Minor formatting. * Added a fix to the corner-radius animation issue whereby the corner radius would not be set to zero because the property animator's completion would not always be called. Now we force it to zero on presentationTransitionDidEnd() (for the appropriate drawer ending positions). * Disabled automatic code signing. * The heights of the bands surrounding the resting position of the drawer are now given in absolute rather than relative terms. * Oopsie... committed a compiler error. Fixed now. * Added a scrollview to the presented view controller in the demo app, for testing how scrolling interacts with the drag gesture recogniser in the presentation controller. * Added an interaction controller, the first step in fixing the non-interactive presentation/dismissal itself. * Renamed TransitionAnimator to AnimationController. * Renamed a file to match the extension it's about. * Duh, it was supposed to be AnimationController, not AnimatorController. * Implemented interactive controller for the presentation and dismissal, and cleaned up the code for the animation controller (it doesn't need to know anything about the drawers). * Added license file and CocoaPods podspec. Not passing lint just yet. * Removed indirect access to configuration parameters. * Removed currently unused source file TransitionGeometry. * Fixed company name in the license file. * Cleared the team entry in the demo app. * Demo app: adding controls for all the configurable parameters. WIP. * Added control for manipulating cubic Bezier control points, CubicBezierView. * Added all the controls to the presenter VC. * Fixed a TODO comment. * Make sure that durationInSeconds is a positive value. * Removed all references to coversStatusBar since that hasn't been implemented yet. * Make sure that flickSpeedThreshold is a non-negative value. Also, if zero, disables support for flicking. * Make sure that upperMarkGap and lowerMarkGap are non-negative values. * Only add debugging mark lines if at least one of upperMarkGap and lowerMarkGap is a positive value. * Make sure that maximumCornerRadius is a non-negative value. * Only animate the corner radius if maximumCornerRadius is strictly positive. * Make sure that numberOfTapsForOutsideDrawerDismissal is a non-negative value. * Resolved an issue with animating rounding the presented view corners. * Simplified the demo app to its bare essentials. No more configuration controls to the wazoo. * Added based documentation to the library. * Preliminary version of README. WIP. * Removed unused assets. * Added some pseudo-code to the README, to explain the presentation/dismissal logic. * Code style change. * Removed unnecessary [weak self] capture lists. * Changed default value of durationInSeconds from 0.8 to 0.3 seconds. * Fixed a botched global search/replace in DrawerConfiguration+Equatable. * Renamed evil local gr variables to less evil names. * Fixed guard statements as per comments. * Removed a comment. * Removed a protocol extension. * Make sure that the height of the partially expanded drawer is non-negative. * Added documentation to all exposed public entities. * Style change as per comments. * Fixed documentation. * Updated README file. * Tweaked the README file. * Decreased the deployment target requirement, from 10.3 to 10.0. * Removed hidden extension in the LICENSE file. * Fixed source_files entry in the podspec. Removed the exclude_files entry. * Added a .swift-version file with the appropriate version of Swift to pod lib lint the pod. * Fixed the homepage in the podspec. * Fixed a bug when running under iOS 10 in which the initial presentation animation doesn't complete, therefore not invoking viewDidAppear, which causes the drawer not to show up at all. The work-around means that the initial presentation and dismissal aren't interactive but Product signed off on that decision. The drawers work fine under iOS 11. * Style change. * Killed the use of IUO references. * Changed author email address in the podspec. * Added support for Carthage. * [ci skip] Removed a commented out section from the README. Also, an excuse to turn CI off since DrawerKit fails it for lack of configuration for testing. * Added CircleCI config file. (#9) * Added CircleCI config file. * Changed circle.yml to "test" with the simulator, which disables testing * Let's try this one more time, shall we? * And again * Fixed circle.yml * And again * Fixed circle.yml * Fixed circle.yml. * Added CircleCI badge to README. * Simplified circle.yml build command. * Added dependency management commands to circle.yml * Fixed podspec source item. (#12) * Fixed podspec source item. * Missed the s in https. * DrawerKit release 0.0.1 (#13) (#14) * Added git ignore file * Added project workspace * Added tab bar template project * Added DrawerKit empty framework * Added basic view controllers and storyboards * Fixed broken outlets * Added implementation of DrawerKit. A few bits to complete still. * Hooked up the view controllers to the custom presentation. * Added clamping to the three possible resting positions of the drawer * Added more configuration to the presenting VC * Fixed a few glitches related to allowing partial expansion or not, and some refactoring. * Removed the two timing configurations and now using only one for all animations. * Added support for not having the gesture recognisers. * Fixed a potential division by zero. * Adding more configuration controls to presenting VC. WIP. * Added debug mode. * Added some TODOs * Renamed a function to make it clear it's a debugging feature. * Minor refactoring. * Renamed some source files for better clarity of intention. * Removed source headers. * Changed the presented VC to make a larger drawer (easier to play with). * Changed some parameters as per Sam's input. * Improved behaviour of corner rounding at the two edges of the screen. Still not a perfect solution because the animator's completion block is, surprisingly, not always called. Apparently, that's a bug in UIViewPropertyAnimator. * Made the logic for the drawer behaviour easier to read, because Sergey doesn't like `guard` with boolean statements. ;) * Moved some code closer to where it's actually used. * Minor formatting. * Added a fix to the corner-radius animation issue whereby the corner radius would not be set to zero because the property animator's completion would not always be called. Now we force it to zero on presentationTransitionDidEnd() (for the appropriate drawer ending positions). * Disabled automatic code signing. * The heights of the bands surrounding the resting position of the drawer are now given in absolute rather than relative terms. * Oopsie... committed a compiler error. Fixed now. * Added a scrollview to the presented view controller in the demo app, for testing how scrolling interacts with the drag gesture recogniser in the presentation controller. * Added an interaction controller, the first step in fixing the non-interactive presentation/dismissal itself. * Renamed TransitionAnimator to AnimationController. * Renamed a file to match the extension it's about. * Duh, it was supposed to be AnimationController, not AnimatorController. * Implemented interactive controller for the presentation and dismissal, and cleaned up the code for the animation controller (it doesn't need to know anything about the drawers). * Added license file and CocoaPods podspec. Not passing lint just yet. * Removed indirect access to configuration parameters. * Removed currently unused source file TransitionGeometry. * Fixed company name in the license file. * Cleared the team entry in the demo app. * Demo app: adding controls for all the configurable parameters. WIP. * Added control for manipulating cubic Bezier control points, CubicBezierView. * Added all the controls to the presenter VC. * Fixed a TODO comment. * Make sure that durationInSeconds is a positive value. * Removed all references to coversStatusBar since that hasn't been implemented yet. * Make sure that flickSpeedThreshold is a non-negative value. Also, if zero, disables support for flicking. * Make sure that upperMarkGap and lowerMarkGap are non-negative values. * Only add debugging mark lines if at least one of upperMarkGap and lowerMarkGap is a positive value. * Make sure that maximumCornerRadius is a non-negative value. * Only animate the corner radius if maximumCornerRadius is strictly positive. * Make sure that numberOfTapsForOutsideDrawerDismissal is a non-negative value. * Resolved an issue with animating rounding the presented view corners. * Simplified the demo app to its bare essentials. No more configuration controls to the wazoo. * Added based documentation to the library. * Preliminary version of README. WIP. * Removed unused assets. * Added some pseudo-code to the README, to explain the presentation/dismissal logic. * Code style change. * Removed unnecessary [weak self] capture lists. * Changed default value of durationInSeconds from 0.8 to 0.3 seconds. * Fixed a botched global search/replace in DrawerConfiguration+Equatable. * Renamed evil local gr variables to less evil names. * Fixed guard statements as per comments. * Removed a comment. * Removed a protocol extension. * Make sure that the height of the partially expanded drawer is non-negative. * Added documentation to all exposed public entities. * Style change as per comments. * Fixed documentation. * Updated README file. * Tweaked the README file. * Decreased the deployment target requirement, from 10.3 to 10.0. * Removed hidden extension in the LICENSE file. * Fixed source_files entry in the podspec. Removed the exclude_files entry. * Added a .swift-version file with the appropriate version of Swift to pod lib lint the pod. * Fixed the homepage in the podspec. * Fixed a bug when running under iOS 10 in which the initial presentation animation doesn't complete, therefore not invoking viewDidAppear, which causes the drawer not to show up at all. The work-around means that the initial presentation and dismissal aren't interactive but Product signed off on that decision. The drawers work fine under iOS 11. * Style change. * Killed the use of IUO references. * Changed author email address in the podspec. * Added support for Carthage. * [ci skip] Removed a commented out section from the README. Also, an excuse to turn CI off since DrawerKit fails it for lack of configuration for testing. * Added CircleCI config file. (#9) * Added CircleCI config file. * Changed circle.yml to "test" with the simulator, which disables testing * Let's try this one more time, shall we? * And again * Fixed circle.yml * And again * Fixed circle.yml * Fixed circle.yml. * Added CircleCI badge to README. * Simplified circle.yml build command. * Added dependency management commands to circle.yml * Fixed podspec source item. (#12) * Fixed podspec source item. * Missed the s in https. * Add gif and fixes the circle CI badge. (#17) * Adds a gif and fixes the circleci badge. * Moved the gif down a bit. * Removed extra space below the gif. * Changes version from 0.0.1 to 0.1. (#18) * Add missing link to Carthage (#15) * Fix to README (#21) * Changed version number from 0.0.1 to 0.1.1 in the dependency management sections of the README file. * Fix README as per David's suggestion. * Update podspec in preparation for release 0.1.2. * Revert "Update podspec in preparation for release 0.1.2." This reverts commit df1c07a. * Add 4 UI tests to check the Drawer Kit demo app is working (#22) - Open the drawer - Close the drawer - Slide to full screen - Tap close on fully open drawer * Run UI Tests as part of the CircleCI build (#25) * Experiment in running the UI tests as part of the circleci build * Fixed name in scheme * Change simulator being used to match local environment * Add scheme for demo with UI tests * Between a branch build and the merge the version available for the simulator seems to have changed. This updates the yml file to reflect this (#26) * New features (#27) * Update README.md (#23) * Fixed version number in Carthage section. * Renamed some properties and functions, for better clarity of intention. * More renaming along the same lines as the last commit. * Added support for tapping on the drawer to fully present it * More renaming. * Turned on debug mode in the demo app. * Make sure that quantities are always in their expected ranges. * Introduced an enumeration for drawer states * Removed extra blank line * Replaced the DrawerPresenting protocol with a new protocol, DrawerCoordinating, and made it so that objects other than view controllers can also coordinate the presentation of drawers. * Changed some configuration parameters in the demo app. * Tweaked the demo. * Added ChangeLog and updated ReadMe. * More changes to ReadMe. * Updated podspec. * More changes to the ChangeLog and ReadMe files. * Fixed guard indentation, as per comments. * Fixed guard indentations, as per comments. * Removed files that were supposed to have been removed already. * Removed files that were supposed to have been removed already.
…the presenting and presented view controllers.
…d, when transitions are about to start, and when they are completed.
wltrup
requested review from
diegopetrucci,
RuiAAPeres,
dmcrodrigues and
AnnKatF
| let presentingDrawerAnimationActions: DrawerAnimationActions | ||
| let presentedDrawerAnimationActions: DrawerAnimationActions | ||
|
|
||
| init(isPresentation: Bool, |
There was a problem hiding this comment.
What does isPresentation refer to?
There was a problem hiding this comment.
@diegopetrucci isPresentation == true if the drawer is being presented (i.e., going up from collapsed) and isPresentation == false if the drawer is being dismissed (i.e., going down to collapsed)
There was a problem hiding this comment.
Would prefer to be an enum to document this. TransitionStatus = isPresenting | isDismissing
There was a problem hiding this comment.
@RuiAAPeres It's a boolean. It has only two values and it's already self-documented by having a good name. I don't think creating an enumeration for it buys us any more understanding, but it adds more clutter.
There was a problem hiding this comment.
I don't really have any strong opinion on this flag vs enum. Maybe a name change to isPresenting.
RuiAAPeres
reviewed
Nov 8, 2017
| init(isPresentation: Bool, | ||
| configuration: DrawerConfiguration, | ||
| presentingDrawerAnimationActions: DrawerAnimationActions, | ||
| presentedDrawerAnimationActions: DrawerAnimationActions) { |
There was a problem hiding this comment.
I think these should be provided, either as optionals, or with a default value. My reasoning for this, it's because you can pretty much create a DrawerAnimationActions with no params. (DrawerAnimationActions())
There was a problem hiding this comment.
@RuiAAPeres AnimationController is an internal object created by DrawerDisplayController to which animation duties are delegated. It has no independent existence outside of the internal API so its arguments are injected by DrawerDisplayController. It seems strange to me to give it more flexibility than it requires.
There was a problem hiding this comment.
Doesn't matter if it's internal or external. Someone still needs to interact with it. You are forcing the consumer to pass a DrawerAnimationActions even if he doesn't have any reason to do so.
There was a problem hiding this comment.
even if he doesn't have any reason to do so.
The DrawerDisplayController will always have an instance of DrawerAnimationActions for each of the two view controllers, be them empty ones or ones with actual actions. DrawerDisplayController is the source of truth and that's ultimately why these actions are injected.
RuiAAPeres
reviewed
Nov 8, 2017
| presentedVC: UIViewController, | ||
| presentedDrawerAnimationActions: DrawerAnimationActions, |
There was a problem hiding this comment.
@RuiAAPeres Similar argument as that presented in #36 (comment).
RuiAAPeres
reviewed
Nov 8, 2017
| @@ -15,6 +15,9 @@ public final class DrawerDisplayController: NSObject { | |||
| weak var presentingVC: UIViewController? | |||
| /* strong */ var presentedVC: (UIViewController & DrawerPresentable) | |||
|
|
|||
| let presentingDrawerAnimationActions: DrawerAnimationActions | |||
| let presentedDrawerAnimationActions: DrawerAnimationActions | |||
There was a problem hiding this comment.
@RuiAAPeres They need to be internal because they're accessed outside of this compilation unit.
There was a problem hiding this comment.
DrawerDisplayController+Extensions.swift which injects them into PresentationController.swift and AnimationController.swift, and they get used in PresentationController+Animation.swift and AnimationSupport.swift.
mluisbrown
approved these changes
Nov 8, 2017
|
|
||
|
|
||
| extension NotificationCenter { | ||
| private static let _$key$_ = "_$key$_" |
There was a problem hiding this comment.
No good reason now. This type-safe use of notifications comes from something I worked out (https://github.com/wltrup/Swift-Typed-Notifications) after one of the objc.io talks and, at the time, for reasons I can't fathom now, I used that weird name. Given that it's private, I should - and will - change it to something more sensible.
AnnKatF
reviewed
Nov 8, 2017
| break | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Aren't you missing remove the notification observer in this view controller?
There was a problem hiding this comment.
@AnnKatF No. The view controller stores a notification token (an instance of a class) and, when the view controller goes out of scope, the token gets released, which invokes deinit on the token class, which removes the notification observer.
RuiAAPeres
reviewed
Nov 8, 2017
|
|
||
| deinit { center.removeObserver(token) } | ||
| } | ||
|
|
RuiAAPeres
reviewed
Nov 8, 2017
| public protocol NotificationEnum { | ||
| var name: Notification.Name { get } | ||
| } | ||
|
|
|
|
||
|
|
||
| extension NotificationCenter { | ||
| private static let _$key$_ = "_$key$_" |
There was a problem hiding this comment.
_$key$_ any reason to be this format? Couldn't be just private static let key = "key"?
I looked for it and didn't find anything.
There was a problem hiding this comment.
There was a problem hiding this comment.
@daniloaliberti Fixed in dedc463.
andersio
reviewed
Nov 8, 2017
| _ info: DrawerAnimationInfo) { | ||
| (presentingVC as? DrawerAnimationParticipant)?.drawerAnimationActions.prepare?(info) | ||
| (presentedVC as? DrawerAnimationParticipant)?.drawerAnimationActions.prepare?(info) | ||
| NotificationCenter.default.post(notification: DrawerNotification.transitionWillStart(info: info)) |
There was a problem hiding this comment.
Is it possible to rely on protocols instead? It feels like we could do better than falling back to global messaging.
There was a problem hiding this comment.
@andersio It is possible but I'd essentially have to reinvent the wheel and maintain my own queue of notification observers, each conforming to the protocol in question. There's no telling how many clients might be interested in these notifications.
diegopetrucci
approved these changes
Nov 8, 2017
dmcrodrigues
pushed a commit
that referenced
this pull request
Nov 8, 2017
* Added git ignore file * Added project workspace * Added tab bar template project * Added DrawerKit empty framework * Added basic view controllers and storyboards * Fixed broken outlets * Added implementation of DrawerKit. A few bits to complete still. * Hooked up the view controllers to the custom presentation. * Added clamping to the three possible resting positions of the drawer * Added more configuration to the presenting VC * Fixed a few glitches related to allowing partial expansion or not, and some refactoring. * Removed the two timing configurations and now using only one for all animations. * Added support for not having the gesture recognisers. * Fixed a potential division by zero. * Adding more configuration controls to presenting VC. WIP. * Added debug mode. * Added some TODOs * Renamed a function to make it clear it's a debugging feature. * Minor refactoring. * Renamed some source files for better clarity of intention. * Removed source headers. * Changed the presented VC to make a larger drawer (easier to play with). * Changed some parameters as per Sam's input. * Improved behaviour of corner rounding at the two edges of the screen. Still not a perfect solution because the animator's completion block is, surprisingly, not always called. Apparently, that's a bug in UIViewPropertyAnimator. * Made the logic for the drawer behaviour easier to read, because Sergey doesn't like `guard` with boolean statements. ;) * Moved some code closer to where it's actually used. * Minor formatting. * Added a fix to the corner-radius animation issue whereby the corner radius would not be set to zero because the property animator's completion would not always be called. Now we force it to zero on presentationTransitionDidEnd() (for the appropriate drawer ending positions). * Disabled automatic code signing. * The heights of the bands surrounding the resting position of the drawer are now given in absolute rather than relative terms. * Oopsie... committed a compiler error. Fixed now. * Added a scrollview to the presented view controller in the demo app, for testing how scrolling interacts with the drag gesture recogniser in the presentation controller. * Added an interaction controller, the first step in fixing the non-interactive presentation/dismissal itself. * Renamed TransitionAnimator to AnimationController. * Renamed a file to match the extension it's about. * Duh, it was supposed to be AnimationController, not AnimatorController. * Implemented interactive controller for the presentation and dismissal, and cleaned up the code for the animation controller (it doesn't need to know anything about the drawers). * Added license file and CocoaPods podspec. Not passing lint just yet. * Removed indirect access to configuration parameters. * Removed currently unused source file TransitionGeometry. * Fixed company name in the license file. * Cleared the team entry in the demo app. * Demo app: adding controls for all the configurable parameters. WIP. * Added control for manipulating cubic Bezier control points, CubicBezierView. * Added all the controls to the presenter VC. * Fixed a TODO comment. * Make sure that durationInSeconds is a positive value. * Removed all references to coversStatusBar since that hasn't been implemented yet. * Make sure that flickSpeedThreshold is a non-negative value. Also, if zero, disables support for flicking. * Make sure that upperMarkGap and lowerMarkGap are non-negative values. * Only add debugging mark lines if at least one of upperMarkGap and lowerMarkGap is a positive value. * Make sure that maximumCornerRadius is a non-negative value. * Only animate the corner radius if maximumCornerRadius is strictly positive. * Make sure that numberOfTapsForOutsideDrawerDismissal is a non-negative value. * Resolved an issue with animating rounding the presented view corners. * Simplified the demo app to its bare essentials. No more configuration controls to the wazoo. * Added based documentation to the library. * Preliminary version of README. WIP. * Removed unused assets. * Added some pseudo-code to the README, to explain the presentation/dismissal logic. * Code style change. * Removed unnecessary [weak self] capture lists. * Changed default value of durationInSeconds from 0.8 to 0.3 seconds. * Fixed a botched global search/replace in DrawerConfiguration+Equatable. * Renamed evil local gr variables to less evil names. * Fixed guard statements as per comments. * Removed a comment. * Removed a protocol extension. * Make sure that the height of the partially expanded drawer is non-negative. * Added documentation to all exposed public entities. * Style change as per comments. * Fixed documentation. * Updated README file. * Tweaked the README file. * Decreased the deployment target requirement, from 10.3 to 10.0. * Removed hidden extension in the LICENSE file. * Fixed source_files entry in the podspec. Removed the exclude_files entry. * Added a .swift-version file with the appropriate version of Swift to pod lib lint the pod. * Fixed the homepage in the podspec. * Fixed a bug when running under iOS 10 in which the initial presentation animation doesn't complete, therefore not invoking viewDidAppear, which causes the drawer not to show up at all. The work-around means that the initial presentation and dismissal aren't interactive but Product signed off on that decision. The drawers work fine under iOS 11. * Style change. * Killed the use of IUO references. * Changed author email address in the podspec. * Added support for Carthage. * [ci skip] Removed a commented out section from the README. Also, an excuse to turn CI off since DrawerKit fails it for lack of configuration for testing. * Added CircleCI config file. (#9) * Added CircleCI config file. * Changed circle.yml to "test" with the simulator, which disables testing * Let's try this one more time, shall we? * And again * Fixed circle.yml * And again * Fixed circle.yml * Fixed circle.yml. * Added CircleCI badge to README. * Simplified circle.yml build command. * Added dependency management commands to circle.yml * Fixed podspec source item. (#12) * Fixed podspec source item. * Missed the s in https. * DrawerKit release 0.0.1 (#13) (#14) * Added git ignore file * Added project workspace * Added tab bar template project * Added DrawerKit empty framework * Added basic view controllers and storyboards * Fixed broken outlets * Added implementation of DrawerKit. A few bits to complete still. * Hooked up the view controllers to the custom presentation. * Added clamping to the three possible resting positions of the drawer * Added more configuration to the presenting VC * Fixed a few glitches related to allowing partial expansion or not, and some refactoring. * Removed the two timing configurations and now using only one for all animations. * Added support for not having the gesture recognisers. * Fixed a potential division by zero. * Adding more configuration controls to presenting VC. WIP. * Added debug mode. * Added some TODOs * Renamed a function to make it clear it's a debugging feature. * Minor refactoring. * Renamed some source files for better clarity of intention. * Removed source headers. * Changed the presented VC to make a larger drawer (easier to play with). * Changed some parameters as per Sam's input. * Improved behaviour of corner rounding at the two edges of the screen. Still not a perfect solution because the animator's completion block is, surprisingly, not always called. Apparently, that's a bug in UIViewPropertyAnimator. * Made the logic for the drawer behaviour easier to read, because Sergey doesn't like `guard` with boolean statements. ;) * Moved some code closer to where it's actually used. * Minor formatting. * Added a fix to the corner-radius animation issue whereby the corner radius would not be set to zero because the property animator's completion would not always be called. Now we force it to zero on presentationTransitionDidEnd() (for the appropriate drawer ending positions). * Disabled automatic code signing. * The heights of the bands surrounding the resting position of the drawer are now given in absolute rather than relative terms. * Oopsie... committed a compiler error. Fixed now. * Added a scrollview to the presented view controller in the demo app, for testing how scrolling interacts with the drag gesture recogniser in the presentation controller. * Added an interaction controller, the first step in fixing the non-interactive presentation/dismissal itself. * Renamed TransitionAnimator to AnimationController. * Renamed a file to match the extension it's about. * Duh, it was supposed to be AnimationController, not AnimatorController. * Implemented interactive controller for the presentation and dismissal, and cleaned up the code for the animation controller (it doesn't need to know anything about the drawers). * Added license file and CocoaPods podspec. Not passing lint just yet. * Removed indirect access to configuration parameters. * Removed currently unused source file TransitionGeometry. * Fixed company name in the license file. * Cleared the team entry in the demo app. * Demo app: adding controls for all the configurable parameters. WIP. * Added control for manipulating cubic Bezier control points, CubicBezierView. * Added all the controls to the presenter VC. * Fixed a TODO comment. * Make sure that durationInSeconds is a positive value. * Removed all references to coversStatusBar since that hasn't been implemented yet. * Make sure that flickSpeedThreshold is a non-negative value. Also, if zero, disables support for flicking. * Make sure that upperMarkGap and lowerMarkGap are non-negative values. * Only add debugging mark lines if at least one of upperMarkGap and lowerMarkGap is a positive value. * Make sure that maximumCornerRadius is a non-negative value. * Only animate the corner radius if maximumCornerRadius is strictly positive. * Make sure that numberOfTapsForOutsideDrawerDismissal is a non-negative value. * Resolved an issue with animating rounding the presented view corners. * Simplified the demo app to its bare essentials. No more configuration controls to the wazoo. * Added based documentation to the library. * Preliminary version of README. WIP. * Removed unused assets. * Added some pseudo-code to the README, to explain the presentation/dismissal logic. * Code style change. * Removed unnecessary [weak self] capture lists. * Changed default value of durationInSeconds from 0.8 to 0.3 seconds. * Fixed a botched global search/replace in DrawerConfiguration+Equatable. * Renamed evil local gr variables to less evil names. * Fixed guard statements as per comments. * Removed a comment. * Removed a protocol extension. * Make sure that the height of the partially expanded drawer is non-negative. * Added documentation to all exposed public entities. * Style change as per comments. * Fixed documentation. * Updated README file. * Tweaked the README file. * Decreased the deployment target requirement, from 10.3 to 10.0. * Removed hidden extension in the LICENSE file. * Fixed source_files entry in the podspec. Removed the exclude_files entry. * Added a .swift-version file with the appropriate version of Swift to pod lib lint the pod. * Fixed the homepage in the podspec. * Fixed a bug when running under iOS 10 in which the initial presentation animation doesn't complete, therefore not invoking viewDidAppear, which causes the drawer not to show up at all. The work-around means that the initial presentation and dismissal aren't interactive but Product signed off on that decision. The drawers work fine under iOS 11. * Style change. * Killed the use of IUO references. * Changed author email address in the podspec. * Added support for Carthage. * [ci skip] Removed a commented out section from the README. Also, an excuse to turn CI off since DrawerKit fails it for lack of configuration for testing. * Added CircleCI config file. (#9) * Added CircleCI config file. * Changed circle.yml to "test" with the simulator, which disables testing * Let's try this one more time, shall we? * And again * Fixed circle.yml * And again * Fixed circle.yml * Fixed circle.yml. * Added CircleCI badge to README. * Simplified circle.yml build command. * Added dependency management commands to circle.yml * Fixed podspec source item. (#12) * Fixed podspec source item. * Missed the s in https. * Add gif and fixes the circle CI badge. (#17) * Adds a gif and fixes the circleci badge. * Moved the gif down a bit. * Removed extra space below the gif. * Changes version from 0.0.1 to 0.1. (#18) * Add missing link to Carthage (#15) * Fix to README (#21) * Changed version number from 0.0.1 to 0.1.1 in the dependency management sections of the README file. * Fix README as per David's suggestion. * Update podspec in preparation for release 0.1.2. * Revert "Update podspec in preparation for release 0.1.2." This reverts commit df1c07aa3ab36e1b82fc630ac847695edc928818. * Add 4 UI tests to check the Drawer Kit demo app is working (#22) - Open the drawer - Close the drawer - Slide to full screen - Tap close on fully open drawer * Run UI Tests as part of the CircleCI build (#25) * Experiment in running the UI tests as part of the circleci build * Fixed name in scheme * Change simulator being used to match local environment * Add scheme for demo with UI tests * Between a branch build and the merge the version available for the simulator seems to have changed. This updates the yml file to reflect this (#26) * New features (#27) * Update README.md (#23) * Fixed version number in Carthage section. * Renamed some properties and functions, for better clarity of intention. * More renaming along the same lines as the last commit. * Added support for tapping on the drawer to fully present it * More renaming. * Turned on debug mode in the demo app. * Make sure that quantities are always in their expected ranges. * Introduced an enumeration for drawer states * Removed extra blank line * Replaced the DrawerPresenting protocol with a new protocol, DrawerCoordinating, and made it so that objects other than view controllers can also coordinate the presentation of drawers. * Changed some configuration parameters in the demo app. * Tweaked the demo. * Added ChangeLog and updated ReadMe. * More changes to ReadMe. * Updated podspec. * More changes to the ChangeLog and ReadMe files. * Fixed guard indentation, as per comments. * Fixed guard indentations, as per comments. * New features and preparation for release 0.3.0 (#30) * Update README.md (#23) * Fixed version number in Carthage section. * Renamed some properties and functions, for better clarity of intention. * More renaming along the same lines as the last commit. * Added support for tapping on the drawer to fully present it * More renaming. * Turned on debug mode in the demo app. * Make sure that quantities are always in their expected ranges. * Introduced an enumeration for drawer states * Removed extra blank line * Replaced the DrawerPresenting protocol with a new protocol, DrawerCoordinating, and made it so that objects other than view controllers can also coordinate the presentation of drawers. * Changed some configuration parameters in the demo app. * Large refactoring work in preparation for adding concurrent animations. * WIP on concurrent animations * Replaced the suffix Signature with Handler in DrawerAnimationActions. * Added a number of TODO comments * Minor change, for clarity. * Changed some config params in the demo app. * Turns out it's ok to simply return false in these two comparisons. * Fixed code formatting. * Fixed a subtle bug whereby UIKit animations that ended at positions differing by as much as 0.5 points were considered to have ended at different points when they should have ended at the same position. * Fixed a bug whereby scaling animated in only one direction. * Added example animations from the collapsed state to the fully expanded state, and back. * Added support for automatically adding a handle view and automatically animating it. * Added support for not covering a portion of the screen when fully expanding the drawer. * Removed TODOs that have been handled already. * Small refactoring. * More refactoring. * Added previous gif. * Display the gifs at the same size. * Removed an extraneous comment. * Minor English corrections. * Renamed some properties to avoid abbreviations. Not all abbreviations could be removed, however, because Swift doesn't allow functions and properties to have the same name. * Merge master into dev (#32) * Update README.md (#23) * Release 0.2.0 (#28) * Added git ignore file * Added project workspace * Added tab bar template project * Added DrawerKit empty framework * Added basic view controllers and storyboards * Fixed broken outlets * Added implementation of DrawerKit. A few bits to complete still. * Hooked up the view controllers to the custom presentation. * Added clamping to the three possible resting positions of the drawer * Added more configuration to the presenting VC * Fixed a few glitches related to allowing partial expansion or not, and some refactoring. * Removed the two timing configurations and now using only one for all animations. * Added support for not having the gesture recognisers. * Fixed a potential division by zero. * Adding more configuration controls to presenting VC. WIP. * Added debug mode. * Added some TODOs * Renamed a function to make it clear it's a debugging feature. * Minor refactoring. * Renamed some source files for better clarity of intention. * Removed source headers. * Changed the presented VC to make a larger drawer (easier to play with). * Changed some parameters as per Sam's input. * Improved behaviour of corner rounding at the two edges of the screen. Still not a perfect solution because the animator's completion block is, surprisingly, not always called. Apparently, that's a bug in UIViewPropertyAnimator. * Made the logic for the drawer behaviour easier to read, because Sergey doesn't like `guard` with boolean statements. ;) * Moved some code closer to where it's actually used. * Minor formatting. * Added a fix to the corner-radius animation issue whereby the corner radius would not be set to zero because the property animator's completion would not always be called. Now we force it to zero on presentationTransitionDidEnd() (for the appropriate drawer ending positions). * Disabled automatic code signing. * The heights of the bands surrounding the resting position of the drawer are now given in absolute rather than relative terms. * Oopsie... committed a compiler error. Fixed now. * Added a scrollview to the presented view controller in the demo app, for testing how scrolling interacts with the drag gesture recogniser in the presentation controller. * Added an interaction controller, the first step in fixing the non-interactive presentation/dismissal itself. * Renamed TransitionAnimator to AnimationController. * Renamed a file to match the extension it's about. * Duh, it was supposed to be AnimationController, not AnimatorController. * Implemented interactive controller for the presentation and dismissal, and cleaned up the code for the animation controller (it doesn't need to know anything about the drawers). * Added license file and CocoaPods podspec. Not passing lint just yet. * Removed indirect access to configuration parameters. * Removed currently unused source file TransitionGeometry. * Fixed company name in the license file. * Cleared the team entry in the demo app. * Demo app: adding controls for all the configurable parameters. WIP. * Added control for manipulating cubic Bezier control points, CubicBezierView. * Added all the controls to the presenter VC. * Fixed a TODO comment. * Make sure that durationInSeconds is a positive value. * Removed all references to coversStatusBar since that hasn't been implemented yet. * Make sure that flickSpeedThreshold is a non-negative value. Also, if zero, disables support for flicking. * Make sure that upperMarkGap and lowerMarkGap are non-negative values. * Only add debugging mark lines if at least one of upperMarkGap and lowerMarkGap is a positive value. * Make sure that maximumCornerRadius is a non-negative value. * Only animate the corner radius if maximumCornerRadius is strictly positive. * Make sure that numberOfTapsForOutsideDrawerDismissal is a non-negative value. * Resolved an issue with animating rounding the presented view corners. * Simplified the demo app to its bare essentials. No more configuration controls to the wazoo. * Added based documentation to the library. * Preliminary version of README. WIP. * Removed unused assets. * Added some pseudo-code to the README, to explain the presentation/dismissal logic. * Code style change. * Removed unnecessary [weak self] capture lists. * Changed default value of durationInSeconds from 0.8 to 0.3 seconds. * Fixed a botched global search/replace in DrawerConfiguration+Equatable. * Renamed evil local gr variables to less evil names. * Fixed guard statements as per comments. * Removed a comment. * Removed a protocol extension. * Make sure that the height of the partially expanded drawer is non-negative. * Added documentation to all exposed public entities. * Style change as per comments. * Fixed documentation. * Updated README file. * Tweaked the README file. * Decreased the deployment target requirement, from 10.3 to 10.0. * Removed hidden extension in the LICENSE file. * Fixed source_files entry in the podspec. Removed the exclude_files entry. * Added a .swift-version file with the appropriate version of Swift to pod lib lint the pod. * Fixed the homepage in the podspec. * Fixed a bug when running under iOS 10 in which the initial presentation animation doesn't complete, therefore not invoking viewDidAppear, which causes the drawer not to show up at all. The work-around means that the initial presentation and dismissal aren't interactive but Product signed off on that decision. The drawers work fine under iOS 11. * Style change. * Killed the use of IUO references. * Changed author email address in the podspec. * Added support for Carthage. * [ci skip] Removed a commented out section from the README. Also, an excuse to turn CI off since DrawerKit fails it for lack of configuration for testing. * Added CircleCI config file. (#9) * Added CircleCI config file. * Changed circle.yml to "test" with the simulator, which disables testing * Let's try this one more time, shall we? * And again * Fixed circle.yml * And again * Fixed circle.yml * Fixed circle.yml. * Added CircleCI badge to README. * Simplified circle.yml build command. * Added dependency management commands to circle.yml * Fixed podspec source item. (#12) * Fixed podspec source item. * Missed the s in https. * DrawerKit release 0.0.1 (#13) (#14) * Added git ignore file * Added project workspace * Added tab bar template project * Added DrawerKit empty framework * Added basic view controllers and storyboards * Fixed broken outlets * Added implementation of DrawerKit. A few bits to complete still. * Hooked up the view controllers to the custom presentation. * Added clamping to the three possible resting positions of the drawer * Added more configuration to the presenting VC * Fixed a few glitches related to allowing partial expansion or not, and some refactoring. * Removed the two timing configurations and now using only one for all animations. * Added support for not having the gesture recognisers. * Fixed a potential division by zero. * Adding more configuration controls to presenting VC. WIP. * Added debug mode. * Added some TODOs * Renamed a function to make it clear it's a debugging feature. * Minor refactoring. * Renamed some source files for better clarity of intention. * Removed source headers. * Changed the presented VC to make a larger drawer (easier to play with). * Changed some parameters as per Sam's input. * Improved behaviour of corner rounding at the two edges of the screen. Still not a perfect solution because the animator's completion block is, surprisingly, not always called. Apparently, that's a bug in UIViewPropertyAnimator. * Made the logic for the drawer behaviour easier to read, because Sergey doesn't like `guard` with boolean statements. ;) * Moved some code closer to where it's actually used. * Minor formatting. * Added a fix to the corner-radius animation issue whereby the corner radius would not be set to zero because the property animator's completion would not always be called. Now we force it to zero on presentationTransitionDidEnd() (for the appropriate drawer ending positions). * Disabled automatic code signing. * The heights of the bands surrounding the resting position of the drawer are now given in absolute rather than relative terms. * Oopsie... committed a compiler error. Fixed now. * Added a scrollview to the presented view controller in the demo app, for testing how scrolling interacts with the drag gesture recogniser in the presentation controller. * Added an interaction controller, the first step in fixing the non-interactive presentation/dismissal itself. * Renamed TransitionAnimator to AnimationController. * Renamed a file to match the extension it's about. * Duh, it was supposed to be AnimationController, not AnimatorController. * Implemented interactive controller for the presentation and dismissal, and cleaned up the code for the animation controller (it doesn't need to know anything about the drawers). * Added license file and CocoaPods podspec. Not passing lint just yet. * Removed indirect access to configuration parameters. * Removed currently unused source file TransitionGeometry. * Fixed company name in the license file. * Cleared the team entry in the demo app. * Demo app: adding controls for all the configurable parameters. WIP. * Added control for manipulating cubic Bezier control points, CubicBezierView. * Added all the controls to the presenter VC. * Fixed a TODO comment. * Make sure that durationInSeconds is a positive value. * Removed all references to coversStatusBar since that hasn't been implemented yet. * Make sure that flickSpeedThreshold is a non-negative value. Also, if zero, disables support for flicking. * Make sure that upperMarkGap and lowerMarkGap are non-negative values. * Only add debugging mark lines if at least one of upperMarkGap and lowerMarkGap is a positive value. * Make sure that maximumCornerRadius is a non-negative value. * Only animate the corner radius if maximumCornerRadius is strictly positive. * Make sure that numberOfTapsForOutsideDrawerDismissal is a non-negative value. * Resolved an issue with animating rounding the presented view corners. * Simplified the demo app to its bare essentials. No more configuration controls to the wazoo. * Added based documentation to the library. * Preliminary version of README. WIP. * Removed unused assets. * Added some pseudo-code to the README, to explain the presentation/dismissal logic. * Code style change. * Removed unnecessary [weak self] capture lists. * Changed default value of durationInSeconds from 0.8 to 0.3 seconds. * Fixed a botched global search/replace in DrawerConfiguration+Equatable. * Renamed evil local gr variables to less evil names. * Fixed guard statements as per comments. * Removed a comment. * Removed a protocol extension. * Make sure that the height of the partially expanded drawer is non-negative. * Added documentation to all exposed public entities. * Style change as per comments. * Fixed documentation. * Updated README file. * Tweaked the README file. * Decreased the deployment target requirement, from 10.3 to 10.0. * Removed hidden extension in the LICENSE file. * Fixed source_files entry in the podspec. Removed the exclude_files entry. * Added a .swift-version file with the appropriate version of Swift to pod lib lint the pod. * Fixed the homepage in the podspec. * Fixed a bug when running under iOS 10 in which the initial presentation animation doesn't complete, therefore not invoking viewDidAppear, which causes the drawer not to show up at all. The work-around means that the initial presentation and dismissal aren't interactive but Product signed off on that decision. The drawers work fine under iOS 11. * Style change. * Killed the use of IUO references. * Changed author email address in the podspec. * Added support for Carthage. * [ci skip] Removed a commented out section from the README. Also, an excuse to turn CI off since DrawerKit fails it for lack of configuration for testing. * Added CircleCI config file. (#9) * Added CircleCI config file. * Changed circle.yml to "test" with the simulator, which disables testing * Let's try this one more time, shall we? * And again * Fixed circle.yml * And again * Fixed circle.yml * Fixed circle.yml. * Added CircleCI badge to README. * Simplified circle.yml build command. * Added dependency management commands to circle.yml * Fixed podspec source item. (#12) * Fixed podspec source item. * Missed the s in https. * Add gif and fixes the circle CI badge. (#17) * Adds a gif and fixes the circleci badge. * Moved the gif down a bit. * Removed extra space below the gif. * Changes version from 0.0.1 to 0.1. (#18) * Add missing link to Carthage (#15) * Fix to README (#21) * Changed version number from 0.0.1 to 0.1.1 in the dependency management sections of the README file. * Fix README as per David's suggestion. * Update podspec in preparation for release 0.1.2. * Revert "Update podspec in preparation for release 0.1.2." This reverts commit df1c07aa3ab36e1b82fc630ac847695edc928818. * Add 4 UI tests to check the Drawer Kit demo app is working (#22) - Open the drawer - Close the drawer - Slide to full screen - Tap close on fully open drawer * Run UI Tests as part of the CircleCI build (#25) * Experiment in running the UI tests as part of the circleci build * Fixed name in scheme * Change simulator being used to match local environment * Add scheme for demo with UI tests * Between a branch build and the merge the version available for the simulator seems to have changed. This updates the yml file to reflect this (#26) * New features (#27) * Update README.md (#23) * Fixed version number in Carthage section. * Renamed some properties and functions, for better clarity of intention. * More renaming along the same lines as the last commit. * Added support for tapping on the drawer to fully present it * More renaming. * Turned on debug mode in the demo app. * Make sure that quantities are always in their expected ranges. * Introduced an enumeration for drawer states * Removed extra blank line * Replaced the DrawerPresenting protocol with a new protocol, DrawerCoordinating, and made it so that objects other than view controllers can also coordinate the presentation of drawers. * Changed some configuration parameters in the demo app. * Tweaked the demo. * Added ChangeLog and updated ReadMe. * More changes to ReadMe. * Updated podspec. * More changes to the ChangeLog and ReadMe files. * Fixed guard indentation, as per comments. * Fixed guard indentations, as per comments. * New features and prep for release 0.3.1 (#36) * Update README.md (#23) * Release 0.2.0 (#28) * Added git ignore file * Added project workspace * Added tab bar template project * Added DrawerKit empty framework * Added basic view controllers and storyboards * Fixed broken outlets * Added implementation of DrawerKit. A few bits to complete still. * Hooked up the view controllers to the custom presentation. * Added clamping to the three possible resting positions of the drawer * Added more configuration to the presenting VC * Fixed a few glitches related to allowing partial expansion or not, and some refactoring. * Removed the two timing configurations and now using only one for all animations. * Added support for not having the gesture recognisers. * Fixed a potential division by zero. * Adding more configuration controls to presenting VC. WIP. * Added debug mode. * Added some TODOs * Renamed a function to make it clear it's a debugging feature. * Minor refactoring. * Renamed some source files for better clarity of intention. * Removed source headers. * Changed the presented VC to make a larger drawer (easier to play with). * Changed some parameters as per Sam's input. * Improved behaviour of corner rounding at the two edges of the screen. Still not a perfect solution because the animator's completion block is, surprisingly, not always called. Apparently, that's a bug in UIViewPropertyAnimator. * Made the logic for the drawer behaviour easier to read, because Sergey doesn't like `guard` with boolean statements. ;) * Moved some code closer to where it's actually used. * Minor formatting. * Added a fix to the corner-radius animation issue whereby the corner radius would not be set to zero because the property animator's completion would not always be called. Now we force it to zero on presentationTransitionDidEnd() (for the appropriate drawer ending positions). * Disabled automatic code signing. * The heights of the bands surrounding the resting position of the drawer are now given in absolute rather than relative terms. * Oopsie... committed a compiler error. Fixed now. * Added a scrollview to the presented view controller in the demo app, for testing how scrolling interacts with the drag gesture recogniser in the presentation controller. * Added an interaction controller, the first step in fixing the non-interactive presentation/dismissal itself. * Renamed TransitionAnimator to AnimationController. * Renamed a file to match the extension it's about. * Duh, it was supposed to be AnimationController, not AnimatorController. * Implemented interactive controller for the presentation and dismissal, and cleaned up the code for the animation controller (it doesn't need to know anything about the drawers). * Added license file and CocoaPods podspec. Not passing lint just yet. * Removed indirect access to configuration parameters. * Removed currently unused source file TransitionGeometry. * Fixed company name in the license file. * Cleared the team entry in the demo app. * Demo app: adding controls for all the configurable parameters. WIP. * Added control for manipulating cubic Bezier control points, CubicBezierView. * Added all the controls to the presenter VC. * Fixed a TODO comment. * Make sure that durationInSeconds is a positive value. * Removed all references to coversStatusBar since that hasn't been implemented yet. * Make sure that flickSpeedThreshold is a non-negative value. Also, if zero, disables support for flicking. * Make sure that upperMarkGap and lowerMarkGap are non-negative values. * Only add debugging mark lines if at least one of upperMarkGap and lowerMarkGap is a positive value. * Make sure that maximumCornerRadius is a non-negative value. * Only animate the corner radius if maximumCornerRadius is strictly positive. * Make sure that numberOfTapsForOutsideDrawerDismissal is a non-negative value. * Resolved an issue with animating rounding the presented view corners. * Simplified the demo app to its bare essentials. No more configuration controls to the wazoo. * Added based documentation to the library. * Preliminary version of README. WIP. * Removed unused assets. * Added some pseudo-code to the README, to explain the presentation/dismissal logic. * Code style change. * Removed unnecessary [weak self] capture lists. * Changed default value of durationInSeconds from 0.8 to 0.3 seconds. * Fixed a botched global search/replace in DrawerConfiguration+Equatable. * Renamed evil local gr variables to less evil names. * Fixed guard statements as per comments. * Removed a comment. * Removed a protocol extension. * Make sure that the height of the partially expanded drawer is non-negative. * Added documentation to all exposed public entities. * Style change as per comments. * Fixed documentation. * Updated README file. * Tweaked the README file. * Decreased the deployment target requirement, from 10.3 to 10.0. * Removed hidden extension in the LICENSE file. * Fixed source_files entry in the podspec. Removed the exclude_files entry. * Added a .swift-version file with the appropriate version of Swift to pod lib lint the pod. * Fixed the homepage in the podspec. * Fixed a bug when running under iOS 10 in which the initial presentation animation doesn't complete, therefore not invoking viewDidAppear, which causes the drawer not to show up at all. The work-around means that the initial presentation and dismissal aren't interactive but Product signed off on that decision. The drawers work fine under iOS 11. * Style change. * Killed the use of IUO references. * Changed author email address in the podspec. * Added support for Carthage. * [ci skip] Removed a commented out section from the README. Also, an excuse to turn CI off since DrawerKit fails it for lack of configuration for testing. * Added CircleCI config file. (#9) * Added CircleCI config file. * Changed circle.yml to "test" with the simulator, which disables testing * Let's try this one more time, shall we? * And again * Fixed circle.yml * And again * Fixed circle.yml * Fixed circle.yml. * Added CircleCI badge to README. * Simplified circle.yml build command. * Added dependency management commands to circle.yml * Fixed podspec source item. (#12) * Fixed podspec source item. * Missed the s in https. * DrawerKit release 0.0.1 (#13) (#14) * Added git ignore file * Added project workspace * Added tab bar template project * Added DrawerKit empty framework * Added basic view controllers and storyboards * Fixed broken outlets * Added implementation of DrawerKit. A few bits to complete still. * Hooked up the view controllers to the custom presentation. * Added clamping to the three possible resting positions of the drawer * Added more configuration to the presenting VC * Fixed a few glitches related to allowing partial expansion or not, and some refactoring. * Removed the two timing configurations and now using only one for all animations. * Added support for not having the gesture recognisers. * Fixed a potential division by zero. * Adding more configuration controls to presenting VC. WIP. * Added debug mode. * Added some TODOs * Renamed a function to make it clear it's a debugging feature. * Minor refactoring. * Renamed some source files for better clarity of intention. * Removed source headers. * Changed the presented VC to make a larger drawer (easier to play with). * Changed some parameters as per Sam's input. * Improved behaviour of corner rounding at the two edges of the screen. Still not a perfect solution because the animator's completion block is, surprisingly, not always called. Apparently, that's a bug in UIViewPropertyAnimator. * Made the logic for the drawer behaviour easier to read, because Sergey doesn't like `guard` with boolean statements. ;) * Moved some code closer to where it's actually used. * Minor formatting. * Added a fix to the corner-radius animation issue whereby the corner radius would not be set to zero because the property animator's completion would not always be called. Now we force it to zero on presentationTransitionDidEnd() (for the appropriate drawer ending positions). * Disabled automatic code signing. * The heights of the bands surrounding the resting position of the drawer are now given in absolute rather than relative terms. * Oopsie... committed a compiler error. Fixed now. * Added a scrollview to the presented view controller in the demo app, for testing how scrolling interacts with the drag gesture recogniser in the presentation controller. * Added an interaction controller, the first step in fixing the non-interactive presentation/dismissal itself. * Renamed TransitionAnimator to AnimationController. * Renamed a file to match the extension it's about. * Duh, it was supposed to be AnimationController, not AnimatorController. * Implemented interactive controller for the presentation and dismissal, and cleaned up the code for the animation controller (it doesn't need to know anything about the drawers). * Added license file and CocoaPods podspec. Not passing lint just yet. * Removed indirect access to configuration parameters. * Removed currently unused source file TransitionGeometry. * Fixed company name in the license file. * Cleared the team entry in the demo app. * Demo app: adding controls for all the configurable parameters. WIP. * Added control for manipulating cubic Bezier control points, CubicBezierView. * Added all the controls to the presenter VC. * Fixed a TODO comment. * Make sure that durationInSeconds is a positive value. * Removed all references to coversStatusBar since that hasn't been implemented yet. * Make sure that flickSpeedThreshold is a non-negative value. Also, if zero, disables support for flicking. * Make sure that upperMarkGap and lowerMarkGap are non-negative values. * Only add debugging mark lines if at least one of upperMarkGap and lowerMarkGap is a positive value. * Make sure that maximumCornerRadius is a non-negative value. * Only animate the corner radius if maximumCornerRadius is strictly positive. * Make sure that numberOfTapsForOutsideDrawerDismissal is a non-negative value. * Resolved an issue with animating rounding the presented view corners. * Simplified the demo app to its bare essentials. No more configuration controls to the wazoo. * Added based documentation to the library. * Preliminary version of README. WIP. * Removed unused assets. * Added some pseudo-code to the README, to explain the presentation/dismissal logic. * Code style change. * Removed unnecessary [weak self] capture lists. * Changed default value of durationInSeconds from 0.8 to 0.3 seconds. * Fixed a botched global search/replace in DrawerConfiguration+Equatable. * Renamed evil local gr variables to less evil names. * Fixed guard statements as per comments. * Removed a comment. * Removed a protocol extension. * Make sure that the height of the partially expanded drawer is non-negative. * Added documentation to all exposed public entities. * Style change as per comments. * Fixed documentation. * Updated README file. * Tweaked the README file. * Decreased the deployment target requirement, from 10.3 to 10.0. * Removed hidden extension in the LICENSE file. * Fixed source_files entry in the podspec. Removed the exclude_files entry. * Added a .swift-version file with the appropriate version of Swift to pod lib lint the pod. * Fixed the homepage in the podspec. * Fixed a bug when running under iOS 10 in which the initial presentation animation doesn't complete, therefore not invoking viewDidAppear, which causes the drawer not to show up at all. The work-around means that the initial presentation and dismissal aren't interactive but Product signed off on that decision. The drawers work fine under iOS 11. * Style change. * Killed the use of IUO references. * Changed author email address in the podspec. * Added support for Carthage. * [ci skip] Removed a commented out section from the README. Also, an excuse to turn CI off since DrawerKit fails it for lack of configuration for testing. * Added CircleCI config file. (#9) * Added CircleCI config file. * Changed circle.yml to "test" with the simulator, which disables testing * Let's try this one more time, shall we? * And again * Fixed circle.yml * And again * Fixed circle.yml * Fixed circle.yml. * Added CircleCI badge to README. * Simplified circle.yml build command. * Added dependency management commands to circle.yml * Fixed podspec source item. (#12) * Fixed podspec source item. * Missed the s in https. * Add gif and fixes the circle CI badge. (#17) * Adds a gif and fixes the circleci badge. * Moved the gif down a bit. * Removed extra space below the gif. * Changes version from 0.0.1 to 0.1. (#18) * Add missing link to Carthage (#15) * Fix to README (#21) * Changed version number from 0.0.1 to 0.1.1 in the dependency management sections of the README file. * Fix README as per David's suggestion. * Update podspec in preparation for release 0.1.2. * Revert "Update podspec in preparation for release 0.1.2." This reverts commit df1c07aa3ab36e1b82fc630ac847695edc928818. * Add 4 UI tests to check the Drawer Kit demo app is working (#22) - Open the drawer - Close the drawer - Slide to full screen - Tap close on fully open drawer * Run UI Tests as part of the CircleCI build (#25) * Experiment in running the UI tests as part of the circleci build * Fixed name in scheme * Change simulator being used to match local environment * Add scheme for demo with UI tests * Between a branch build and the merge the version available for the simulator seems to have changed. This updates the yml file to reflect this (#26) * New features (#27) * Update README.md (#23) * Fixed version number in Carthage section. * Renamed some properties and functions, for better clarity of intention. * More renaming along the same lines as the last commit. * Added support for tapping on the drawer to fully present it * More renaming. * Turned on debug mode in the demo app. * Make sure that quantities are always in their expected ranges. * Introduced an enumeration for drawer states * Removed extra blank line * Replaced the DrawerPresenting protocol with a new protocol, DrawerCoordinating, and made it so that objects other than view controllers can also coordinate the presentation of drawers. * Changed some configuration parameters in the demo app. * Tweaked the demo. * Added ChangeLog and updated ReadMe. * More changes to ReadMe. * Updated podspec. * More changes to the ChangeLog and ReadMe files. * Fixed guard indentation, as per comments. * Fixed guard indentations, as per comments. * DrawerKit 0.3.0 release (#35) * Added git ignore file * Added project workspace * Added tab bar template project * Added DrawerKit empty framework * Added basic view controllers and storyboards * Fixed broken outlets * Added implementation of DrawerKit. A few bits to complete still. * Hooked up the view controllers to the custom presentation. * Added clamping to the three possible resting positions of the drawer * Added more configuration to the presenting VC * Fixed a few glitches related to allowing partial expansion or not, and some refactoring. * Removed the two timing configurations and now using only one for all animations. * Added support for not having the gesture recognisers. * Fixed a potential division by zero. * Adding more configuration controls to presenting VC. WIP. * Added debug mode. * Added some TODOs * Renamed a function to make it clear it's a debugging feature. * Minor refactoring. * Renamed some source files for better clarity of intention. * Removed source headers. * Changed the presented VC to make a larger drawer (easier to play with). * Changed some parameters as per Sam's input. * Improved behaviour of corner rounding at the two edges of the screen. Still not a perfect solution because the animator's completion block is, surprisingly, not always called. Apparently, that's a bug in UIViewPropertyAnimator. * Made the logic for the drawer behaviour easier to read, because Sergey doesn't like `guard` with boolean statements. ;) * Moved some code closer to where it's actually used. * Minor formatting. * Added a fix to the corner-radius animation issue whereby the corner radius would not be set to zero because the property animator's completion would not always be called. Now we force it to zero on presentationTransitionDidEnd() (for the appropriate drawer ending positions). * Disabled automatic code signing. * The heights of the bands surrounding the resting position of the drawer are now given in absolute rather than relative terms. * Oopsie... committed a compiler error. Fixed now. * Added a scrollview to the presented view controller in the demo app, for testing how scrolling interacts with the drag gesture recogniser in the presentation controller. * Added an interaction controller, the first step in fixing the non-interactive presentation/dismissal itself. * Renamed TransitionAnimator to AnimationController. * Renamed a file to match the extension it's about. * Duh, it was supposed to be AnimationController, not AnimatorController. * Implemented interactive controller for the presentation and dismissal, and cleaned up the code for the animation controller (it doesn't need to know anything about the drawers). * Added license file and CocoaPods podspec. Not passing lint just yet. * Removed indirect access to configuration parameters. * Removed currently unused source file TransitionGeometry. * Fixed company name in the license file. * Cleared the team entry in the demo app. * Demo app: adding controls for all the configurable parameters. WIP. * Added control for manipulating cubic Bezier control points, CubicBezierView. * Added all the controls to the presenter VC. * Fixed a TODO comment. * Make sure that durationInSeconds is a positive value. * Removed all references to coversStatusBar since that hasn't been implemented yet. * Make sure that flickSpeedThreshold is a non-negative value. Also, if zero, disables support for flicking. * Make sure that upperMarkGap and lowerMarkGap are non-negative values. * Only add debugging mark lines if at least one of upperMarkGap and lowerMarkGap is a positive value. * Make sure that maximumCornerRadius is a non-negative value. * Only animate the corner radius if maximumCornerRadius is strictly positive. * Make sure that numberOfTapsForOutsideDrawerDismissal is a non-negative value. * Resolved an issue with animating rounding the presented view corners. * Simplified the demo app to its bare essentials. No more configuration controls to the wazoo. * Added based documentation to the library. * Preliminary version of README. WIP. * Removed unused assets. * Added some pseudo-code to the README, to explain the presentation/dismissal logic. * Code style change. * Removed unnecessary [weak self] capture lists. * Changed default value of durationInSeconds from 0.8 to 0.3 seconds. * Fixed a botched global search/replace in DrawerConfiguration+Equatable. * Renamed evil local gr variables to less evil names. * Fixed guard statements as per comments. * Removed a comment. * Removed a protocol extension. * Make sure that the height of the partially expanded drawer is non-negative. * Added documentation to all exposed public entities. * Style change as per comments. * Fixed documentation. * Updated README file. * Tweaked the README file. * Decreased the deployment target requirement, from 10.3 to 10.0. * Removed hidden extension in the LICENSE file. * Fixed source_files entry in the podspec. Removed the exclude_files entry. * Added a .swift-version file with the appropriate version of Swift to pod lib lint the pod. * Fixed the homepage in the podspec. * Fixed a bug when running under iOS 10 in which the initial presentation animation doesn't complete, therefore not invoking viewDidAppear, which causes the drawer not to show up at all. The work-around means that the initial presentation and dismissal aren't interactive but Product signed off on that decision. The drawers work fine under iOS 11. * Style change. * Killed the use of IUO references. * Changed author email address in the podspec. * Added support for Carthage. * [ci skip] Removed a commented out section from the README. Also, an excuse to turn CI off since DrawerKit fails it for lack of configuration for testing. * Added CircleCI config file. (#9) * Added CircleCI config file. * Changed circle.yml to "test" with the simulator, which disables testing * Let's try this one more time, shall we? * And again * Fixed circle.yml * And again * Fixed circle.yml * Fixed circle.yml. * Added CircleCI badge to README. * Simplified circle.yml build command. * Added dependency management commands to circle.yml * Fixed podspec source item. (#12) * Fixed podspec source item. * Missed the s in https. * DrawerKit release 0.0.1 (#13) (#14) * Added git ignore file * Added project workspace * Added tab bar template project * Added DrawerKit empty framework * Added basic view controllers and storyboards * Fixed broken outlets * Added implementation of DrawerKit. A few bits to complete still. * Hooked up the view controllers to the custom presentation. * Added clamping to the three possible resting positions of the drawer * Added more configuration to the presenting VC * Fixed a few glitches related to allowing partial expansion or not, and some refactoring. * Removed the two timing configurations and now using only one for all animations. * Added support for not having the gesture recognisers. * Fixed a potential division by zero. * Adding more configuration controls to presenting VC. WIP. * Added debug mode. * Added some TODOs * Renamed a function to make it clear it's a debugging feature. * Minor refactoring. * Renamed some source files for better clarity of intention. * Removed source headers. * Changed the presented VC to make a larger drawer (easier to play with). * Changed some parameters as per Sam's input. * Improved behaviour of corner rounding at the two edges of the screen. Still not a perfect solution because the animator's completion block is, surprisingly, not always called. Apparently, that's a bug in UIViewPropertyAnimator. * Made the logic for the drawer behaviour easier to read, because Sergey doesn't like `guard` with boolean statements. ;) * Moved some code closer to where it's actually used. * Minor formatting. * Added a fix to the corner-radius animation issue whereby the corner radius would not be set to zero because the property animator's completion would not always be called. Now we force it to zero on presentationTransitionDidEnd() (for the appropriate drawer ending positions). * Disabled automatic code signing. * The heights of the bands surrounding the resting position of the drawer are now given in absolute rather than relative terms. * Oopsie... committed a compiler error. Fixed now. * Added a scrollview to the presented view controller in the demo app, for testing how scrolling interacts with the drag gesture recogniser in the presentation controller. * Added an interaction controller, the first step in fixing the non-interactive presentation/dismissal itself. * Renamed TransitionAnimator to AnimationController. * Renamed a file to match the extension it's about. * Duh, it was supposed to be AnimationController, not AnimatorController. * Implemented interactive controller for the presentation and dismissal, and cleaned up the code for the animation controller (it doesn't need to know anything about the drawers). * Added license file and CocoaPods podspec. Not passing lint just yet. * Removed indirect access to configuration parameters. * Removed currently unused source file TransitionGeometry. * Fixed company name in the license file. * Cleared the team entry in the demo app. * Demo app: adding controls for all the configurable parameters. WIP. * Added control for manipulating cubic Bezier control points, CubicBezierView. * Added all the controls to the presenter VC. * Fixed a TODO comment. * Make sure that durationInSeconds is a positive value. * Removed all references to coversStatusBar since that hasn't been implemented yet. * Make sure that flickSpeedThreshold is a non-negative value. Also, if zero, disables support for flicking. * Make sure that upperMarkGap and lowerMarkGap are non-negative values. * Only add debugging mark lines if at least one of upperMarkGap and lowerMarkGap is a positive value. * Make sure that maximumCornerRadius is a non-negative value. * Only animate the corner radius if maximumCornerRadius is strictly positive. * Make sure that numberOfTapsForOutsideDrawerDismissal is a non-negative value. * Resolved an issue with animating rounding the presented view corners. * Simplified the demo app to its bare essentials. No more configuration controls to the wazoo. * Added based documentation to the library. * Preliminary version of README. WIP. * Removed unused assets. * Added some pseudo-code to the README, to explain the presentation/dismissal logic. * Code style change. * Removed unnecessary [weak self] capture lists. * Changed default value of durationInSeconds from 0.8 to 0.3 seconds. * Fixed a botched global search/replace in DrawerConfiguration+Equatable. * Renamed evil local gr variables to less evil names. * Fixed guard statements as per comments. * Removed a comment. * Removed a protocol extension. * Make sure that the height of the partially expanded drawer is non-negative. * Added documentation to all exposed public entities. * Style change as per comments. * Fixed documentation. * Updated README file. * Tweaked the README file. * Decreased the deployment target requirement, from 10.3 to 10.0. * Removed hidden extension in the LICENSE file. * Fixed source_files entry in the podspec. Removed the exclude_files entry. * Added a .swift-version file with the appropriate version of Swift to pod lib lint the pod. * Fixed the homepage in the podspec. * Fixed a bug when running under iOS 10 in which the initial presentation animation doesn't complete, therefore not invoking viewDidAppear, which causes the drawer not to show up at all. The work-around means that the initial presentation and dismissal aren't interactive but Product signed off on that decision. The drawers work fine under iOS 11. * Style change. * Killed the use of IUO references. * Changed author email address in the podspec. * Added support for Carthage. * [ci skip] Removed a commented out section from the README. Also, an excuse to turn CI off since DrawerKit fails it for lack of configuration for testing. * Added CircleCI config file. (#9) * Added CircleCI config file. * Changed circle.yml to "test" with the simulator, which disables testing * Let's try this one more time, shall we? * And again * Fixed circle.yml * And again * Fixed circle.yml * Fixed circle.yml. * Added CircleCI badge to README. * Simplified circle.yml build command. * Added dependency management commands to circle.yml * Fixed podspec source item. (#12) * Fixed podspec source item. * Missed the s in https. * Add gif and fixes the circle CI badge. (#17) * Adds a gif and fixes the circleci badge. * Moved the gif down a bit. * Removed extra space below the gif. * Changes version from 0.0.1 to 0.1. (#18) * Add missing link to Carthage (#15) * Fix to README (#21) * Changed version number from 0.0.1 to 0.1.1 in the dependency management sections of the README file. * Fix README as per David's suggestion. * Update podspec in preparation for release 0.1.2. * Revert "Update podspec in preparation for release 0.1.2." This reverts commit df1c07aa3ab36e1b82fc630ac847695edc928818. * Add 4 UI tests to check the Drawer Kit demo app is working (#22) - Open the drawer - Close the drawer - Slide to full screen - Tap close on fully open drawer * Run UI Tests as part of the CircleCI build (#25) * Experiment in running the UI tests as part of the circleci build * Fixed name in scheme * Change simulator being used to match local environment * Add scheme for demo with UI tests * Between a branch build and the merge the version available for the simulator seems to have changed. This updates the yml file to reflect this (#26) * New features (#27) * Update README.md (#23) * Fixed version number in Carthage section. * Renamed some properties and functions, for better clarity of intention. * More renaming along the same lines as the last commit. * Added support for tapping on the drawer to fully present it * More renaming. * Turned on debug mode in the demo app. * Make sure that quantities are always in their expected ranges. * Introduced an enumeration for drawer states * Removed extra blank line * Replaced the DrawerPresenting protocol with a new protocol, DrawerCoordinating, and made it so that objects other than view controllers can also coordinate the presentation of drawers. * Changed some configuration parameters in the demo app. * Tweaked the demo. * Added ChangeLog and updated ReadMe. * More changes to ReadMe. * Updated podspec. * More changes to the ChangeLog and ReadMe files. * Fixed guard indentation, as per comments. * Fixed guard indentations, as per comments. * New features and preparation for release 0.3.0 (#30) * Update README.md (#23) * Fixed version number in Carthage section. * Renamed some properties and functions, for better clarity of intention. * More renaming along the same lines as the last commit. * Added support for tapping on the drawer to fully present it * More renaming. * Turned on debug mode in the demo app. * Make sure that quantities are always in their expected ranges. * Introduced an enumeration for drawer states * Removed extra blank line * Replaced the DrawerPresenting protocol with a new protocol, DrawerCoordinating, and made it so that objects other than view controllers can also coordinate the presentation of drawers. * Changed some configuration parameters in the demo app. * Large refactoring work in preparation for adding concurrent animations. * WIP on concurrent animations * Replaced the suffix Signature with Handler in DrawerAnimationActions. * Added a number of TODO comments * Minor change, for clarity. * Changed some config params in the demo app. * Turns out it's ok to simply return false in these two comparisons. * Fixed code formatting. * Fixed a subtle bug whereby UIKit animations that ended at positions differing by as much as 0.5 points were considered to have ended at different points when they should have ended at the same position. * Fixed a bug whereby scaling animated in only one direction. * Added example animations from the collapsed state to the fully expanded state, and back. * Added support for automatically adding a handle view and automatically animating it. * Added support for not covering a portion of the screen when fully expanding the drawer. * Removed TODOs that have been handled already. * Small refactoring. * More refactoring. * Added previous gif. * Display the gifs at the same size. * Removed an extraneous comment. * Minor English corrections. * Renamed some properties to avoid abbreviations. Not all abbreviations could be removed, however, because Swift doesn't allow functions and properties to have the same name. * Merge master into dev (#32) * Update README.md (#23) * Release 0.2.0 (#28) * Added git ignore file * Added project workspace * Added tab bar template project * Added Drawe…
wltrup
added a commit
that referenced
this pull request
Nov 8, 2017
* Added git ignore file * Added project workspace * Added tab bar template project * Added DrawerKit empty framework * Added basic view controllers and storyboards * Fixed broken outlets * Added implementation of DrawerKit. A few bits to complete still. * Hooked up the view controllers to the custom presentation. * Added clamping to the three possible resting positions of the drawer * Added more configuration to the presenting VC * Fixed a few glitches related to allowing partial expansion or not, and some refactoring. * Removed the two timing configurations and now using only one for all animations. * Added support for not having the gesture recognisers. * Fixed a potential division by zero. * Adding more configuration controls to presenting VC. WIP. * Added debug mode. * Added some TODOs * Renamed a function to make it clear it's a debugging feature. * Minor refactoring. * Renamed some source files for better clarity of intention. * Removed source headers. * Changed the presented VC to make a larger drawer (easier to play with). * Changed some parameters as per Sam's input. * Improved behaviour of corner rounding at the two edges of the screen. Still not a perfect solution because the animator's completion block is, surprisingly, not always called. Apparently, that's a bug in UIViewPropertyAnimator. * Made the logic for the drawer behaviour easier to read, because Sergey doesn't like `guard` with boolean statements. ;) * Moved some code closer to where it's actually used. * Minor formatting. * Added a fix to the corner-radius animation issue whereby the corner radius would not be set to zero because the property animator's completion would not always be called. Now we force it to zero on presentationTransitionDidEnd() (for the appropriate drawer ending positions). * Disabled automatic code signing. * The heights of the bands surrounding the resting position of the drawer are now given in absolute rather than relative terms. * Oopsie... committed a compiler error. Fixed now. * Added a scrollview to the presented view controller in the demo app, for testing how scrolling interacts with the drag gesture recogniser in the presentation controller. * Added an interaction controller, the first step in fixing the non-interactive presentation/dismissal itself. * Renamed TransitionAnimator to AnimationController. * Renamed a file to match the extension it's about. * Duh, it was supposed to be AnimationController, not AnimatorController. * Implemented interactive controller for the presentation and dismissal, and cleaned up the code for the animation controller (it doesn't need to know anything about the drawers). * Added license file and CocoaPods podspec. Not passing lint just yet. * Removed indirect access to configuration parameters. * Removed currently unused source file TransitionGeometry. * Fixed company name in the license file. * Cleared the team entry in the demo app. * Demo app: adding controls for all the configurable parameters. WIP. * Added control for manipulating cubic Bezier control points, CubicBezierView. * Added all the controls to the presenter VC. * Fixed a TODO comment. * Make sure that durationInSeconds is a positive value. * Removed all references to coversStatusBar since that hasn't been implemented yet. * Make sure that flickSpeedThreshold is a non-negative value. Also, if zero, disables support for flicking. * Make sure that upperMarkGap and lowerMarkGap are non-negative values. * Only add debugging mark lines if at least one of upperMarkGap and lowerMarkGap is a positive value. * Make sure that maximumCornerRadius is a non-negative value. * Only animate the corner radius if maximumCornerRadius is strictly positive. * Make sure that numberOfTapsForOutsideDrawerDismissal is a non-negative value. * Resolved an issue with animating rounding the presented view corners. * Simplified the demo app to its bare essentials. No more configuration controls to the wazoo. * Added based documentation to the library. * Preliminary version of README. WIP. * Removed unused assets. * Added some pseudo-code to the README, to explain the presentation/dismissal logic. * Code style change. * Removed unnecessary [weak self] capture lists. * Changed default value of durationInSeconds from 0.8 to 0.3 seconds. * Fixed a botched global search/replace in DrawerConfiguration+Equatable. * Renamed evil local gr variables to less evil names. * Fixed guard statements as per comments. * Removed a comment. * Removed a protocol extension. * Make sure that the height of the partially expanded drawer is non-negative. * Added documentation to all exposed public entities. * Style change as per comments. * Fixed documentation. * Updated README file. * Tweaked the README file. * Decreased the deployment target requirement, from 10.3 to 10.0. * Removed hidden extension in the LICENSE file. * Fixed source_files entry in the podspec. Removed the exclude_files entry. * Added a .swift-version file with the appropriate version of Swift to pod lib lint the pod. * Fixed the homepage in the podspec. * Fixed a bug when running under iOS 10 in which the initial presentation animation doesn't complete, therefore not invoking viewDidAppear, which causes the drawer not to show up at all. The work-around means that the initial presentation and dismissal aren't interactive but Product signed off on that decision. The drawers work fine under iOS 11. * Style change. * Killed the use of IUO references. * Changed author email address in the podspec. * Added support for Carthage. * [ci skip] Removed a commented out section from the README. Also, an excuse to turn CI off since DrawerKit fails it for lack of configuration for testing. * Added CircleCI config file. (#9) * Added CircleCI config file. * Changed circle.yml to "test" with the simulator, which disables testing * Let's try this one more time, shall we? * And again * Fixed circle.yml * And again * Fixed circle.yml * Fixed circle.yml. * Added CircleCI badge to README. * Simplified circle.yml build command. * Added dependency management commands to circle.yml * Fixed podspec source item. (#12) * Fixed podspec source item. * Missed the s in https. * DrawerKit release 0.0.1 (#13) (#14) * Added git ignore file * Added project workspace * Added tab bar template project * Added DrawerKit empty framework * Added basic view controllers and storyboards * Fixed broken outlets * Added implementation of DrawerKit. A few bits to complete still. * Hooked up the view controllers to the custom presentation. * Added clamping to the three possible resting positions of the drawer * Added more configuration to the presenting VC * Fixed a few glitches related to allowing partial expansion or not, and some refactoring. * Removed the two timing configurations and now using only one for all animations. * Added support for not having the gesture recognisers. * Fixed a potential division by zero. * Adding more configuration controls to presenting VC. WIP. * Added debug mode. * Added some TODOs * Renamed a function to make it clear it's a debugging feature. * Minor refactoring. * Renamed some source files for better clarity of intention. * Removed source headers. * Changed the presented VC to make a larger drawer (easier to play with). * Changed some parameters as per Sam's input. * Improved behaviour of corner rounding at the two edges of the screen. Still not a perfect solution because the animator's completion block is, surprisingly, not always called. Apparently, that's a bug in UIViewPropertyAnimator. * Made the logic for the drawer behaviour easier to read, because Sergey doesn't like `guard` with boolean statements. ;) * Moved some code closer to where it's actually used. * Minor formatting. * Added a fix to the corner-radius animation issue whereby the corner radius would not be set to zero because the property animator's completion would not always be called. Now we force it to zero on presentationTransitionDidEnd() (for the appropriate drawer ending positions). * Disabled automatic code signing. * The heights of the bands surrounding the resting position of the drawer are now given in absolute rather than relative terms. * Oopsie... committed a compiler error. Fixed now. * Added a scrollview to the presented view controller in the demo app, for testing how scrolling interacts with the drag gesture recogniser in the presentation controller. * Added an interaction controller, the first step in fixing the non-interactive presentation/dismissal itself. * Renamed TransitionAnimator to AnimationController. * Renamed a file to match the extension it's about. * Duh, it was supposed to be AnimationController, not AnimatorController. * Implemented interactive controller for the presentation and dismissal, and cleaned up the code for the animation controller (it doesn't need to know anything about the drawers). * Added license file and CocoaPods podspec. Not passing lint just yet. * Removed indirect access to configuration parameters. * Removed currently unused source file TransitionGeometry. * Fixed company name in the license file. * Cleared the team entry in the demo app. * Demo app: adding controls for all the configurable parameters. WIP. * Added control for manipulating cubic Bezier control points, CubicBezierView. * Added all the controls to the presenter VC. * Fixed a TODO comment. * Make sure that durationInSeconds is a positive value. * Removed all references to coversStatusBar since that hasn't been implemented yet. * Make sure that flickSpeedThreshold is a non-negative value. Also, if zero, disables support for flicking. * Make sure that upperMarkGap and lowerMarkGap are non-negative values. * Only add debugging mark lines if at least one of upperMarkGap and lowerMarkGap is a positive value. * Make sure that maximumCornerRadius is a non-negative value. * Only animate the corner radius if maximumCornerRadius is strictly positive. * Make sure that numberOfTapsForOutsideDrawerDismissal is a non-negative value. * Resolved an issue with animating rounding the presented view corners. * Simplified the demo app to its bare essentials. No more configuration controls to the wazoo. * Added based documentation to the library. * Preliminary version of README. WIP. * Removed unused assets. * Added some pseudo-code to the README, to explain the presentation/dismissal logic. * Code style change. * Removed unnecessary [weak self] capture lists. * Changed default value of durationInSeconds from 0.8 to 0.3 seconds. * Fixed a botched global search/replace in DrawerConfiguration+Equatable. * Renamed evil local gr variables to less evil names. * Fixed guard statements as per comments. * Removed a comment. * Removed a protocol extension. * Make sure that the height of the partially expanded drawer is non-negative. * Added documentation to all exposed public entities. * Style change as per comments. * Fixed documentation. * Updated README file. * Tweaked the README file. * Decreased the deployment target requirement, from 10.3 to 10.0. * Removed hidden extension in the LICENSE file. * Fixed source_files entry in the podspec. Removed the exclude_files entry. * Added a .swift-version file with the appropriate version of Swift to pod lib lint the pod. * Fixed the homepage in the podspec. * Fixed a bug when running under iOS 10 in which the initial presentation animation doesn't complete, therefore not invoking viewDidAppear, which causes the drawer not to show up at all. The work-around means that the initial presentation and dismissal aren't interactive but Product signed off on that decision. The drawers work fine under iOS 11. * Style change. * Killed the use of IUO references. * Changed author email address in the podspec. * Added support for Carthage. * [ci skip] Removed a commented out section from the README. Also, an excuse to turn CI off since DrawerKit fails it for lack of configuration for testing. * Added CircleCI config file. (#9) * Added CircleCI config file. * Changed circle.yml to "test" with the simulator, which disables testing * Let's try this one more time, shall we? * And again * Fixed circle.yml * And again * Fixed circle.yml * Fixed circle.yml. * Added CircleCI badge to README. * Simplified circle.yml build command. * Added dependency management commands to circle.yml * Fixed podspec source item. (#12) * Fixed podspec source item. * Missed the s in https. * Add gif and fixes the circle CI badge. (#17) * Adds a gif and fixes the circleci badge. * Moved the gif down a bit. * Removed extra space below the gif. * Changes version from 0.0.1 to 0.1. (#18) * Add missing link to Carthage (#15) * Fix to README (#21) * Changed version number from 0.0.1 to 0.1.1 in the dependency management sections of the README file. * Fix README as per David's suggestion. * Update podspec in preparation for release 0.1.2. * Revert "Update podspec in preparation for release 0.1.2." This reverts commit df1c07aa3ab36e1b82fc630ac847695edc928818. * Add 4 UI tests to check the Drawer Kit demo app is working (#22) - Open the drawer - Close the drawer - Slide to full screen - Tap close on fully open drawer * Run UI Tests as part of the CircleCI build (#25) * Experiment in running the UI tests as part of the circleci build * Fixed name in scheme * Change simulator being used to match local environment * Add scheme for demo with UI tests * Between a branch build and the merge the version available for the simulator seems to have changed. This updates the yml file to reflect this (#26) * New features (#27) * Update README.md (#23) * Fixed version number in Carthage section. * Renamed some properties and functions, for better clarity of intention. * More renaming along the same lines as the last commit. * Added support for tapping on the drawer to fully present it * More renaming. * Turned on debug mode in the demo app. * Make sure that quantities are always in their expected ranges. * Introduced an enumeration for drawer states * Removed extra blank line * Replaced the DrawerPresenting protocol with a new protocol, DrawerCoordinating, and made it so that objects other than view controllers can also coordinate the presentation of drawers. * Changed some configuration parameters in the demo app. * Tweaked the demo. * Added ChangeLog and updated ReadMe. * More changes to ReadMe. * Updated podspec. * More changes to the ChangeLog and ReadMe files. * Fixed guard indentation, as per comments. * Fixed guard indentations, as per comments. * New features and preparation for release 0.3.0 (#30) * Update README.md (#23) * Fixed version number in Carthage section. * Renamed some properties and functions, for better clarity of intention. * More renaming along the same lines as the last commit. * Added support for tapping on the drawer to fully present it * More renaming. * Turned on debug mode in the demo app. * Make sure that quantities are always in their expected ranges. * Introduced an enumeration for drawer states * Removed extra blank line * Replaced the DrawerPresenting protocol with a new protocol, DrawerCoordinating, and made it so that objects other than view controllers can also coordinate the presentation of drawers. * Changed some configuration parameters in the demo app. * Large refactoring work in preparation for adding concurrent animations. * WIP on concurrent animations * Replaced the suffix Signature with Handler in DrawerAnimationActions. * Added a number of TODO comments * Minor change, for clarity. * Changed some config params in the demo app. * Turns out it's ok to simply return false in these two comparisons. * Fixed code formatting. * Fixed a subtle bug whereby UIKit animations that ended at positions differing by as much as 0.5 points were considered to have ended at different points when they should have ended at the same position. * Fixed a bug whereby scaling animated in only one direction. * Added example animations from the collapsed state to the fully expanded state, and back. * Added support for automatically adding a handle view and automatically animating it. * Added support for not covering a portion of the screen when fully expanding the drawer. * Removed TODOs that have been handled already. * Small refactoring. * More refactoring. * Added previous gif. * Display the gifs at the same size. * Removed an extraneous comment. * Minor English corrections. * Renamed some properties to avoid abbreviations. Not all abbreviations could be removed, however, because Swift doesn't allow functions and properties to have the same name. * Merge master into dev (#32) * Update README.md (#23) * Release 0.2.0 (#28) * Added git ignore file * Added project workspace * Added tab bar template project * Added DrawerKit empty framework * Added basic view controllers and storyboards * Fixed broken outlets * Added implementation of DrawerKit. A few bits to complete still. * Hooked up the view controllers to the custom presentation. * Added clamping to the three possible resting positions of the drawer * Added more configuration to the presenting VC * Fixed a few glitches related to allowing partial expansion or not, and some refactoring. * Removed the two timing configurations and now using only one for all animations. * Added support for not having the gesture recognisers. * Fixed a potential division by zero. * Adding more configuration controls to presenting VC. WIP. * Added debug mode. * Added some TODOs * Renamed a function to make it clear it's a debugging feature. * Minor refactoring. * Renamed some source files for better clarity of intention. * Removed source headers. * Changed the presented VC to make a larger drawer (easier to play with). * Changed some parameters as per Sam's input. * Improved behaviour of corner rounding at the two edges of the screen. Still not a perfect solution because the animator's completion block is, surprisingly, not always called. Apparently, that's a bug in UIViewPropertyAnimator. * Made the logic for the drawer behaviour easier to read, because Sergey doesn't like `guard` with boolean statements. ;) * Moved some code closer to where it's actually used. * Minor formatting. * Added a fix to the corner-radius animation issue whereby the corner radius would not be set to zero because the property animator's completion would not always be called. Now we force it to zero on presentationTransitionDidEnd() (for the appropriate drawer ending positions). * Disabled automatic code signing. * The heights of the bands surrounding the resting position of the drawer are now given in absolute rather than relative terms. * Oopsie... committed a compiler error. Fixed now. * Added a scrollview to the presented view controller in the demo app, for testing how scrolling interacts with the drag gesture recogniser in the presentation controller. * Added an interaction controller, the first step in fixing the non-interactive presentation/dismissal itself. * Renamed TransitionAnimator to AnimationController. * Renamed a file to match the extension it's about. * Duh, it was supposed to be AnimationController, not AnimatorController. * Implemented interactive controller for the presentation and dismissal, and cleaned up the code for the animation controller (it doesn't need to know anything about the drawers). * Added license file and CocoaPods podspec. Not passing lint just yet. * Removed indirect access to configuration parameters. * Removed currently unused source file TransitionGeometry. * Fixed company name in the license file. * Cleared the team entry in the demo app. * Demo app: adding controls for all the configurable parameters. WIP. * Added control for manipulating cubic Bezier control points, CubicBezierView. * Added all the controls to the presenter VC. * Fixed a TODO comment. * Make sure that durationInSeconds is a positive value. * Removed all references to coversStatusBar since that hasn't been implemented yet. * Make sure that flickSpeedThreshold is a non-negative value. Also, if zero, disables support for flicking. * Make sure that upperMarkGap and lowerMarkGap are non-negative values. * Only add debugging mark lines if at least one of upperMarkGap and lowerMarkGap is a positive value. * Make sure that maximumCornerRadius is a non-negative value. * Only animate the corner radius if maximumCornerRadius is strictly positive. * Make sure that numberOfTapsForOutsideDrawerDismissal is a non-negative value. * Resolved an issue with animating rounding the presented view corners. * Simplified the demo app to its bare essentials. No more configuration controls to the wazoo. * Added based documentation to the library. * Preliminary version of README. WIP. * Removed unused assets. * Added some pseudo-code to the README, to explain the presentation/dismissal logic. * Code style change. * Removed unnecessary [weak self] capture lists. * Changed default value of durationInSeconds from 0.8 to 0.3 seconds. * Fixed a botched global search/replace in DrawerConfiguration+Equatable. * Renamed evil local gr variables to less evil names. * Fixed guard statements as per comments. * Removed a comment. * Removed a protocol extension. * Make sure that the height of the partially expanded drawer is non-negative. * Added documentation to all exposed public entities. * Style change as per comments. * Fixed documentation. * Updated README file. * Tweaked the README file. * Decreased the deployment target requirement, from 10.3 to 10.0. * Removed hidden extension in the LICENSE file. * Fixed source_files entry in the podspec. Removed the exclude_files entry. * Added a .swift-version file with the appropriate version of Swift to pod lib lint the pod. * Fixed the homepage in the podspec. * Fixed a bug when running under iOS 10 in which the initial presentation animation doesn't complete, therefore not invoking viewDidAppear, which causes the drawer not to show up at all. The work-around means that the initial presentation and dismissal aren't interactive but Product signed off on that decision. The drawers work fine under iOS 11. * Style change. * Killed the use of IUO references. * Changed author email address in the podspec. * Added support for Carthage. * [ci skip] Removed a commented out section from the README. Also, an excuse to turn CI off since DrawerKit fails it for lack of configuration for testing. * Added CircleCI config file. (#9) * Added CircleCI config file. * Changed circle.yml to "test" with the simulator, which disables testing * Let's try this one more time, shall we? * And again * Fixed circle.yml * And again * Fixed circle.yml * Fixed circle.yml. * Added CircleCI badge to README. * Simplified circle.yml build command. * Added dependency management commands to circle.yml * Fixed podspec source item. (#12) * Fixed podspec source item. * Missed the s in https. * DrawerKit release 0.0.1 (#13) (#14) * Added git ignore file * Added project workspace * Added tab bar template project * Added DrawerKit empty framework * Added basic view controllers and storyboards * Fixed broken outlets * Added implementation of DrawerKit. A few bits to complete still. * Hooked up the view controllers to the custom presentation. * Added clamping to the three possible resting positions of the drawer * Added more configuration to the presenting VC * Fixed a few glitches related to allowing partial expansion or not, and some refactoring. * Removed the two timing configurations and now using only one for all animations. * Added support for not having the gesture recognisers. * Fixed a potential division by zero. * Adding more configuration controls to presenting VC. WIP. * Added debug mode. * Added some TODOs * Renamed a function to make it clear it's a debugging feature. * Minor refactoring. * Renamed some source files for better clarity of intention. * Removed source headers. * Changed the presented VC to make a larger drawer (easier to play with). * Changed some parameters as per Sam's input. * Improved behaviour of corner rounding at the two edges of the screen. Still not a perfect solution because the animator's completion block is, surprisingly, not always called. Apparently, that's a bug in UIViewPropertyAnimator. * Made the logic for the drawer behaviour easier to read, because Sergey doesn't like `guard` with boolean statements. ;) * Moved some code closer to where it's actually used. * Minor formatting. * Added a fix to the corner-radius animation issue whereby the corner radius would not be set to zero because the property animator's completion would not always be called. Now we force it to zero on presentationTransitionDidEnd() (for the appropriate drawer ending positions). * Disabled automatic code signing. * The heights of the bands surrounding the resting position of the drawer are now given in absolute rather than relative terms. * Oopsie... committed a compiler error. Fixed now. * Added a scrollview to the presented view controller in the demo app, for testing how scrolling interacts with the drag gesture recogniser in the presentation controller. * Added an interaction controller, the first step in fixing the non-interactive presentation/dismissal itself. * Renamed TransitionAnimator to AnimationController. * Renamed a file to match the extension it's about. * Duh, it was supposed to be AnimationController, not AnimatorController. * Implemented interactive controller for the presentation and dismissal, and cleaned up the code for the animation controller (it doesn't need to know anything about the drawers). * Added license file and CocoaPods podspec. Not passing lint just yet. * Removed indirect access to configuration parameters. * Removed currently unused source file TransitionGeometry. * Fixed company name in the license file. * Cleared the team entry in the demo app. * Demo app: adding controls for all the configurable parameters. WIP. * Added control for manipulating cubic Bezier control points, CubicBezierView. * Added all the controls to the presenter VC. * Fixed a TODO comment. * Make sure that durationInSeconds is a positive value. * Removed all references to coversStatusBar since that hasn't been implemented yet. * Make sure that flickSpeedThreshold is a non-negative value. Also, if zero, disables support for flicking. * Make sure that upperMarkGap and lowerMarkGap are non-negative values. * Only add debugging mark lines if at least one of upperMarkGap and lowerMarkGap is a positive value. * Make sure that maximumCornerRadius is a non-negative value. * Only animate the corner radius if maximumCornerRadius is strictly positive. * Make sure that numberOfTapsForOutsideDrawerDismissal is a non-negative value. * Resolved an issue with animating rounding the presented view corners. * Simplified the demo app to its bare essentials. No more configuration controls to the wazoo. * Added based documentation to the library. * Preliminary version of README. WIP. * Removed unused assets. * Added some pseudo-code to the README, to explain the presentation/dismissal logic. * Code style change. * Removed unnecessary [weak self] capture lists. * Changed default value of durationInSeconds from 0.8 to 0.3 seconds. * Fixed a botched global search/replace in DrawerConfiguration+Equatable. * Renamed evil local gr variables to less evil names. * Fixed guard statements as per comments. * Removed a comment. * Removed a protocol extension. * Make sure that the height of the partially expanded drawer is non-negative. * Added documentation to all exposed public entities. * Style change as per comments. * Fixed documentation. * Updated README file. * Tweaked the README file. * Decreased the deployment target requirement, from 10.3 to 10.0. * Removed hidden extension in the LICENSE file. * Fixed source_files entry in the podspec. Removed the exclude_files entry. * Added a .swift-version file with the appropriate version of Swift to pod lib lint the pod. * Fixed the homepage in the podspec. * Fixed a bug when running under iOS 10 in which the initial presentation animation doesn't complete, therefore not invoking viewDidAppear, which causes the drawer not to show up at all. The work-around means that the initial presentation and dismissal aren't interactive but Product signed off on that decision. The drawers work fine under iOS 11. * Style change. * Killed the use of IUO references. * Changed author email address in the podspec. * Added support for Carthage. * [ci skip] Removed a commented out section from the README. Also, an excuse to turn CI off since DrawerKit fails it for lack of configuration for testing. * Added CircleCI config file. (#9) * Added CircleCI config file. * Changed circle.yml to "test" with the simulator, which disables testing * Let's try this one more time, shall we? * And again * Fixed circle.yml * And again * Fixed circle.yml * Fixed circle.yml. * Added CircleCI badge to README. * Simplified circle.yml build command. * Added dependency management commands to circle.yml * Fixed podspec source item. (#12) * Fixed podspec source item. * Missed the s in https. * Add gif and fixes the circle CI badge. (#17) * Adds a gif and fixes the circleci badge. * Moved the gif down a bit. * Removed extra space below the gif. * Changes version from 0.0.1 to 0.1. (#18) * Add missing link to Carthage (#15) * Fix to README (#21) * Changed version number from 0.0.1 to 0.1.1 in the dependency management sections of the README file. * Fix README as per David's suggestion. * Update podspec in preparation for release 0.1.2. * Revert "Update podspec in preparation for release 0.1.2." This reverts commit df1c07aa3ab36e1b82fc630ac847695edc928818. * Add 4 UI tests to check the Drawer Kit demo app is working (#22) - Open the drawer - Close the drawer - Slide to full screen - Tap close on fully open drawer * Run UI Tests as part of the CircleCI build (#25) * Experiment in running the UI tests as part of the circleci build * Fixed name in scheme * Change simulator being used to match local environment * Add scheme for demo with UI tests * Between a branch build and the merge the version available for the simulator seems to have changed. This updates the yml file to reflect this (#26) * New features (#27) * Update README.md (#23) * Fixed version number in Carthage section. * Renamed some properties and functions, for better clarity of intention. * More renaming along the same lines as the last commit. * Added support for tapping on the drawer to fully present it * More renaming. * Turned on debug mode in the demo app. * Make sure that quantities are always in their expected ranges. * Introduced an enumeration for drawer states * Removed extra blank line * Replaced the DrawerPresenting protocol with a new protocol, DrawerCoordinating, and made it so that objects other than view controllers can also coordinate the presentation of drawers. * Changed some configuration parameters in the demo app. * Tweaked the demo. * Added ChangeLog and updated ReadMe. * More changes to ReadMe. * Updated podspec. * More changes to the ChangeLog and ReadMe files. * Fixed guard indentation, as per comments. * Fixed guard indentations, as per comments. * New features and prep for release 0.3.1 (#36) * Update README.md (#23) * Release 0.2.0 (#28) * Added git ignore file * Added project workspace * Added tab bar template project * Added DrawerKit empty framework * Added basic view controllers and storyboards * Fixed broken outlets * Added implementation of DrawerKit. A few bits to complete still. * Hooked up the view controllers to the custom presentation. * Added clamping to the three possible resting positions of the drawer * Added more configuration to the presenting VC * Fixed a few glitches related to allowing partial expansion or not, and some refactoring. * Removed the two timing configurations and now using only one for all animations. * Added support for not having the gesture recognisers. * Fixed a potential division by zero. * Adding more configuration controls to presenting VC. WIP. * Added debug mode. * Added some TODOs * Renamed a function to make it clear it's a debugging feature. * Minor refactoring. * Renamed some source files for better clarity of intention. * Removed source headers. * Changed the presented VC to make a larger drawer (easier to play with). * Changed some parameters as per Sam's input. * Improved behaviour of corner rounding at the two edges of the screen. Still not a perfect solution because the animator's completion block is, surprisingly, not always called. Apparently, that's a bug in UIViewPropertyAnimator. * Made the logic for the drawer behaviour easier to read, because Sergey doesn't like `guard` with boolean statements. ;) * Moved some code closer to where it's actually used. * Minor formatting. * Added a fix to the corner-radius animation issue whereby the corner radius would not be set to zero because the property animator's completion would not always be called. Now we force it to zero on presentationTransitionDidEnd() (for the appropriate drawer ending positions). * Disabled automatic code signing. * The heights of the bands surrounding the resting position of the drawer are now given in absolute rather than relative terms. * Oopsie... committed a compiler error. Fixed now. * Added a scrollview to the presented view controller in the demo app, for testing how scrolling interacts with the drag gesture recogniser in the presentation controller. * Added an interaction controller, the first step in fixing the non-interactive presentation/dismissal itself. * Renamed TransitionAnimator to AnimationController. * Renamed a file to match the extension it's about. * Duh, it was supposed to be AnimationController, not AnimatorController. * Implemented interactive controller for the presentation and dismissal, and cleaned up the code for the animation controller (it doesn't need to know anything about the drawers). * Added license file and CocoaPods podspec. Not passing lint just yet. * Removed indirect access to configuration parameters. * Removed currently unused source file TransitionGeometry. * Fixed company name in the license file. * Cleared the team entry in the demo app. * Demo app: adding controls for all the configurable parameters. WIP. * Added control for manipulating cubic Bezier control points, CubicBezierView. * Added all the controls to the presenter VC. * Fixed a TODO comment. * Make sure that durationInSeconds is a positive value. * Removed all references to coversStatusBar since that hasn't been implemented yet. * Make sure that flickSpeedThreshold is a non-negative value. Also, if zero, disables support for flicking. * Make sure that upperMarkGap and lowerMarkGap are non-negative values. * Only add debugging mark lines if at least one of upperMarkGap and lowerMarkGap is a positive value. * Make sure that maximumCornerRadius is a non-negative value. * Only animate the corner radius if maximumCornerRadius is strictly positive. * Make sure that numberOfTapsForOutsideDrawerDismissal is a non-negative value. * Resolved an issue with animating rounding the presented view corners. * Simplified the demo app to its bare essentials. No more configuration controls to the wazoo. * Added based documentation to the library. * Preliminary version of README. WIP. * Removed unused assets. * Added some pseudo-code to the README, to explain the presentation/dismissal logic. * Code style change. * Removed unnecessary [weak self] capture lists. * Changed default value of durationInSeconds from 0.8 to 0.3 seconds. * Fixed a botched global search/replace in DrawerConfiguration+Equatable. * Renamed evil local gr variables to less evil names. * Fixed guard statements as per comments. * Removed a comment. * Removed a protocol extension. * Make sure that the height of the partially expanded drawer is non-negative. * Added documentation to all exposed public entities. * Style change as per comments. * Fixed documentation. * Updated README file. * Tweaked the README file. * Decreased the deployment target requirement, from 10.3 to 10.0. * Removed hidden extension in the LICENSE file. * Fixed source_files entry in the podspec. Removed the exclude_files entry. * Added a .swift-version file with the appropriate version of Swift to pod lib lint the pod. * Fixed the homepage in the podspec. * Fixed a bug when running under iOS 10 in which the initial presentation animation doesn't complete, therefore not invoking viewDidAppear, which causes the drawer not to show up at all. The work-around means that the initial presentation and dismissal aren't interactive but Product signed off on that decision. The drawers work fine under iOS 11. * Style change. * Killed the use of IUO references. * Changed author email address in the podspec. * Added support for Carthage. * [ci skip] Removed a commented out section from the README. Also, an excuse to turn CI off since DrawerKit fails it for lack of configuration for testing. * Added CircleCI config file. (#9) * Added CircleCI config file. * Changed circle.yml to "test" with the simulator, which disables testing * Let's try this one more time, shall we? * And again * Fixed circle.yml * And again * Fixed circle.yml * Fixed circle.yml. * Added CircleCI badge to README. * Simplified circle.yml build command. * Added dependency management commands to circle.yml * Fixed podspec source item. (#12) * Fixed podspec source item. * Missed the s in https. * DrawerKit release 0.0.1 (#13) (#14) * Added git ignore file * Added project workspace * Added tab bar template project * Added DrawerKit empty framework * Added basic view controllers and storyboards * Fixed broken outlets * Added implementation of DrawerKit. A few bits to complete still. * Hooked up the view controllers to the custom presentation. * Added clamping to the three possible resting positions of the drawer * Added more configuration to the presenting VC * Fixed a few glitches related to allowing partial expansion or not, and some refactoring. * Removed the two timing configurations and now using only one for all animations. * Added support for not having the gesture recognisers. * Fixed a potential division by zero. * Adding more configuration controls to presenting VC. WIP. * Added debug mode. * Added some TODOs * Renamed a function to make it clear it's a debugging feature. * Minor refactoring. * Renamed some source files for better clarity of intention. * Removed source headers. * Changed the presented VC to make a larger drawer (easier to play with). * Changed some parameters as per Sam's input. * Improved behaviour of corner rounding at the two edges of the screen. Still not a perfect solution because the animator's completion block is, surprisingly, not always called. Apparently, that's a bug in UIViewPropertyAnimator. * Made the logic for the drawer behaviour easier to read, because Sergey doesn't like `guard` with boolean statements. ;) * Moved some code closer to where it's actually used. * Minor formatting. * Added a fix to the corner-radius animation issue whereby the corner radius would not be set to zero because the property animator's completion would not always be called. Now we force it to zero on presentationTransitionDidEnd() (for the appropriate drawer ending positions). * Disabled automatic code signing. * The heights of the bands surrounding the resting position of the drawer are now given in absolute rather than relative terms. * Oopsie... committed a compiler error. Fixed now. * Added a scrollview to the presented view controller in the demo app, for testing how scrolling interacts with the drag gesture recogniser in the presentation controller. * Added an interaction controller, the first step in fixing the non-interactive presentation/dismissal itself. * Renamed TransitionAnimator to AnimationController. * Renamed a file to match the extension it's about. * Duh, it was supposed to be AnimationController, not AnimatorController. * Implemented interactive controller for the presentation and dismissal, and cleaned up the code for the animation controller (it doesn't need to know anything about the drawers). * Added license file and CocoaPods podspec. Not passing lint just yet. * Removed indirect access to configuration parameters. * Removed currently unused source file TransitionGeometry. * Fixed company name in the license file. * Cleared the team entry in the demo app. * Demo app: adding controls for all the configurable parameters. WIP. * Added control for manipulating cubic Bezier control points, CubicBezierView. * Added all the controls to the presenter VC. * Fixed a TODO comment. * Make sure that durationInSeconds is a positive value. * Removed all references to coversStatusBar since that hasn't been implemented yet. * Make sure that flickSpeedThreshold is a non-negative value. Also, if zero, disables support for flicking. * Make sure that upperMarkGap and lowerMarkGap are non-negative values. * Only add debugging mark lines if at least one of upperMarkGap and lowerMarkGap is a positive value. * Make sure that maximumCornerRadius is a non-negative value. * Only animate the corner radius if maximumCornerRadius is strictly positive. * Make sure that numberOfTapsForOutsideDrawerDismissal is a non-negative value. * Resolved an issue with animating rounding the presented view corners. * Simplified the demo app to its bare essentials. No more configuration controls to the wazoo. * Added based documentation to the library. * Preliminary version of README. WIP. * Removed unused assets. * Added some pseudo-code to the README, to explain the presentation/dismissal logic. * Code style change. * Removed unnecessary [weak self] capture lists. * Changed default value of durationInSeconds from 0.8 to 0.3 seconds. * Fixed a botched global search/replace in DrawerConfiguration+Equatable. * Renamed evil local gr variables to less evil names. * Fixed guard statements as per comments. * Removed a comment. * Removed a protocol extension. * Make sure that the height of the partially expanded drawer is non-negative. * Added documentation to all exposed public entities. * Style change as per comments. * Fixed documentation. * Updated README file. * Tweaked the README file. * Decreased the deployment target requirement, from 10.3 to 10.0. * Removed hidden extension in the LICENSE file. * Fixed source_files entry in the podspec. Removed the exclude_files entry. * Added a .swift-version file with the appropriate version of Swift to pod lib lint the pod. * Fixed the homepage in the podspec. * Fixed a bug when running under iOS 10 in which the initial presentation animation doesn't complete, therefore not invoking viewDidAppear, which causes the drawer not to show up at all. The work-around means that the initial presentation and dismissal aren't interactive but Product signed off on that decision. The drawers work fine under iOS 11. * Style change. * Killed the use of IUO references. * Changed author email address in the podspec. * Added support for Carthage. * [ci skip] Removed a commented out section from the README. Also, an excuse to turn CI off since DrawerKit fails it for lack of configuration for testing. * Added CircleCI config file. (#9) * Added CircleCI config file. * Changed circle.yml to "test" with the simulator, which disables testing * Let's try this one more time, shall we? * And again * Fixed circle.yml * And again * Fixed circle.yml * Fixed circle.yml. * Added CircleCI badge to README. * Simplified circle.yml build command. * Added dependency management commands to circle.yml * Fixed podspec source item. (#12) * Fixed podspec source item. * Missed the s in https. * Add gif and fixes the circle CI badge. (#17) * Adds a gif and fixes the circleci badge. * Moved the gif down a bit. * Removed extra space below the gif. * Changes version from 0.0.1 to 0.1. (#18) * Add missing link to Carthage (#15) * Fix to README (#21) * Changed version number from 0.0.1 to 0.1.1 in the dependency management sections of the README file. * Fix README as per David's suggestion. * Update podspec in preparation for release 0.1.2. * Revert "Update podspec in preparation for release 0.1.2." This reverts commit df1c07aa3ab36e1b82fc630ac847695edc928818. * Add 4 UI tests to check the Drawer Kit demo app is working (#22) - Open the drawer - Close the drawer - Slide to full screen - Tap close on fully open drawer * Run UI Tests as part of the CircleCI build (#25) * Experiment in running the UI tests as part of the circleci build * Fixed name in scheme * Change simulator being used to match local environment * Add scheme for demo with UI tests * Between a branch build and the merge the version available for the simulator seems to have changed. This updates the yml file to reflect this (#26) * New features (#27) * Update README.md (#23) * Fixed version number in Carthage section. * Renamed some properties and functions, for better clarity of intention. * More renaming along the same lines as the last commit. * Added support for tapping on the drawer to fully present it * More renaming. * Turned on debug mode in the demo app. * Make sure that quantities are always in their expected ranges. * Introduced an enumeration for drawer states * Removed extra blank line * Replaced the DrawerPresenting protocol with a new protocol, DrawerCoordinating, and made it so that objects other than view controllers can also coordinate the presentation of drawers. * Changed some configuration parameters in the demo app. * Tweaked the demo. * Added ChangeLog and updated ReadMe. * More changes to ReadMe. * Updated podspec. * More changes to the ChangeLog and ReadMe files. * Fixed guard indentation, as per comments. * Fixed guard indentations, as per comments. * DrawerKit 0.3.0 release (#35) * Added git ignore file * Added project workspace * Added tab bar template project * Added DrawerKit empty framework * Added basic view controllers and storyboards * Fixed broken outlets * Added implementation of DrawerKit. A few bits to complete still. * Hooked up the view controllers to the custom presentation. * Added clamping to the three possible resting positions of the drawer * Added more configuration to the presenting VC * Fixed a few glitches related to allowing partial expansion or not, and some refactoring. * Removed the two timing configurations and now using only one for all animations. * Added support for not having the gesture recognisers. * Fixed a potential division by zero. * Adding more configuration controls to presenting VC. WIP. * Added debug mode. * Added some TODOs * Renamed a function to make it clear it's a debugging feature. * Minor refactoring. * Renamed some source files for better clarity of intention. * Removed source headers. * Changed the presented VC to make a larger drawer (easier to play with). * Changed some parameters as per Sam's input. * Improved behaviour of corner rounding at the two edges of the screen. Still not a perfect solution because the animator's completion block is, surprisingly, not always called. Apparently, that's a bug in UIViewPropertyAnimator. * Made the logic for the drawer behaviour easier to read, because Sergey doesn't like `guard` with boolean statements. ;) * Moved some code closer to where it's actually used. * Minor formatting. * Added a fix to the corner-radius animation issue whereby the corner radius would not be set to zero because the property animator's completion would not always be called. Now we force it to zero on presentationTransitionDidEnd() (for the appropriate drawer ending positions). * Disabled automatic code signing. * The heights of the bands surrounding the resting position of the drawer are now given in absolute rather than relative terms. * Oopsie... committed a compiler error. Fixed now. * Added a scrollview to the presented view controller in the demo app, for testing how scrolling interacts with the drag gesture recogniser in the presentation controller. * Added an interaction controller, the first step in fixing the non-interactive presentation/dismissal itself. * Renamed TransitionAnimator to AnimationController. * Renamed a file to match the extension it's about. * Duh, it was supposed to be AnimationController, not AnimatorController. * Implemented interactive controller for the presentation and dismissal, and cleaned up the code for the animation controller (it doesn't need to know anything about the drawers). * Added license file and CocoaPods podspec. Not passing lint just yet. * Removed indirect access to configuration parameters. * Removed currently unused source file TransitionGeometry. * Fixed company name in the license file. * Cleared the team entry in the demo app. * Demo app: adding controls for all the configurable parameters. WIP. * Added control for manipulating cubic Bezier control points, CubicBezierView. * Added all the controls to the presenter VC. * Fixed a TODO comment. * Make sure that durationInSeconds is a positive value. * Removed all references to coversStatusBar since that hasn't been implemented yet. * Make sure that flickSpeedThreshold is a non-negative value. Also, if zero, disables support for flicking. * Make sure that upperMarkGap and lowerMarkGap are non-negative values. * Only add debugging mark lines if at least one of upperMarkGap and lowerMarkGap is a positive value. * Make sure that maximumCornerRadius is a non-negative value. * Only animate the corner radius if maximumCornerRadius is strictly positive. * Make sure that numberOfTapsForOutsideDrawerDismissal is a non-negative value. * Resolved an issue with animating rounding the presented view corners. * Simplified the demo app to its bare essentials. No more configuration controls to the wazoo. * Added based documentation to the library. * Preliminary version of README. WIP. * Removed unused assets. * Added some pseudo-code to the README, to explain the presentation/dismissal logic. * Code style change. * Removed unnecessary [weak self] capture lists. * Changed default value of durationInSeconds from 0.8 to 0.3 seconds. * Fixed a botched global search/replace in DrawerConfiguration+Equatable. * Renamed evil local gr variables to less evil names. * Fixed guard statements as per comments. * Removed a comment. * Removed a protocol extension. * Make sure that the height of the partially expanded drawer is non-negative. * Added documentation to all exposed public entities. * Style change as per comments. * Fixed documentation. * Updated README file. * Tweaked the README file. * Decreased the deployment target requirement, from 10.3 to 10.0. * Removed hidden extension in the LICENSE file. * Fixed source_files entry in the podspec. Removed the exclude_files entry. * Added a .swift-version file with the appropriate version of Swift to pod lib lint the pod. * Fixed the homepage in the podspec. * Fixed a bug when running under iOS 10 in which the initial presentation animation doesn't complete, therefore not invoking viewDidAppear, which causes the drawer not to show up at all. The work-around means that the initial presentation and dismissal aren't interactive but Product signed off on that decision. The drawers work fine under iOS 11. * Style change. * Killed the use of IUO references. * Changed author email address in the podspec. * Added support for Carthage. * [ci skip] Removed a commented out section from the README. Also, an excuse to turn CI off since DrawerKit fails it for lack of configuration for testing. * Added CircleCI config file. (#9) * Added CircleCI config file. * Changed circle.yml to "test" with the simulator, which disables testing * Let's try this one more time, shall we? * And again * Fixed circle.yml * And again * Fixed circle.yml * Fixed circle.yml. * Added CircleCI badge to README. * Simplified circle.yml build command. * Added dependency management commands to circle.yml * Fixed podspec source item. (#12) * Fixed podspec source item. * Missed the s in https. * DrawerKit release 0.0.1 (#13) (#14) * Added git ignore file * Added project workspace * Added tab bar template project * Added DrawerKit empty framework * Added basic view controllers and storyboards * Fixed broken outlets * Added implementation of DrawerKit. A few bits to complete still. * Hooked up the view controllers to the custom presentation. * Added clamping to the three possible resting positions of the drawer * Added more configuration to the presenting VC * Fixed a few glitches related to allowing partial expansion or not, and some refactoring. * Removed the two timing configurations and now using only one for all animations. * Added support for not having the gesture recognisers. * Fixed a potential division by zero. * Adding more configuration controls to presenting VC. WIP. * Added debug mode. * Added some TODOs * Renamed a function to make it clear it's a debugging feature. * Minor refactoring. * Renamed some source files for better clarity of intention. * Removed source headers. * Changed the presented VC to make a larger drawer (easier to play with). * Changed some parameters as per Sam's input. * Improved behaviour of corner rounding at the two edges of the screen. Still not a perfect solution because the animator's completion block is, surprisingly, not always called. Apparently, that's a bug in UIViewPropertyAnimator. * Made the logic for the drawer behaviour easier to read, because Sergey doesn't like `guard` with boolean statements. ;) * Moved some code closer to where it's actually used. * Minor formatting. * Added a fix to the corner-radius animation issue whereby the corner radius would not be set to zero because the property animator's completion would not always be called. Now we force it to zero on presentationTransitionDidEnd() (for the appropriate drawer ending positions). * Disabled automatic code signing. * The heights of the bands surrounding the resting position of the drawer are now given in absolute rather than relative terms. * Oopsie... committed a compiler error. Fixed now. * Added a scrollview to the presented view controller in the demo app, for testing how scrolling interacts with the drag gesture recogniser in the presentation controller. * Added an interaction controller, the first step in fixing the non-interactive presentation/dismissal itself. * Renamed TransitionAnimator to AnimationController. * Renamed a file to match the extension it's about. * Duh, it was supposed to be AnimationController, not AnimatorController. * Implemented interactive controller for the presentation and dismissal, and cleaned up the code for the animation controller (it doesn't need to know anything about the drawers). * Added license file and CocoaPods podspec. Not passing lint just yet. * Removed indirect access to configuration parameters. * Removed currently unused source file TransitionGeometry. * Fixed company name in the license file. * Cleared the team entry in the demo app. * Demo app: adding controls for all the configurable parameters. WIP. * Added control for manipulating cubic Bezier control points, CubicBezierView. * Added all the controls to the presenter VC. * Fixed a TODO comment. * Make sure that durationInSeconds is a positive value. * Removed all references to coversStatusBar since that hasn't been implemented yet. * Make sure that flickSpeedThreshold is a non-negative value. Also, if zero, disables support for flicking. * Make sure that upperMarkGap and lowerMarkGap are non-negative values. * Only add debugging mark lines if at least one of upperMarkGap and lowerMarkGap is a positive value. * Make sure that maximumCornerRadius is a non-negative value. * Only animate the corner radius if maximumCornerRadius is strictly positive. * Make sure that numberOfTapsForOutsideDrawerDismissal is a non-negative value. * Resolved an issue with animating rounding the presented view corners. * Simplified the demo app to its bare essentials. No more configuration controls to the wazoo. * Added based documentation to the library. * Preliminary version of README. WIP. * Removed unused assets. * Added some pseudo-code to the README, to explain the presentation/dismissal logic. * Code style change. * Removed unnecessary [weak self] capture lists. * Changed default value of durationInSeconds from 0.8 to 0.3 seconds. * Fixed a botched global search/replace in DrawerConfiguration+Equatable. * Renamed evil local gr variables to less evil names. * Fixed guard statements as per comments. * Removed a comment. * Removed a protocol extension. * Make sure that the height of the partially expanded drawer is non-negative. * Added documentation to all exposed public entities. * Style change as per comments. * Fixed documentation. * Updated README file. * Tweaked the README file. * Decreased the deployment target requirement, from 10.3 to 10.0. * Removed hidden extension in the LICENSE file. * Fixed source_files entry in the podspec. Removed the exclude_files entry. * Added a .swift-version file with the appropriate version of Swift to pod lib lint the pod. * Fixed the homepage in the podspec. * Fixed a bug when running under iOS 10 in which the initial presentation animation doesn't complete, therefore not invoking viewDidAppear, which causes the drawer not to show up at all. The work-around means that the initial presentation and dismissal aren't interactive but Product signed off on that decision. The drawers work fine under iOS 11. * Style change. * Killed the use of IUO references. * Changed author email address in the podspec. * Added support for Carthage. * [ci skip] Removed a commented out section from the README. Also, an excuse to turn CI off since DrawerKit fails it for lack of configuration for testing. * Added CircleCI config file. (#9) * Added CircleCI config file. * Changed circle.yml to "test" with the simulator, which disables testing * Let's try this one more time, shall we? * And again * Fixed circle.yml * And again * Fixed circle.yml * Fixed circle.yml. * Added CircleCI badge to README. * Simplified circle.yml build command. * Added dependency management commands to circle.yml * Fixed podspec source item. (#12) * Fixed podspec source item. * Missed the s in https. * Add gif and fixes the circle CI badge. (#17) * Adds a gif and fixes the circleci badge. * Moved the gif down a bit. * Removed extra space below the gif. * Changes version from 0.0.1 to 0.1. (#18) * Add missing link to Carthage (#15) * Fix to README (#21) * Changed version number from 0.0.1 to 0.1.1 in the dependency management sections of the README file. * Fix README as per David's suggestion. * Update podspec in preparation for release 0.1.2. * Revert "Update podspec in preparation for release 0.1.2." This reverts commit df1c07aa3ab36e1b82fc630ac847695edc928818. * Add 4 UI tests to check the Drawer Kit demo app is working (#22) - Open the drawer - Close the drawer - Slide to full screen - Tap close on fully open drawer * Run UI Tests as part of the CircleCI build (#25) * Experiment in running the UI tests as part of the circleci build * Fixed name in scheme * Change simulator being used to match local environment * Add scheme for demo with UI tests * Between a branch build and the merge the version available for the simulator seems to have changed. This updates the yml file to reflect this (#26) * New features (#27) * Update README.md (#23) * Fixed version number in Carthage section. * Renamed some properties and functions, for better clarity of intention. * More renaming along the same lines as the last commit. * Added support for tapping on the drawer to fully present it * More renaming. * Turned on debug mode in the demo app. * Make sure that quantities are always in their expected ranges. * Introduced an enumeration for drawer states * Removed extra blank line * Replaced the DrawerPresenting protocol with a new protocol, DrawerCoordinating, and made it so that objects other than view controllers can also coordinate the presentation of drawers. * Changed some configuration parameters in the demo app. * Tweaked the demo. * Added ChangeLog and updated ReadMe. * More changes to ReadMe. * Updated podspec. * More changes to the ChangeLog and ReadMe files. * Fixed guard indentation, as per comments. * Fixed guard indentations, as per comments. * New features and preparation for release 0.3.0 (#30) * Update README.md (#23) * Fixed version number in Carthage section. * Renamed some properties and functions, for better clarity of intention. * More renaming along the same lines as the last commit. * Added support for tapping on the drawer to fully present it * More renaming. * Turned on debug mode in the demo app. * Make sure that quantities are always in their expected ranges. * Introduced an enumeration for drawer states * Removed extra blank line * Replaced the DrawerPresenting protocol with a new protocol, DrawerCoordinating, and made it so that objects other than view controllers can also coordinate the presentation of drawers. * Changed some configuration parameters in the demo app. * Large refactoring work in preparation for adding concurrent animations. * WIP on concurrent animations * Replaced the suffix Signature with Handler in DrawerAnimationActions. * Added a number of TODO comments * Minor change, for clarity. * Changed some config params in the demo app. * Turns out it's ok to simply return false in these two comparisons. * Fixed code formatting. * Fixed a subtle bug whereby UIKit animations that ended at positions differing by as much as 0.5 points were considered to have ended at different points when they should have ended at the same position. * Fixed a bug whereby scaling animated in only one direction. * Added example animations from the collapsed state to the fully expanded state, and back. * Added support for automatically adding a handle view and automatically animating it. * Added support for not covering a portion of the screen when fully expanding the drawer. * Removed TODOs that have been handled already. * Small refactoring. * More refactoring. * Added previous gif. * Display the gifs at the same size. * Removed an extraneous comment. * Minor English corrections. * Renamed some properties to avoid abbreviations. Not all abbreviations could be removed, however, because Swift doesn't allow functions and properties to have the same name. * Merge master into dev (#32) * Update README.md (#23) * Release 0.2.0 (#28) * Added git ignore file * Added project workspace * Added tab bar template project * Added Drawe…
RuiAAPeres
pushed a commit
that referenced
this pull request
Nov 9, 2017
* Added git ignore file * Added project workspace * Added tab bar template project * Added DrawerKit empty framework * Added basic view controllers and storyboards * Fixed broken outlets * Added implementation of DrawerKit. A few bits to complete still. * Hooked up the view controllers to the custom presentation. * Added clamping to the three possible resting positions of the drawer * Added more configuration to the presenting VC * Fixed a few glitches related to allowing partial expansion or not, and some refactoring. * Removed the two timing configurations and now using only one for all animations. * Added support for not having the gesture recognisers. * Fixed a potential division by zero. * Adding more configuration controls to presenting VC. WIP. * Added debug mode. * Added some TODOs * Renamed a function to make it clear it's a debugging feature. * Minor refactoring. * Renamed some source files for better clarity of intention. * Removed source headers. * Changed the presented VC to make a larger drawer (easier to play with). * Changed some parameters as per Sam's input. * Improved behaviour of corner rounding at the two edges of the screen. Still not a perfect solution because the animator's completion block is, surprisingly, not always called. Apparently, that's a bug in UIViewPropertyAnimator. * Made the logic for the drawer behaviour easier to read, because Sergey doesn't like `guard` with boolean statements. ;) * Moved some code closer to where it's actually used. * Minor formatting. * Added a fix to the corner-radius animation issue whereby the corner radius would not be set to zero because the property animator's completion would not always be called. Now we force it to zero on presentationTransitionDidEnd() (for the appropriate drawer ending positions). * Disabled automatic code signing. * The heights of the bands surrounding the resting position of the drawer are now given in absolute rather than relative terms. * Oopsie... committed a compiler error. Fixed now. * Added a scrollview to the presented view controller in the demo app, for testing how scrolling interacts with the drag gesture recogniser in the presentation controller. * Added an interaction controller, the first step in fixing the non-interactive presentation/dismissal itself. * Renamed TransitionAnimator to AnimationController. * Renamed a file to match the extension it's about. * Duh, it was supposed to be AnimationController, not AnimatorController. * Implemented interactive controller for the presentation and dismissal, and cleaned up the code for the animation controller (it doesn't need to know anything about the drawers). * Added license file and CocoaPods podspec. Not passing lint just yet. * Removed indirect access to configuration parameters. * Removed currently unused source file TransitionGeometry. * Fixed company name in the license file. * Cleared the team entry in the demo app. * Demo app: adding controls for all the configurable parameters. WIP. * Added control for manipulating cubic Bezier control points, CubicBezierView. * Added all the controls to the presenter VC. * Fixed a TODO comment. * Make sure that durationInSeconds is a positive value. * Removed all references to coversStatusBar since that hasn't been implemented yet. * Make sure that flickSpeedThreshold is a non-negative value. Also, if zero, disables support for flicking. * Make sure that upperMarkGap and lowerMarkGap are non-negative values. * Only add debugging mark lines if at least one of upperMarkGap and lowerMarkGap is a positive value. * Make sure that maximumCornerRadius is a non-negative value. * Only animate the corner radius if maximumCornerRadius is strictly positive. * Make sure that numberOfTapsForOutsideDrawerDismissal is a non-negative value. * Resolved an issue with animating rounding the presented view corners. * Simplified the demo app to its bare essentials. No more configuration controls to the wazoo. * Added based documentation to the library. * Preliminary version of README. WIP. * Removed unused assets. * Added some pseudo-code to the README, to explain the presentation/dismissal logic. * Code style change. * Removed unnecessary [weak self] capture lists. * Changed default value of durationInSeconds from 0.8 to 0.3 seconds. * Fixed a botched global search/replace in DrawerConfiguration+Equatable. * Renamed evil local gr variables to less evil names. * Fixed guard statements as per comments. * Removed a comment. * Removed a protocol extension. * Make sure that the height of the partially expanded drawer is non-negative. * Added documentation to all exposed public entities. * Style change as per comments. * Fixed documentation. * Updated README file. * Tweaked the README file. * Decreased the deployment target requirement, from 10.3 to 10.0. * Removed hidden extension in the LICENSE file. * Fixed source_files entry in the podspec. Removed the exclude_files entry. * Added a .swift-version file with the appropriate version of Swift to pod lib lint the pod. * Fixed the homepage in the podspec. * Fixed a bug when running under iOS 10 in which the initial presentation animation doesn't complete, therefore not invoking viewDidAppear, which causes the drawer not to show up at all. The work-around means that the initial presentation and dismissal aren't interactive but Product signed off on that decision. The drawers work fine under iOS 11. * Style change. * Killed the use of IUO references. * Changed author email address in the podspec. * Added support for Carthage. * [ci skip] Removed a commented out section from the README. Also, an excuse to turn CI off since DrawerKit fails it for lack of configuration for testing. * Added CircleCI config file. (#9) * Added CircleCI config file. * Changed circle.yml to "test" with the simulator, which disables testing * Let's try this one more time, shall we? * And again * Fixed circle.yml * And again * Fixed circle.yml * Fixed circle.yml. * Added CircleCI badge to README. * Simplified circle.yml build command. * Added dependency management commands to circle.yml * Fixed podspec source item. (#12) * Fixed podspec source item. * Missed the s in https. * DrawerKit release 0.0.1 (#13) (#14) * Added git ignore file * Added project workspace * Added tab bar template project * Added DrawerKit empty framework * Added basic view controllers and storyboards * Fixed broken outlets * Added implementation of DrawerKit. A few bits to complete still. * Hooked up the view controllers to the custom presentation. * Added clamping to the three possible resting positions of the drawer * Added more configuration to the presenting VC * Fixed a few glitches related to allowing partial expansion or not, and some refactoring. * Removed the two timing configurations and now using only one for all animations. * Added support for not having the gesture recognisers. * Fixed a potential division by zero. * Adding more configuration controls to presenting VC. WIP. * Added debug mode. * Added some TODOs * Renamed a function to make it clear it's a debugging feature. * Minor refactoring. * Renamed some source files for better clarity of intention. * Removed source headers. * Changed the presented VC to make a larger drawer (easier to play with). * Changed some parameters as per Sam's input. * Improved behaviour of corner rounding at the two edges of the screen. Still not a perfect solution because the animator's completion block is, surprisingly, not always called. Apparently, that's a bug in UIViewPropertyAnimator. * Made the logic for the drawer behaviour easier to read, because Sergey doesn't like `guard` with boolean statements. ;) * Moved some code closer to where it's actually used. * Minor formatting. * Added a fix to the corner-radius animation issue whereby the corner radius would not be set to zero because the property animator's completion would not always be called. Now we force it to zero on presentationTransitionDidEnd() (for the appropriate drawer ending positions). * Disabled automatic code signing. * The heights of the bands surrounding the resting position of the drawer are now given in absolute rather than relative terms. * Oopsie... committed a compiler error. Fixed now. * Added a scrollview to the presented view controller in the demo app, for testing how scrolling interacts with the drag gesture recogniser in the presentation controller. * Added an interaction controller, the first step in fixing the non-interactive presentation/dismissal itself. * Renamed TransitionAnimator to AnimationController. * Renamed a file to match the extension it's about. * Duh, it was supposed to be AnimationController, not AnimatorController. * Implemented interactive controller for the presentation and dismissal, and cleaned up the code for the animation controller (it doesn't need to know anything about the drawers). * Added license file and CocoaPods podspec. Not passing lint just yet. * Removed indirect access to configuration parameters. * Removed currently unused source file TransitionGeometry. * Fixed company name in the license file. * Cleared the team entry in the demo app. * Demo app: adding controls for all the configurable parameters. WIP. * Added control for manipulating cubic Bezier control points, CubicBezierView. * Added all the controls to the presenter VC. * Fixed a TODO comment. * Make sure that durationInSeconds is a positive value. * Removed all references to coversStatusBar since that hasn't been implemented yet. * Make sure that flickSpeedThreshold is a non-negative value. Also, if zero, disables support for flicking. * Make sure that upperMarkGap and lowerMarkGap are non-negative values. * Only add debugging mark lines if at least one of upperMarkGap and lowerMarkGap is a positive value. * Make sure that maximumCornerRadius is a non-negative value. * Only animate the corner radius if maximumCornerRadius is strictly positive. * Make sure that numberOfTapsForOutsideDrawerDismissal is a non-negative value. * Resolved an issue with animating rounding the presented view corners. * Simplified the demo app to its bare essentials. No more configuration controls to the wazoo. * Added based documentation to the library. * Preliminary version of README. WIP. * Removed unused assets. * Added some pseudo-code to the README, to explain the presentation/dismissal logic. * Code style change. * Removed unnecessary [weak self] capture lists. * Changed default value of durationInSeconds from 0.8 to 0.3 seconds. * Fixed a botched global search/replace in DrawerConfiguration+Equatable. * Renamed evil local gr variables to less evil names. * Fixed guard statements as per comments. * Removed a comment. * Removed a protocol extension. * Make sure that the height of the partially expanded drawer is non-negative. * Added documentation to all exposed public entities. * Style change as per comments. * Fixed documentation. * Updated README file. * Tweaked the README file. * Decreased the deployment target requirement, from 10.3 to 10.0. * Removed hidden extension in the LICENSE file. * Fixed source_files entry in the podspec. Removed the exclude_files entry. * Added a .swift-version file with the appropriate version of Swift to pod lib lint the pod. * Fixed the homepage in the podspec. * Fixed a bug when running under iOS 10 in which the initial presentation animation doesn't complete, therefore not invoking viewDidAppear, which causes the drawer not to show up at all. The work-around means that the initial presentation and dismissal aren't interactive but Product signed off on that decision. The drawers work fine under iOS 11. * Style change. * Killed the use of IUO references. * Changed author email address in the podspec. * Added support for Carthage. * [ci skip] Removed a commented out section from the README. Also, an excuse to turn CI off since DrawerKit fails it for lack of configuration for testing. * Added CircleCI config file. (#9) * Added CircleCI config file. * Changed circle.yml to "test" with the simulator, which disables testing * Let's try this one more time, shall we? * And again * Fixed circle.yml * And again * Fixed circle.yml * Fixed circle.yml. * Added CircleCI badge to README. * Simplified circle.yml build command. * Added dependency management commands to circle.yml * Fixed podspec source item. (#12) * Fixed podspec source item. * Missed the s in https. * Add gif and fixes the circle CI badge. (#17) * Adds a gif and fixes the circleci badge. * Moved the gif down a bit. * Removed extra space below the gif. * Changes version from 0.0.1 to 0.1. (#18) * Add missing link to Carthage (#15) * Fix to README (#21) * Changed version number from 0.0.1 to 0.1.1 in the dependency management sections of the README file. * Fix README as per David's suggestion. * Update podspec in preparation for release 0.1.2. * Revert "Update podspec in preparation for release 0.1.2." This reverts commit df1c07aa3ab36e1b82fc630ac847695edc928818. * Add 4 UI tests to check the Drawer Kit demo app is working (#22) - Open the drawer - Close the drawer - Slide to full screen - Tap close on fully open drawer * Run UI Tests as part of the CircleCI build (#25) * Experiment in running the UI tests as part of the circleci build * Fixed name in scheme * Change simulator being used to match local environment * Add scheme for demo with UI tests * Between a branch build and the merge the version available for the simulator seems to have changed. This updates the yml file to reflect this (#26) * New features (#27) * Update README.md (#23) * Fixed version number in Carthage section. * Renamed some properties and functions, for better clarity of intention. * More renaming along the same lines as the last commit. * Added support for tapping on the drawer to fully present it * More renaming. * Turned on debug mode in the demo app. * Make sure that quantities are always in their expected ranges. * Introduced an enumeration for drawer states * Removed extra blank line * Replaced the DrawerPresenting protocol with a new protocol, DrawerCoordinating, and made it so that objects other than view controllers can also coordinate the presentation of drawers. * Changed some configuration parameters in the demo app. * Tweaked the demo. * Added ChangeLog and updated ReadMe. * More changes to ReadMe. * Updated podspec. * More changes to the ChangeLog and ReadMe files. * Fixed guard indentation, as per comments. * Fixed guard indentations, as per comments. * New features and preparation for release 0.3.0 (#30) * Update README.md (#23) * Fixed version number in Carthage section. * Renamed some properties and functions, for better clarity of intention. * More renaming along the same lines as the last commit. * Added support for tapping on the drawer to fully present it * More renaming. * Turned on debug mode in the demo app. * Make sure that quantities are always in their expected ranges. * Introduced an enumeration for drawer states * Removed extra blank line * Replaced the DrawerPresenting protocol with a new protocol, DrawerCoordinating, and made it so that objects other than view controllers can also coordinate the presentation of drawers. * Changed some configuration parameters in the demo app. * Large refactoring work in preparation for adding concurrent animations. * WIP on concurrent animations * Replaced the suffix Signature with Handler in DrawerAnimationActions. * Added a number of TODO comments * Minor change, for clarity. * Changed some config params in the demo app. * Turns out it's ok to simply return false in these two comparisons. * Fixed code formatting. * Fixed a subtle bug whereby UIKit animations that ended at positions differing by as much as 0.5 points were considered to have ended at different points when they should have ended at the same position. * Fixed a bug whereby scaling animated in only one direction. * Added example animations from the collapsed state to the fully expanded state, and back. * Added support for automatically adding a handle view and automatically animating it. * Added support for not covering a portion of the screen when fully expanding the drawer. * Removed TODOs that have been handled already. * Small refactoring. * More refactoring. * Added previous gif. * Display the gifs at the same size. * Removed an extraneous comment. * Minor English corrections. * Renamed some properties to avoid abbreviations. Not all abbreviations could be removed, however, because Swift doesn't allow functions and properties to have the same name. * Merge master into dev (#32) * Update README.md (#23) * Release 0.2.0 (#28) * Added git ignore file * Added project workspace * Added tab bar template project * Added DrawerKit empty framework * Added basic view controllers and storyboards * Fixed broken outlets * Added implementation of DrawerKit. A few bits to complete still. * Hooked up the view controllers to the custom presentation. * Added clamping to the three possible resting positions of the drawer * Added more configuration to the presenting VC * Fixed a few glitches related to allowing partial expansion or not, and some refactoring. * Removed the two timing configurations and now using only one for all animations. * Added support for not having the gesture recognisers. * Fixed a potential division by zero. * Adding more configuration controls to presenting VC. WIP. * Added debug mode. * Added some TODOs * Renamed a function to make it clear it's a debugging feature. * Minor refactoring. * Renamed some source files for better clarity of intention. * Removed source headers. * Changed the presented VC to make a larger drawer (easier to play with). * Changed some parameters as per Sam's input. * Improved behaviour of corner rounding at the two edges of the screen. Still not a perfect solution because the animator's completion block is, surprisingly, not always called. Apparently, that's a bug in UIViewPropertyAnimator. * Made the logic for the drawer behaviour easier to read, because Sergey doesn't like `guard` with boolean statements. ;) * Moved some code closer to where it's actually used. * Minor formatting. * Added a fix to the corner-radius animation issue whereby the corner radius would not be set to zero because the property animator's completion would not always be called. Now we force it to zero on presentationTransitionDidEnd() (for the appropriate drawer ending positions). * Disabled automatic code signing. * The heights of the bands surrounding the resting position of the drawer are now given in absolute rather than relative terms. * Oopsie... committed a compiler error. Fixed now. * Added a scrollview to the presented view controller in the demo app, for testing how scrolling interacts with the drag gesture recogniser in the presentation controller. * Added an interaction controller, the first step in fixing the non-interactive presentation/dismissal itself. * Renamed TransitionAnimator to AnimationController. * Renamed a file to match the extension it's about. * Duh, it was supposed to be AnimationController, not AnimatorController. * Implemented interactive controller for the presentation and dismissal, and cleaned up the code for the animation controller (it doesn't need to know anything about the drawers). * Added license file and CocoaPods podspec. Not passing lint just yet. * Removed indirect access to configuration parameters. * Removed currently unused source file TransitionGeometry. * Fixed company name in the license file. * Cleared the team entry in the demo app. * Demo app: adding controls for all the configurable parameters. WIP. * Added control for manipulating cubic Bezier control points, CubicBezierView. * Added all the controls to the presenter VC. * Fixed a TODO comment. * Make sure that durationInSeconds is a positive value. * Removed all references to coversStatusBar since that hasn't been implemented yet. * Make sure that flickSpeedThreshold is a non-negative value. Also, if zero, disables support for flicking. * Make sure that upperMarkGap and lowerMarkGap are non-negative values. * Only add debugging mark lines if at least one of upperMarkGap and lowerMarkGap is a positive value. * Make sure that maximumCornerRadius is a non-negative value. * Only animate the corner radius if maximumCornerRadius is strictly positive. * Make sure that numberOfTapsForOutsideDrawerDismissal is a non-negative value. * Resolved an issue with animating rounding the presented view corners. * Simplified the demo app to its bare essentials. No more configuration controls to the wazoo. * Added based documentation to the library. * Preliminary version of README. WIP. * Removed unused assets. * Added some pseudo-code to the README, to explain the presentation/dismissal logic. * Code style change. * Removed unnecessary [weak self] capture lists. * Changed default value of durationInSeconds from 0.8 to 0.3 seconds. * Fixed a botched global search/replace in DrawerConfiguration+Equatable. * Renamed evil local gr variables to less evil names. * Fixed guard statements as per comments. * Removed a comment. * Removed a protocol extension. * Make sure that the height of the partially expanded drawer is non-negative. * Added documentation to all exposed public entities. * Style change as per comments. * Fixed documentation. * Updated README file. * Tweaked the README file. * Decreased the deployment target requirement, from 10.3 to 10.0. * Removed hidden extension in the LICENSE file. * Fixed source_files entry in the podspec. Removed the exclude_files entry. * Added a .swift-version file with the appropriate version of Swift to pod lib lint the pod. * Fixed the homepage in the podspec. * Fixed a bug when running under iOS 10 in which the initial presentation animation doesn't complete, therefore not invoking viewDidAppear, which causes the drawer not to show up at all. The work-around means that the initial presentation and dismissal aren't interactive but Product signed off on that decision. The drawers work fine under iOS 11. * Style change. * Killed the use of IUO references. * Changed author email address in the podspec. * Added support for Carthage. * [ci skip] Removed a commented out section from the README. Also, an excuse to turn CI off since DrawerKit fails it for lack of configuration for testing. * Added CircleCI config file. (#9) * Added CircleCI config file. * Changed circle.yml to "test" with the simulator, which disables testing * Let's try this one more time, shall we? * And again * Fixed circle.yml * And again * Fixed circle.yml * Fixed circle.yml. * Added CircleCI badge to README. * Simplified circle.yml build command. * Added dependency management commands to circle.yml * Fixed podspec source item. (#12) * Fixed podspec source item. * Missed the s in https. * DrawerKit release 0.0.1 (#13) (#14) * Added git ignore file * Added project workspace * Added tab bar template project * Added DrawerKit empty framework * Added basic view controllers and storyboards * Fixed broken outlets * Added implementation of DrawerKit. A few bits to complete still. * Hooked up the view controllers to the custom presentation. * Added clamping to the three possible resting positions of the drawer * Added more configuration to the presenting VC * Fixed a few glitches related to allowing partial expansion or not, and some refactoring. * Removed the two timing configurations and now using only one for all animations. * Added support for not having the gesture recognisers. * Fixed a potential division by zero. * Adding more configuration controls to presenting VC. WIP. * Added debug mode. * Added some TODOs * Renamed a function to make it clear it's a debugging feature. * Minor refactoring. * Renamed some source files for better clarity of intention. * Removed source headers. * Changed the presented VC to make a larger drawer (easier to play with). * Changed some parameters as per Sam's input. * Improved behaviour of corner rounding at the two edges of the screen. Still not a perfect solution because the animator's completion block is, surprisingly, not always called. Apparently, that's a bug in UIViewPropertyAnimator. * Made the logic for the drawer behaviour easier to read, because Sergey doesn't like `guard` with boolean statements. ;) * Moved some code closer to where it's actually used. * Minor formatting. * Added a fix to the corner-radius animation issue whereby the corner radius would not be set to zero because the property animator's completion would not always be called. Now we force it to zero on presentationTransitionDidEnd() (for the appropriate drawer ending positions). * Disabled automatic code signing. * The heights of the bands surrounding the resting position of the drawer are now given in absolute rather than relative terms. * Oopsie... committed a compiler error. Fixed now. * Added a scrollview to the presented view controller in the demo app, for testing how scrolling interacts with the drag gesture recogniser in the presentation controller. * Added an interaction controller, the first step in fixing the non-interactive presentation/dismissal itself. * Renamed TransitionAnimator to AnimationController. * Renamed a file to match the extension it's about. * Duh, it was supposed to be AnimationController, not AnimatorController. * Implemented interactive controller for the presentation and dismissal, and cleaned up the code for the animation controller (it doesn't need to know anything about the drawers). * Added license file and CocoaPods podspec. Not passing lint just yet. * Removed indirect access to configuration parameters. * Removed currently unused source file TransitionGeometry. * Fixed company name in the license file. * Cleared the team entry in the demo app. * Demo app: adding controls for all the configurable parameters. WIP. * Added control for manipulating cubic Bezier control points, CubicBezierView. * Added all the controls to the presenter VC. * Fixed a TODO comment. * Make sure that durationInSeconds is a positive value. * Removed all references to coversStatusBar since that hasn't been implemented yet. * Make sure that flickSpeedThreshold is a non-negative value. Also, if zero, disables support for flicking. * Make sure that upperMarkGap and lowerMarkGap are non-negative values. * Only add debugging mark lines if at least one of upperMarkGap and lowerMarkGap is a positive value. * Make sure that maximumCornerRadius is a non-negative value. * Only animate the corner radius if maximumCornerRadius is strictly positive. * Make sure that numberOfTapsForOutsideDrawerDismissal is a non-negative value. * Resolved an issue with animating rounding the presented view corners. * Simplified the demo app to its bare essentials. No more configuration controls to the wazoo. * Added based documentation to the library. * Preliminary version of README. WIP. * Removed unused assets. * Added some pseudo-code to the README, to explain the presentation/dismissal logic. * Code style change. * Removed unnecessary [weak self] capture lists. * Changed default value of durationInSeconds from 0.8 to 0.3 seconds. * Fixed a botched global search/replace in DrawerConfiguration+Equatable. * Renamed evil local gr variables to less evil names. * Fixed guard statements as per comments. * Removed a comment. * Removed a protocol extension. * Make sure that the height of the partially expanded drawer is non-negative. * Added documentation to all exposed public entities. * Style change as per comments. * Fixed documentation. * Updated README file. * Tweaked the README file. * Decreased the deployment target requirement, from 10.3 to 10.0. * Removed hidden extension in the LICENSE file. * Fixed source_files entry in the podspec. Removed the exclude_files entry. * Added a .swift-version file with the appropriate version of Swift to pod lib lint the pod. * Fixed the homepage in the podspec. * Fixed a bug when running under iOS 10 in which the initial presentation animation doesn't complete, therefore not invoking viewDidAppear, which causes the drawer not to show up at all. The work-around means that the initial presentation and dismissal aren't interactive but Product signed off on that decision. The drawers work fine under iOS 11. * Style change. * Killed the use of IUO references. * Changed author email address in the podspec. * Added support for Carthage. * [ci skip] Removed a commented out section from the README. Also, an excuse to turn CI off since DrawerKit fails it for lack of configuration for testing. * Added CircleCI config file. (#9) * Added CircleCI config file. * Changed circle.yml to "test" with the simulator, which disables testing * Let's try this one more time, shall we? * And again * Fixed circle.yml * And again * Fixed circle.yml * Fixed circle.yml. * Added CircleCI badge to README. * Simplified circle.yml build command. * Added dependency management commands to circle.yml * Fixed podspec source item. (#12) * Fixed podspec source item. * Missed the s in https. * Add gif and fixes the circle CI badge. (#17) * Adds a gif and fixes the circleci badge. * Moved the gif down a bit. * Removed extra space below the gif. * Changes version from 0.0.1 to 0.1. (#18) * Add missing link to Carthage (#15) * Fix to README (#21) * Changed version number from 0.0.1 to 0.1.1 in the dependency management sections of the README file. * Fix README as per David's suggestion. * Update podspec in preparation for release 0.1.2. * Revert "Update podspec in preparation for release 0.1.2." This reverts commit df1c07aa3ab36e1b82fc630ac847695edc928818. * Add 4 UI tests to check the Drawer Kit demo app is working (#22) - Open the drawer - Close the drawer - Slide to full screen - Tap close on fully open drawer * Run UI Tests as part of the CircleCI build (#25) * Experiment in running the UI tests as part of the circleci build * Fixed name in scheme * Change simulator being used to match local environment * Add scheme for demo with UI tests * Between a branch build and the merge the version available for the simulator seems to have changed. This updates the yml file to reflect this (#26) * New features (#27) * Update README.md (#23) * Fixed version number in Carthage section. * Renamed some properties and functions, for better clarity of intention. * More renaming along the same lines as the last commit. * Added support for tapping on the drawer to fully present it * More renaming. * Turned on debug mode in the demo app. * Make sure that quantities are always in their expected ranges. * Introduced an enumeration for drawer states * Removed extra blank line * Replaced the DrawerPresenting protocol with a new protocol, DrawerCoordinating, and made it so that objects other than view controllers can also coordinate the presentation of drawers. * Changed some configuration parameters in the demo app. * Tweaked the demo. * Added ChangeLog and updated ReadMe. * More changes to ReadMe. * Updated podspec. * More changes to the ChangeLog and ReadMe files. * Fixed guard indentation, as per comments. * Fixed guard indentations, as per comments. * New features and prep for release 0.3.1 (#36) * Update README.md (#23) * Release 0.2.0 (#28) * Added git ignore file * Added project workspace * Added tab bar template project * Added DrawerKit empty framework * Added basic view controllers and storyboards * Fixed broken outlets * Added implementation of DrawerKit. A few bits to complete still. * Hooked up the view controllers to the custom presentation. * Added clamping to the three possible resting positions of the drawer * Added more configuration to the presenting VC * Fixed a few glitches related to allowing partial expansion or not, and some refactoring. * Removed the two timing configurations and now using only one for all animations. * Added support for not having the gesture recognisers. * Fixed a potential division by zero. * Adding more configuration controls to presenting VC. WIP. * Added debug mode. * Added some TODOs * Renamed a function to make it clear it's a debugging feature. * Minor refactoring. * Renamed some source files for better clarity of intention. * Removed source headers. * Changed the presented VC to make a larger drawer (easier to play with). * Changed some parameters as per Sam's input. * Improved behaviour of corner rounding at the two edges of the screen. Still not a perfect solution because the animator's completion block is, surprisingly, not always called. Apparently, that's a bug in UIViewPropertyAnimator. * Made the logic for the drawer behaviour easier to read, because Sergey doesn't like `guard` with boolean statements. ;) * Moved some code closer to where it's actually used. * Minor formatting. * Added a fix to the corner-radius animation issue whereby the corner radius would not be set to zero because the property animator's completion would not always be called. Now we force it to zero on presentationTransitionDidEnd() (for the appropriate drawer ending positions). * Disabled automatic code signing. * The heights of the bands surrounding the resting position of the drawer are now given in absolute rather than relative terms. * Oopsie... committed a compiler error. Fixed now. * Added a scrollview to the presented view controller in the demo app, for testing how scrolling interacts with the drag gesture recogniser in the presentation controller. * Added an interaction controller, the first step in fixing the non-interactive presentation/dismissal itself. * Renamed TransitionAnimator to AnimationController. * Renamed a file to match the extension it's about. * Duh, it was supposed to be AnimationController, not AnimatorController. * Implemented interactive controller for the presentation and dismissal, and cleaned up the code for the animation controller (it doesn't need to know anything about the drawers). * Added license file and CocoaPods podspec. Not passing lint just yet. * Removed indirect access to configuration parameters. * Removed currently unused source file TransitionGeometry. * Fixed company name in the license file. * Cleared the team entry in the demo app. * Demo app: adding controls for all the configurable parameters. WIP. * Added control for manipulating cubic Bezier control points, CubicBezierView. * Added all the controls to the presenter VC. * Fixed a TODO comment. * Make sure that durationInSeconds is a positive value. * Removed all references to coversStatusBar since that hasn't been implemented yet. * Make sure that flickSpeedThreshold is a non-negative value. Also, if zero, disables support for flicking. * Make sure that upperMarkGap and lowerMarkGap are non-negative values. * Only add debugging mark lines if at least one of upperMarkGap and lowerMarkGap is a positive value. * Make sure that maximumCornerRadius is a non-negative value. * Only animate the corner radius if maximumCornerRadius is strictly positive. * Make sure that numberOfTapsForOutsideDrawerDismissal is a non-negative value. * Resolved an issue with animating rounding the presented view corners. * Simplified the demo app to its bare essentials. No more configuration controls to the wazoo. * Added based documentation to the library. * Preliminary version of README. WIP. * Removed unused assets. * Added some pseudo-code to the README, to explain the presentation/dismissal logic. * Code style change. * Removed unnecessary [weak self] capture lists. * Changed default value of durationInSeconds from 0.8 to 0.3 seconds. * Fixed a botched global search/replace in DrawerConfiguration+Equatable. * Renamed evil local gr variables to less evil names. * Fixed guard statements as per comments. * Removed a comment. * Removed a protocol extension. * Make sure that the height of the partially expanded drawer is non-negative. * Added documentation to all exposed public entities. * Style change as per comments. * Fixed documentation. * Updated README file. * Tweaked the README file. * Decreased the deployment target requirement, from 10.3 to 10.0. * Removed hidden extension in the LICENSE file. * Fixed source_files entry in the podspec. Removed the exclude_files entry. * Added a .swift-version file with the appropriate version of Swift to pod lib lint the pod. * Fixed the homepage in the podspec. * Fixed a bug when running under iOS 10 in which the initial presentation animation doesn't complete, therefore not invoking viewDidAppear, which causes the drawer not to show up at all. The work-around means that the initial presentation and dismissal aren't interactive but Product signed off on that decision. The drawers work fine under iOS 11. * Style change. * Killed the use of IUO references. * Changed author email address in the podspec. * Added support for Carthage. * [ci skip] Removed a commented out section from the README. Also, an excuse to turn CI off since DrawerKit fails it for lack of configuration for testing. * Added CircleCI config file. (#9) * Added CircleCI config file. * Changed circle.yml to "test" with the simulator, which disables testing * Let's try this one more time, shall we? * And again * Fixed circle.yml * And again * Fixed circle.yml * Fixed circle.yml. * Added CircleCI badge to README. * Simplified circle.yml build command. * Added dependency management commands to circle.yml * Fixed podspec source item. (#12) * Fixed podspec source item. * Missed the s in https. * DrawerKit release 0.0.1 (#13) (#14) * Added git ignore file * Added project workspace * Added tab bar template project * Added DrawerKit empty framework * Added basic view controllers and storyboards * Fixed broken outlets * Added implementation of DrawerKit. A few bits to complete still. * Hooked up the view controllers to the custom presentation. * Added clamping to the three possible resting positions of the drawer * Added more configuration to the presenting VC * Fixed a few glitches related to allowing partial expansion or not, and some refactoring. * Removed the two timing configurations and now using only one for all animations. * Added support for not having the gesture recognisers. * Fixed a potential division by zero. * Adding more configuration controls to presenting VC. WIP. * Added debug mode. * Added some TODOs * Renamed a function to make it clear it's a debugging feature. * Minor refactoring. * Renamed some source files for better clarity of intention. * Removed source headers. * Changed the presented VC to make a larger drawer (easier to play with). * Changed some parameters as per Sam's input. * Improved behaviour of corner rounding at the two edges of the screen. Still not a perfect solution because the animator's completion block is, surprisingly, not always called. Apparently, that's a bug in UIViewPropertyAnimator. * Made the logic for the drawer behaviour easier to read, because Sergey doesn't like `guard` with boolean statements. ;) * Moved some code closer to where it's actually used. * Minor formatting. * Added a fix to the corner-radius animation issue whereby the corner radius would not be set to zero because the property animator's completion would not always be called. Now we force it to zero on presentationTransitionDidEnd() (for the appropriate drawer ending positions). * Disabled automatic code signing. * The heights of the bands surrounding the resting position of the drawer are now given in absolute rather than relative terms. * Oopsie... committed a compiler error. Fixed now. * Added a scrollview to the presented view controller in the demo app, for testing how scrolling interacts with the drag gesture recogniser in the presentation controller. * Added an interaction controller, the first step in fixing the non-interactive presentation/dismissal itself. * Renamed TransitionAnimator to AnimationController. * Renamed a file to match the extension it's about. * Duh, it was supposed to be AnimationController, not AnimatorController. * Implemented interactive controller for the presentation and dismissal, and cleaned up the code for the animation controller (it doesn't need to know anything about the drawers). * Added license file and CocoaPods podspec. Not passing lint just yet. * Removed indirect access to configuration parameters. * Removed currently unused source file TransitionGeometry. * Fixed company name in the license file. * Cleared the team entry in the demo app. * Demo app: adding controls for all the configurable parameters. WIP. * Added control for manipulating cubic Bezier control points, CubicBezierView. * Added all the controls to the presenter VC. * Fixed a TODO comment. * Make sure that durationInSeconds is a positive value. * Removed all references to coversStatusBar since that hasn't been implemented yet. * Make sure that flickSpeedThreshold is a non-negative value. Also, if zero, disables support for flicking. * Make sure that upperMarkGap and lowerMarkGap are non-negative values. * Only add debugging mark lines if at least one of upperMarkGap and lowerMarkGap is a positive value. * Make sure that maximumCornerRadius is a non-negative value. * Only animate the corner radius if maximumCornerRadius is strictly positive. * Make sure that numberOfTapsForOutsideDrawerDismissal is a non-negative value. * Resolved an issue with animating rounding the presented view corners. * Simplified the demo app to its bare essentials. No more configuration controls to the wazoo. * Added based documentation to the library. * Preliminary version of README. WIP. * Removed unused assets. * Added some pseudo-code to the README, to explain the presentation/dismissal logic. * Code style change. * Removed unnecessary [weak self] capture lists. * Changed default value of durationInSeconds from 0.8 to 0.3 seconds. * Fixed a botched global search/replace in DrawerConfiguration+Equatable. * Renamed evil local gr variables to less evil names. * Fixed guard statements as per comments. * Removed a comment. * Removed a protocol extension. * Make sure that the height of the partially expanded drawer is non-negative. * Added documentation to all exposed public entities. * Style change as per comments. * Fixed documentation. * Updated README file. * Tweaked the README file. * Decreased the deployment target requirement, from 10.3 to 10.0. * Removed hidden extension in the LICENSE file. * Fixed source_files entry in the podspec. Removed the exclude_files entry. * Added a .swift-version file with the appropriate version of Swift to pod lib lint the pod. * Fixed the homepage in the podspec. * Fixed a bug when running under iOS 10 in which the initial presentation animation doesn't complete, therefore not invoking viewDidAppear, which causes the drawer not to show up at all. The work-around means that the initial presentation and dismissal aren't interactive but Product signed off on that decision. The drawers work fine under iOS 11. * Style change. * Killed the use of IUO references. * Changed author email address in the podspec. * Added support for Carthage. * [ci skip] Removed a commented out section from the README. Also, an excuse to turn CI off since DrawerKit fails it for lack of configuration for testing. * Added CircleCI config file. (#9) * Added CircleCI config file. * Changed circle.yml to "test" with the simulator, which disables testing * Let's try this one more time, shall we? * And again * Fixed circle.yml * And again * Fixed circle.yml * Fixed circle.yml. * Added CircleCI badge to README. * Simplified circle.yml build command. * Added dependency management commands to circle.yml * Fixed podspec source item. (#12) * Fixed podspec source item. * Missed the s in https. * Add gif and fixes the circle CI badge. (#17) * Adds a gif and fixes the circleci badge. * Moved the gif down a bit. * Removed extra space below the gif. * Changes version from 0.0.1 to 0.1. (#18) * Add missing link to Carthage (#15) * Fix to README (#21) * Changed version number from 0.0.1 to 0.1.1 in the dependency management sections of the README file. * Fix README as per David's suggestion. * Update podspec in preparation for release 0.1.2. * Revert "Update podspec in preparation for release 0.1.2." This reverts commit df1c07aa3ab36e1b82fc630ac847695edc928818. * Add 4 UI tests to check the Drawer Kit demo app is working (#22) - Open the drawer - Close the drawer - Slide to full screen - Tap close on fully open drawer * Run UI Tests as part of the CircleCI build (#25) * Experiment in running the UI tests as part of the circleci build * Fixed name in scheme * Change simulator being used to match local environment * Add scheme for demo with UI tests * Between a branch build and the merge the version available for the simulator seems to have changed. This updates the yml file to reflect this (#26) * New features (#27) * Update README.md (#23) * Fixed version number in Carthage section. * Renamed some properties and functions, for better clarity of intention. * More renaming along the same lines as the last commit. * Added support for tapping on the drawer to fully present it * More renaming. * Turned on debug mode in the demo app. * Make sure that quantities are always in their expected ranges. * Introduced an enumeration for drawer states * Removed extra blank line * Replaced the DrawerPresenting protocol with a new protocol, DrawerCoordinating, and made it so that objects other than view controllers can also coordinate the presentation of drawers. * Changed some configuration parameters in the demo app. * Tweaked the demo. * Added ChangeLog and updated ReadMe. * More changes to ReadMe. * Updated podspec. * More changes to the ChangeLog and ReadMe files. * Fixed guard indentation, as per comments. * Fixed guard indentations, as per comments. * DrawerKit 0.3.0 release (#35) * Added git ignore file * Added project workspace * Added tab bar template project * Added DrawerKit empty framework * Added basic view controllers and storyboards * Fixed broken outlets * Added implementation of DrawerKit. A few bits to complete still. * Hooked up the view controllers to the custom presentation. * Added clamping to the three possible resting positions of the drawer * Added more configuration to the presenting VC * Fixed a few glitches related to allowing partial expansion or not, and some refactoring. * Removed the two timing configurations and now using only one for all animations. * Added support for not having the gesture recognisers. * Fixed a potential division by zero. * Adding more configuration controls to presenting VC. WIP. * Added debug mode. * Added some TODOs * Renamed a function to make it clear it's a debugging feature. * Minor refactoring. * Renamed some source files for better clarity of intention. * Removed source headers. * Changed the presented VC to make a larger drawer (easier to play with). * Changed some parameters as per Sam's input. * Improved behaviour of corner rounding at the two edges of the screen. Still not a perfect solution because the animator's completion block is, surprisingly, not always called. Apparently, that's a bug in UIViewPropertyAnimator. * Made the logic for the drawer behaviour easier to read, because Sergey doesn't like `guard` with boolean statements. ;) * Moved some code closer to where it's actually used. * Minor formatting. * Added a fix to the corner-radius animation issue whereby the corner radius would not be set to zero because the property animator's completion would not always be called. Now we force it to zero on presentationTransitionDidEnd() (for the appropriate drawer ending positions). * Disabled automatic code signing. * The heights of the bands surrounding the resting position of the drawer are now given in absolute rather than relative terms. * Oopsie... committed a compiler error. Fixed now. * Added a scrollview to the presented view controller in the demo app, for testing how scrolling interacts with the drag gesture recogniser in the presentation controller. * Added an interaction controller, the first step in fixing the non-interactive presentation/dismissal itself. * Renamed TransitionAnimator to AnimationController. * Renamed a file to match the extension it's about. * Duh, it was supposed to be AnimationController, not AnimatorController. * Implemented interactive controller for the presentation and dismissal, and cleaned up the code for the animation controller (it doesn't need to know anything about the drawers). * Added license file and CocoaPods podspec. Not passing lint just yet. * Removed indirect access to configuration parameters. * Removed currently unused source file TransitionGeometry. * Fixed company name in the license file. * Cleared the team entry in the demo app. * Demo app: adding controls for all the configurable parameters. WIP. * Added control for manipulating cubic Bezier control points, CubicBezierView. * Added all the controls to the presenter VC. * Fixed a TODO comment. * Make sure that durationInSeconds is a positive value. * Removed all references to coversStatusBar since that hasn't been implemented yet. * Make sure that flickSpeedThreshold is a non-negative value. Also, if zero, disables support for flicking. * Make sure that upperMarkGap and lowerMarkGap are non-negative values. * Only add debugging mark lines if at least one of upperMarkGap and lowerMarkGap is a positive value. * Make sure that maximumCornerRadius is a non-negative value. * Only animate the corner radius if maximumCornerRadius is strictly positive. * Make sure that numberOfTapsForOutsideDrawerDismissal is a non-negative value. * Resolved an issue with animating rounding the presented view corners. * Simplified the demo app to its bare essentials. No more configuration controls to the wazoo. * Added based documentation to the library. * Preliminary version of README. WIP. * Removed unused assets. * Added some pseudo-code to the README, to explain the presentation/dismissal logic. * Code style change. * Removed unnecessary [weak self] capture lists. * Changed default value of durationInSeconds from 0.8 to 0.3 seconds. * Fixed a botched global search/replace in DrawerConfiguration+Equatable. * Renamed evil local gr variables to less evil names. * Fixed guard statements as per comments. * Removed a comment. * Removed a protocol extension. * Make sure that the height of the partially expanded drawer is non-negative. * Added documentation to all exposed public entities. * Style change as per comments. * Fixed documentation. * Updated README file. * Tweaked the README file. * Decreased the deployment target requirement, from 10.3 to 10.0. * Removed hidden extension in the LICENSE file. * Fixed source_files entry in the podspec. Removed the exclude_files entry. * Added a .swift-version file with the appropriate version of Swift to pod lib lint the pod. * Fixed the homepage in the podspec. * Fixed a bug when running under iOS 10 in which the initial presentation animation doesn't complete, therefore not invoking viewDidAppear, which causes the drawer not to show up at all. The work-around means that the initial presentation and dismissal aren't interactive but Product signed off on that decision. The drawers work fine under iOS 11. * Style change. * Killed the use of IUO references. * Changed author email address in the podspec. * Added support for Carthage. * [ci skip] Removed a commented out section from the README. Also, an excuse to turn CI off since DrawerKit fails it for lack of configuration for testing. * Added CircleCI config file. (#9) * Added CircleCI config file. * Changed circle.yml to "test" with the simulator, which disables testing * Let's try this one more time, shall we? * And again * Fixed circle.yml * And again * Fixed circle.yml * Fixed circle.yml. * Added CircleCI badge to README. * Simplified circle.yml build command. * Added dependency management commands to circle.yml * Fixed podspec source item. (#12) * Fixed podspec source item. * Missed the s in https. * DrawerKit release 0.0.1 (#13) (#14) * Added git ignore file * Added project workspace * Added tab bar template project * Added DrawerKit empty framework * Added basic view controllers and storyboards * Fixed broken outlets * Added implementation of DrawerKit. A few bits to complete still. * Hooked up the view controllers to the custom presentation. * Added clamping to the three possible resting positions of the drawer * Added more configuration to the presenting VC * Fixed a few glitches related to allowing partial expansion or not, and some refactoring. * Removed the two timing configurations and now using only one for all animations. * Added support for not having the gesture recognisers. * Fixed a potential division by zero. * Adding more configuration controls to presenting VC. WIP. * Added debug mode. * Added some TODOs * Renamed a function to make it clear it's a debugging feature. * Minor refactoring. * Renamed some source files for better clarity of intention. * Removed source headers. * Changed the presented VC to make a larger drawer (easier to play with). * Changed some parameters as per Sam's input. * Improved behaviour of corner rounding at the two edges of the screen. Still not a perfect solution because the animator's completion block is, surprisingly, not always called. Apparently, that's a bug in UIViewPropertyAnimator. * Made the logic for the drawer behaviour easier to read, because Sergey doesn't like `guard` with boolean statements. ;) * Moved some code closer to where it's actually used. * Minor formatting. * Added a fix to the corner-radius animation issue whereby the corner radius would not be set to zero because the property animator's completion would not always be called. Now we force it to zero on presentationTransitionDidEnd() (for the appropriate drawer ending positions). * Disabled automatic code signing. * The heights of the bands surrounding the resting position of the drawer are now given in absolute rather than relative terms. * Oopsie... committed a compiler error. Fixed now. * Added a scrollview to the presented view controller in the demo app, for testing how scrolling interacts with the drag gesture recogniser in the presentation controller. * Added an interaction controller, the first step in fixing the non-interactive presentation/dismissal itself. * Renamed TransitionAnimator to AnimationController. * Renamed a file to match the extension it's about. * Duh, it was supposed to be AnimationController, not AnimatorController. * Implemented interactive controller for the presentation and dismissal, and cleaned up the code for the animation controller (it doesn't need to know anything about the drawers). * Added license file and CocoaPods podspec. Not passing lint just yet. * Removed indirect access to configuration parameters. * Removed currently unused source file TransitionGeometry. * Fixed company name in the license file. * Cleared the team entry in the demo app. * Demo app: adding controls for all the configurable parameters. WIP. * Added control for manipulating cubic Bezier control points, CubicBezierView. * Added all the controls to the presenter VC. * Fixed a TODO comment. * Make sure that durationInSeconds is a positive value. * Removed all references to coversStatusBar since that hasn't been implemented yet. * Make sure that flickSpeedThreshold is a non-negative value. Also, if zero, disables support for flicking. * Make sure that upperMarkGap and lowerMarkGap are non-negative values. * Only add debugging mark lines if at least one of upperMarkGap and lowerMarkGap is a positive value. * Make sure that maximumCornerRadius is a non-negative value. * Only animate the corner radius if maximumCornerRadius is strictly positive. * Make sure that numberOfTapsForOutsideDrawerDismissal is a non-negative value. * Resolved an issue with animating rounding the presented view corners. * Simplified the demo app to its bare essentials. No more configuration controls to the wazoo. * Added based documentation to the library. * Preliminary version of README. WIP. * Removed unused assets. * Added some pseudo-code to the README, to explain the presentation/dismissal logic. * Code style change. * Removed unnecessary [weak self] capture lists. * Changed default value of durationInSeconds from 0.8 to 0.3 seconds. * Fixed a botched global search/replace in DrawerConfiguration+Equatable. * Renamed evil local gr variables to less evil names. * Fixed guard statements as per comments. * Removed a comment. * Removed a protocol extension. * Make sure that the height of the partially expanded drawer is non-negative. * Added documentation to all exposed public entities. * Style change as per comments. * Fixed documentation. * Updated README file. * Tweaked the README file. * Decreased the deployment target requirement, from 10.3 to 10.0. * Removed hidden extension in the LICENSE file. * Fixed source_files entry in the podspec. Removed the exclude_files entry. * Added a .swift-version file with the appropriate version of Swift to pod lib lint the pod. * Fixed the homepage in the podspec. * Fixed a bug when running under iOS 10 in which the initial presentation animation doesn't complete, therefore not invoking viewDidAppear, which causes the drawer not to show up at all. The work-around means that the initial presentation and dismissal aren't interactive but Product signed off on that decision. The drawers work fine under iOS 11. * Style change. * Killed the use of IUO references. * Changed author email address in the podspec. * Added support for Carthage. * [ci skip] Removed a commented out section from the README. Also, an excuse to turn CI off since DrawerKit fails it for lack of configuration for testing. * Added CircleCI config file. (#9) * Added CircleCI config file. * Changed circle.yml to "test" with the simulator, which disables testing * Let's try this one more time, shall we? * And again * Fixed circle.yml * And again * Fixed circle.yml * Fixed circle.yml. * Added CircleCI badge to README. * Simplified circle.yml build command. * Added dependency management commands to circle.yml * Fixed podspec source item. (#12) * Fixed podspec source item. * Missed the s in https. * Add gif and fixes the circle CI badge. (#17) * Adds a gif and fixes the circleci badge. * Moved the gif down a bit. * Removed extra space below the gif. * Changes version from 0.0.1 to 0.1. (#18) * Add missing link to Carthage (#15) * Fix to README (#21) * Changed version number from 0.0.1 to 0.1.1 in the dependency management sections of the README file. * Fix README as per David's suggestion. * Update podspec in preparation for release 0.1.2. * Revert "Update podspec in preparation for release 0.1.2." This reverts commit df1c07aa3ab36e1b82fc630ac847695edc928818. * Add 4 UI tests to check the Drawer Kit demo app is working (#22) - Open the drawer - Close the drawer - Slide to full screen - Tap close on fully open drawer * Run UI Tests as part of the CircleCI build (#25) * Experiment in running the UI tests as part of the circleci build * Fixed name in scheme * Change simulator being used to match local environment * Add scheme for demo with UI tests * Between a branch build and the merge the version available for the simulator seems to have changed. This updates the yml file to reflect this (#26) * New features (#27) * Update README.md (#23) * Fixed version number in Carthage section. * Renamed some properties and functions, for better clarity of intention. * More renaming along the same lines as the last commit. * Added support for tapping on the drawer to fully present it * More renaming. * Turned on debug mode in the demo app. * Make sure that quantities are always in their expected ranges. * Introduced an enumeration for drawer states * Removed extra blank line * Replaced the DrawerPresenting protocol with a new protocol, DrawerCoordinating, and made it so that objects other than view controllers can also coordinate the presentation of drawers. * Changed some configuration parameters in the demo app. * Tweaked the demo. * Added ChangeLog and updated ReadMe. * More changes to ReadMe. * Updated podspec. * More changes to the ChangeLog and ReadMe files. * Fixed guard indentation, as per comments. * Fixed guard indentations, as per comments. * New features and preparation for release 0.3.0 (#30) * Update README.md (#23) * Fixed version number in Carthage section. * Renamed some properties and functions, for better clarity of intention. * More renaming along the same lines as the last commit. * Added support for tapping on the drawer to fully present it * More renaming. * Turned on debug mode in the demo app. * Make sure that quantities are always in their expected ranges. * Introduced an enumeration for drawer states * Removed extra blank line * Replaced the DrawerPresenting protocol with a new protocol, DrawerCoordinating, and made it so that objects other than view controllers can also coordinate the presentation of drawers. * Changed some configuration parameters in the demo app. * Large refactoring work in preparation for adding concurrent animations. * WIP on concurrent animations * Replaced the suffix Signature with Handler in DrawerAnimationActions. * Added a number of TODO comments * Minor change, for clarity. * Changed some config params in the demo app. * Turns out it's ok to simply return false in these two comparisons. * Fixed code formatting. * Fixed a subtle bug whereby UIKit animations that ended at positions differing by as much as 0.5 points were considered to have ended at different points when they should have ended at the same position. * Fixed a bug whereby scaling animated in only one direction. * Added example animations from the collapsed state to the fully expanded state, and back. * Added support for automatically adding a handle view and automatically animating it. * Added support for not covering a portion of the screen when fully expanding the drawer. * Removed TODOs that have been handled already. * Small refactoring. * More refactoring. * Added previous gif. * Display the gifs at the same size. * Removed an extraneous comment. * Minor English corrections. * Renamed some properties to avoid abbreviations. Not all abbreviations could be removed, however, because Swift doesn't allow functions and properties to have the same name. * Merge master into dev (#32) * Update README.md (#23) * Release 0.2.0 (#28) * Added git ignore file * Added project workspace * Added tab bar template project * Added Drawe…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New features: