Fix binary artifacts for Mac

[lispyclouds]

Addresses #19

[borkdude]

Maybe be explicit about the environment here and keep GOARCH?

[lispyclouds]

Same as the other comment, thought to keep the var set only where its needed and only vary the instance types.

[borkdude]

Why is this removed?

[lispyclouds]

I should add the CGO_ENABLED one, but the GOARCH and GOOS felt like another point of change apart from the instance type its running on. Felt better to remove since we have dedicated instances; would be better to keep if we cross compiled for all in a single instance.

[borkdude]

@lispyclouds I made some comments but maybe you can't see them so I'm posting it as screenshot here as well.

It seems that the only changes needed are to the test build script + test? E.g. why is CGO removed from the linux aarch build?

[lispyclouds]

Answered them, adding the CGO back but want to know of what you think of my reasons for removing the others.

[borkdude]

@lispyclouds I think we should only change something if we are solving a problem. Just changing the test binary name solves the problem so I'd only change that.

[borkdude]

Why are we even building a separate test binary?

[lispyclouds]

IIRC it was to aid in local testing, to not build separately too. The commit was from you: f7f8ab2

[lispyclouds]

only the file changes are there now. we could use the binary built in the prev step for the tests but for arm macs, its going to run the amd binary and not sure if rosetta is setup? or if thats a comprehensive test or not with CGO etc

[borkdude]

Installing rosetta is very simple:

      - run:
          name: Install Rosetta
          command: |
            sudo /usr/sbin/softwareupdate --install-rosetta --agree-to-license

Since rosetta wasn't a problem before, why was a separate test binary used before? I don't get the reason for that still.

[lispyclouds]

Yeah I think we can avoid the test build but like I said before, I think you added it in the shape you had it in your local test setup in f7f8ab2
Having the script like this allows for a faster test cycle without needing to do a go build before testing for every code change

[borkdude]

Alright. Thanks for hunting the bug down! I'll just merge this and make a release tomorrow.