add PGProperty fields (conditionally) to reflection config #1056
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1046
The pg driver appears to use reflection to check annotations on fields. This change will make those fields available.
The executable sizes produced by my build process are a) not in the "reference context" for size and b) not amazingly consistent, but as far as I can tell:
Regarding functional testing, I was able to use the postgresql-test class with
BABASHKA_TEST_ENV=native
(with removing thetu/jvm?
condition) inbabashka/test/babashka/postgresql_test.clj
Line 21 in 2bb7499
pre-change, this test exhibits a similar behavior to that described in #1046 (throwing a
java.lang.ExceptionInInitializerError
). Post-change, the test passes. I also tested using a postgres container to more directly reproduce the issue described and verify that the issue is resolved by the change.