Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/session storage #32

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feature/session storage #32

wants to merge 2 commits into from

Conversation

engine-turning
Copy link

The cookie previously contained sensitive user information which poses
a security risk.

Greg added 2 commits April 15, 2015 09:36
Disable Cookies
8802684 
Storing sensitive user information in a cookie is a security risk.
Removed sensitive information from cookie
5784f30 
The cookie previously contained sensitive user information which poses
a security risk.
@giastfader
Copy link
Member

Hi,
I see the potential problem, but in this way the semantic of getCurrentUser() is totally different. It no longer returns the current user with all their attribute but the session token.
getCurrentUser() should ask to the server the actual data instead of rely on cookies/local storage, and a new getSessionToken() should be implemented.
WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@engine-turning @giastfader