Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raises an error instead of a warning when is True, but we supply no … #187

Merged
merged 1 commit into from
Feb 11, 2022
Merged

Raises an error instead of a warning when is True, but we supply no … #187

merged 1 commit into from
Feb 11, 2022

Conversation

Dref360
Copy link
Member

@Dref360 Dref360 commented Feb 5, 2022

…labels

Summary:

Fix issues found by Kino on Slack where the NLP notebook would fail due to the new can_label method of HFDataset.

Features:

Checklist:

  • Your code is documented (To validate this, add your module to tests/documentation_test.py).
  • Your code is tested with unit tests.
  • You moved your Issue to the PR state.

@Dref360 Dref360 requested a review from parmidaatg February 5, 2022 14:48
@Dref360 Dref360 merged commit edf35e9 into master Feb 11, 2022
@Dref360 Dref360 deleted the issue/can_label_switch_to_error branch February 11, 2022 15:44
@Dref360 Dref360 mentioned this pull request Mar 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parmidaatg parmidaatg Awaiting requested review from parmidaatg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Dref360