Ruby Segment changes for Python 2/3: #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Blue-Dog-Archolite
commented
Feb 22, 2018
Blue-Dog-Archolite
commented
- use "GEM_HOME" in keys
- removal of python2 specific code
- verification of python2 / python3 functionality
b-ryan
reviewed
Feb 22, 2018
| gem = os.environ["GEM_HOME"].split("@") | ||
| if len(gem) > 1: | ||
| version += " " + gem[1] | ||
| if "GEM_HOME" in os.environ.keys(): |
There was a problem hiding this comment.
Can this not be "GEM_HOME" in os.environ?
There was a problem hiding this comment.
Actually, I find this version of the code even nicer:
gem = os.getenv("GEM_HOME", "").split("@")
if len(gem) > 1:
...There was a problem hiding this comment.
Your very right. I was just patching the issue for the python error. I'll fix it up and make it nice and not just functional.
|
@b-ryan Let me know if that is a better format. I find it easier to read. |
|
Looks good. Is there ever a case where |
- use "GEM_HOME" in keys - removal of python2 specific code - verification of python2 / python3 functionality - use of format in append to replace string join
Blue-Dog-Archolite
force-pushed
the
master
branch
from
4fdd395 to
6ff4b50
Compare
|
I managed to find one case and that caused the full path of the ruby executable to show and not the gemset. Code corrected to sort that out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.