fix: bitmap wallpaper setting on main thread #132
Conversation
app/src/main/java/com/b_lam/resplash/ui/photo/detail/PhotoDetailActivity.kt
Outdated
Show resolved
Hide resolved
| viewModel.downloadUUID = DownloadWorker.enqueueDownload( | ||
| applicationContext, | ||
| DownloadAction.WALLPAPER, url, photo.fileName, photo.id | ||
| ) |
There was a problem hiding this comment.
| viewModel.downloadUUID = DownloadWorker.enqueueDownload( | |
| applicationContext, | |
| DownloadAction.WALLPAPER, url, photo.fileName, photo.id | |
| ) | |
| viewModel.downloadUUID = DownloadWorker.enqueueDownload( | |
| applicationContext, | |
| DownloadAction.WALLPAPER, | |
| url, | |
| photo.fileName, | |
| photo.id | |
| ) |
There was a problem hiding this comment.
@crazyhitty code formatting has been applied.
Co-authored-by: Kartik Sharma <[email protected]>
Co-authored-by: Kartik Sharma <[email protected]>
| private fun setWallpaperWithBitmap(bitmap: Bitmap) { | ||
| lifecycleScope.launch { | ||
| withContext((Executors.newSingleThreadExecutor().asCoroutineDispatcher())) { | ||
| wallpaperManager.setBitmap(bitmap) |
There was a problem hiding this comment.
setBitmap throws IOException in case if something goes wrong while setting wallpaper. Please handle the exception.
Reference
There was a problem hiding this comment.
Made the necessary changes.
app/src/main/java/com/b_lam/resplash/ui/photo/detail/PhotoDetailActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/b_lam/resplash/ui/photo/detail/PhotoDetailActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/b_lam/resplash/ui/photo/detail/PhotoDetailActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/b_lam/resplash/ui/photo/detail/PhotoDetailActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/b_lam/resplash/ui/photo/detail/PhotoDetailActivity.kt
Outdated
Show resolved
Hide resolved
Yes, I can see the freezing of the main thread when were preparing bitmap from URI and then setting it as wallpaper. |
|
Awesome work, thanks for doing this! If you're interested in working on other parts of Resplash just let me know :) |
|
sure, @b-lam. Do we have any pending features or existing tasks? |
|
Currently I'm working on implementing the new-ish topics endpoint (https://unsplash.com/documentation#list-topics). The work I've done so far is on this branch https://github.com/b-lam/Resplash/tree/add-topics. Some of the other things I have on my list of things to do is migrating from Paging 2 to Paging 3, fixing a lockscreen wallpaper issue that some users have mentioned, adding support for auto wallpaper intervals less than 15 minutes. I should probably start adding some of my pending work to the Github issues section. If you are a user of Resplash, feel free to do anything that you think would make the app better! |
Presently, when the
Wallapaper Manageris unable to find the crop and set activity. App decodes the image and sets the bitmap on the main thread which should be avoided.