fix(lib): use ipaddr.js instead of ip for support IPv6
#3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix to handle IPv6 address like IPv4-mapped IPv6 addresses
azu
force-pushed
the
switch-ipaddr.js
branch
from
4674f7c to
d704fc1
Compare
azu
commented
Sep 5, 2019
| } | ||
| } | ||
| // TODO: rename option name | ||
| if (!options.allowPrivateIPAddress && range !== "unicast") { |
There was a problem hiding this comment.
I think that allowPrivateIPAddress option name is invalid.
allowReservedIPAddress is correct.
azu
commented
Sep 5, 2019
| // TODO: Travis CI does not support IPv6 | ||
| // https://docs.travis-ci.com/user/reference/overview/ | ||
| // https://github.com/travis-ci/travis-ci/issues/8891 | ||
| (IS_TRAVIS ? it.skip : it)("IPv6: should not request because Socket is closed", async () => { |
There was a problem hiding this comment.
Travis CI does not support IPv6...
We need to other CI servier that support IPv6 network...
In locally, These tests are passed.
azu
changed the title
ipaddr.js instead of ip for IPv6 supporting
azu
changed the title
ipaddr.js instead of ip for IPv6 supportingipaddr.js instead of ip for support IPv6
azu
changed the title
ipaddr.js instead of ip for support IPv6ipaddr.js instead of ip for support IPv6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/indutny/node-ip has not defined IPv4-mapped IPv6 addresses like
[::ffff:127.0.0.1].Swith to use ipaddr.js for parsing IPv6 address correctly.
ipaddr.js has
SpecialRangesthat is defined RFC IP Address range that include IPv4-mapped IPv6 addresses.https://github.com/whitequark/ipaddr.js/blob/3ade7dbfa1d9713f0aabe002c9a0718c4cc6cb5e/lib/ipaddr.js#L506
Changes
fix #2