-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added asdf strap #18
Added asdf strap #18
Conversation
@tk8817 before i merge this in, you mentioned that there should be a version bump. Do we version bump on added straps? I personally feel the straps fall under their own versions and the "main" version is related to the strapped command. Thoughts? |
To me a new strap means
Ideally I want a way to let our users know when new functionality is available, and to let the media know what that new functionality is. I agree the versions are not related, but I think we should do a minor bump of strapped itself as a means of having a release entry marking the new strapped repo feature. An alternate would be to move the straps to another repo and do releases there. |
Looking at a pr to the homebrew-core repo, they have separated the available packages from the tool, but there is no repo-wide version. The difference I see here is homebrew has a mechanism to discover changes to their repository where we do not besides our documentation. Maybe the problem I am seeing is one of scale - but I do agree there will be issues around discovering new or updated straps. With our current setup I agree with you that we should bump the minor version. I will update this pr to include that version bump. I will also raise an issue to discuss this further because moving forward I believe this could cause more work and confusion. |
@fvumbaca - aligned 100%, lets find a better way forward for future PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Lets bump version and lets generate a release.
Added support for asdf version manager.