fix(Scripts/Zuldrak) Npc: Blightguard; Spell: Scourge Disguise and related things

[p-tkachuk]

Thanks to TrinityCore for the provided spawn locations!

Changes Proposed:

This PR proposes changes to:

• Core (units, players, creatures, game systems).
• Scripts (bosses, spell scripts, creature scripts).
• Database (SAI, creatures, etc).

Issues Addressed:

1. Blightguard spawn location are missing from DB. (currently only a couple of mobs are spawned).
   Also this mobs should: have invisibility and remove Scourge Disguise aura from player on attack
2. Scourge Disguise spell [51966, 52192] is "unstable" and should be removed after some time with message informing player about it: "Scourge Disguise Failing! Find a safe place!"
3. Quest "Dark horizon" [12664]: When NPC Gorebag [28666] sends player on a fly mount to see some places it casted another copy of "Scourge Disguise" on player, which caused 2 active auras being on a player at the same time. And if 1 aura was removed - second aura didnt had any effect.

SOURCE:

The changes have been validated through:

• Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
• Sniffs (remember to share them with the open source community!)
• Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
• The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

• Tested in-game by the author.
• Tested in-game by other community members/someone else other than the author/has been live on production servers.
• This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

1. Blightguard
   .additem 38699 // Choker
   .go xyz 6278.02 -1933.10 239.60 571
   Use Choker

NPC around you should became friendly, except Blightguards.
Approach Blightguards, they should attack you and remove your Disguise aura.

2. Scourge Disguise spell
   .additem 38699 // Choker
   .go xyz 6278.02 -1933.10 239.60 571
   Use Choker

Wait 3-5 minutes. Now you should see that spell is going to end, and it will be actually removed.

3. Quest "Dark horizon"
   .additem 38699 // Choker
   .go xyz 6278.02 -1933.10 239.60 571
   Use Choker
   .quest add 12664 // dark horizon quest
   .go creature id 28666 // Gorebag

Talk to NPC, take a ride, see that you have only 1 active aura of "Scourge Disguise" after ride is over.

Known Issues and TODO List:

• [ ]
• [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[Rorschach91]

In case of merge, please remember to remove my co-authoring.

[sudlud]

if spawns are taken from trinitycore please correctly add the co-author of the trinitycore commit / PR here.

[p-tkachuk]

if spawns are taken from trinitycore please correctly add the co-author of the trinitycore commit / PR here.

done