Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Core/Server): Improvements to antidos opcode handling #21502

Merged
merged 7 commits into from
Feb 21, 2025

Conversation

Takenbacon
Copy link
Contributor

Couple changes to antidos opcode handling:

  • Moves hardcoded list to database, allowing individual handling policies per opcode and run time reloading
  • Implements BlockingThrottle & DropPacket policy types
  • Changes AH search requests to BlockingThrottle policy type
  • Not specifically related to this change but adds a WorldGlobals file to prevent adding more clutter in World class and for future use with moving around other global storages

Implementation note: BlockingThrottle isn't an ideal solution as it temporarily prevents processing of remaining packets in queue (hence the name "blocking") and as such should only be used in careful and very specific cases. In an ideal world we'd have multiple packet processing queues with different properties however that would be a much more involved change. I can attest from experience that using a simple queue block to throttle AH searches works sufficiently enough without noticeable effects.

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Issues Addressed:

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@github-actions github-actions bot added DB related to the SQL database CORE Related to the core Script file-cpp Used to trigger the matrix build labels Feb 18, 2025
@Takenbacon
Copy link
Contributor Author

@skelUA Try this

@Kitzunu
Copy link
Member

Kitzunu commented Feb 18, 2025

Codestyle / SQL (pull_request) can be ignored

@Kitzunu Kitzunu added the Requires WIKI Update Wiki sources will need to be updated after merging this PR. label Feb 18, 2025
@Kitzunu Kitzunu merged commit 4cd1ed2 into azerothcore:master Feb 21, 2025
13 of 14 checks passed
@Nyeriah
Copy link
Member

Nyeriah commented Feb 22, 2025

https://gist.github.com/Nyeriah/c2fe3652e36cf315f8b721f939c5d698

CMSG_CONTACT_LIST seems to be haywire, flagging many players per sec, I moved the policy from kick to warn to observe it so its spamming a lot as the logs show (very high packet counts per player, e.g over 700, while the policy expects 200 max)

Edit: player reported kicks after loading screen finishes

@Takenbacon
Copy link
Contributor Author

Takenbacon commented Feb 22, 2025

@Nyeriah That's strange, is that the only problematic opcode? And it affects more than a couple different accounts? I'll check tonight if there's any strange logic flaws. 800 packets of CMSG_CONTACT_LIST per second would be pretty crazy.

I'm glad the individual customization provided helpful though in this particular case! haha.

@Nyeriah
Copy link
Member

Nyeriah commented Feb 22, 2025

Yep, no logs from other opcodes so far, but sitting on over 50k lines of this one, from multiple accounts. The vast majority of them with no character (entering world I assume), with rare exceptions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CORE Related to the core DB related to the SQL database file-cpp Used to trigger the matrix build Requires WIKI Update Wiki sources will need to be updated after merging this PR. Script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework auctionhouse Update causes people to be kicked if buy to many items at once
3 participants