Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DB/Creatures) Remove Tanzar from his cage and activate group loot for its chest. #21120

Merged
merged 15 commits into from
Jan 9, 2025

Conversation

Rorschach91
Copy link
Member

@Rorschach91 Rorschach91 commented Jan 9, 2025

This fix is a band-aid. Currently Tanzar is in his cage and also spawn when Nalorak is defeated.
In this way, players can spawn and open two chests (breaking the four-box event).
With this fix Tanzar spawn only after Nalorak is defeated (so just one chest).
Edit: This PR will also fix the Tanzar's chest personal loot issue.

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Issues Addressed:

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@github-actions github-actions bot added the DB related to the SQL database label Jan 9, 2025
@Rorschach91 Rorschach91 changed the title fix(DB/Creatures) Remove Tanzar from his cage. fix(DB/Creatures) Remove Tanzar from his cage and activate group loot for its chest. Jan 9, 2025
@Rorschach91 Rorschach91 merged commit f7c9170 into azerothcore:master Jan 9, 2025
11 checks passed
@Rorschach91 Rorschach91 deleted the Band_aid_Tanzar branch January 9, 2025 09:24
@Nyeriah
Copy link
Member

Nyeriah commented Jan 9, 2025

Just for good measure, this is a sniffed field. Was this verified with sniffs?

@heyitsbench
Copy link
Contributor

Just for good measure, this is a sniffed field. Was this verified with sniffs?

ServerToClient: SMSG_QUERY_GAME_OBJECT_RESPONSE (0x2915) Length: 196
Entry: 186648
GUID: Full: 0x0
Allow: True
DataSize: 185
Type: 3 (Chest)
Display ID: 41
[0] Name: Tanzar's Trunk
[1] Name: 
[2] Name: 
[3] Name: 
Icon Name: 
Cast Caption: Opening
Unk String: 
[0] Data: 1744
[1] Data: 22699
[2] Data: 0
[3] Data: 1
[4] Data: 0
[5] Data: 0
[6] Data: 0
[7] Data: 0
[8] Data: 0
[9] Data: 0
[10] Data: 0
[11] Data: 1
[12] Data: 0
[13] Data: 1
[14] Data: 21400
[15] Data: 0
[16] Data: 0
[17] Data: 0
[18] Data: 0
[19] Data: 0
[20] Data: 0
[21] Data: 0
[22] Data: 0
[23] Data: 0
[24] Data: 0
[25] Data: 0
[26] Data: 0
[27] Data: 0
[28] Data: 0
[29] Data: 0
[30] Data: 0
[31] Data: 0
[32] Data: 0
[33] Data: 0
[34] Data: 0
Size: 1.5
QuestItemsCount: 0
ContentTuningId: 0

@Rorschach91
Copy link
Member Author

This is strange anyway. The other chests have the group loot active and I don't know why only Tanzar's chest shouldn't have it. Youtube minute 19:50

@sudlud
Copy link
Member

sudlud commented Jan 10, 2025

Can this flag be set from script? Then we could keep the sniffed value in DB and set it there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants