feat(Core) Add new config option for npc speeds

[Exitare]

Changes Proposed:

This PR proposes changes to:

• Core (units, players, creatures, game systems).
• Scripts (bosses, spell scripts, creature scripts).
• Database (SAI, creatures, etc).

Issues Addressed:

• Closes Feature: Add Flag to apply Rate.MoveSpeed to NPC and Mobs as well #18617, improved feat(CORE/World): Add Rate.MoveSpeedOther to control non-player movespeed as well. #18623

SOURCE:

The changes have been validated through:

• Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
• Sniffs (remember to share them with the open source community!)
• Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
• The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

• Tested in-game by the author.
• Tested in-game by other community members/someone else other than the author/has been live on production servers.
• This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

• This pull request can be tested by following the reproduction steps provided in the linked issue
• This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

1. Add the required section to your config or use the default worldserver conf
2. Change the new config option to a value greater than 1

Known Issues and TODO List:

• [ ]
• [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[ghost]

Hi, first for the contribution.

I'm disagree with this PR because it will create more issues. The problems is not your PR but the feature himself.

Even if your PR fix probably in most cases where players can bypass some mechanics. Increasing the movement speed of all creatures whitout adapting scripts will also probably breaks new things. And we will see in the future same issues than this.

All customs changes are not good. Except if we fully support it but here we can't provide blizz experience and custom dungeons/raids.

@azerothcore/developers need feedback.

[Exitare]

This PR is just picking up another PR that got abandoned. I assumed that because the other PR was accepted and got code reviews and feedback this is already an accepted feature and I wanted to finish it.

[ghost]

It's just my opinion. I'm not a staff member to validate the PR. That why I put for you "feedback label" ^^

[Kitzunu]

Well the PR in it self doesnt change anything with npc speeds. Keeps it at 1.0f. It just allows one to change the speed if they'd like to. I see nothing wrong

[TheSCREWEDSoftware]

I'm on grim on this, even if by default doesn't affect (as kitzune mentioned) the normal play until one day something breaks or the user changes the value even if it's 1.1 and we may start seeing issues/bugs been reported by a simple settings.

[Exitare]

Theoretically, this argument could be made for all config options such as max player level (think of level 255) or xp rate and more. They all can and will change the gameplay and can introduce new bugs.

[Nyeriah]

I don't see a problem with this. As for the concerns of things breaking, if people want to use wild values then I guess they should expect wild results. Is this the full implementation? I see the values being loaded, but not used. Are they already in use?

[Exitare]

Yes, it's the full implementation.
I set the speed to 2 in the config and all npcs moved faster.

There is a for loop that multiplies all move types using the config option.

[Kitzunu]

We can't idiot proof everything lol. If someone wanna do stupid stuff, expect stupid results :D