fix(Scripts/Kalimdor): Cavern of Time custodian escort quest group completion

[sogladev]

Changes Proposed:

This PR proposes changes to:

• Core (units, players, creatures, game systems).
• Scripts (bosses, spell scripts, creature scripts).
• Database (SAI, creatures, etc).

Cast the reward quest spell on each group members if within group reward range

I opted to use the reward quest spell on each group member over GroupEventHappens because a reward spell exists.

void Spell::EffectQuestComplete(SpellEffIndex effIndex)
void Player::GroupEventHappens(uint32 questId, WorldObject const* pEventObject)

Issues Addressed:

• Progresses Escort Quests cannot be completed by others group members (Generic Issue). #19591
• Closes "The Caverns of Time" escort quest party issue chromiecraft/chromiecraft#6225

SOURCE:

The changes have been validated through:

• Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
• Sniffs (remember to share them with the open source community!)
• Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
• The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

• Tested in-game by the author.
• Tested in-game by other community members/someone else other than the author/has been live on production servers.
• This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

• This pull request can be tested by following the reproduction steps provided in the linked issue
• This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

diff to "complete" escort after 10 seconds instead of 9 minutes

diff --git a/src/server/scripts/Kalimdor/zone_tanaris.cpp b/src/server/scripts/Kalimdor/zone_tanaris.cpp
index fcdbaa6aa2..f08fc66ddf 100644
--- a/src/server/scripts/Kalimdor/zone_tanaris.cpp
+++ b/src/server/scripts/Kalimdor/zone_tanaris.cpp
@@ -191,3 +191,3 @@ public:
                 {
-                    case 0:
+                    case 69:
                         Talk(WHISPER_CUSTODIAN_1, player);
@@ -242,3 +242,3 @@ public:
                         break;
-                    case 24:
+                    case 0:
                         Talk(WHISPER_CUSTODIAN_14, player);

some macros

pre quest
.quest add 10279

reset q
.quest remove  10277

complete single target
/tar cust
.cast back 34883

/target char
/g .die
/target char
/g .revive

2 characters
group
complete prequests

1. char1: accept escort
2. char2: accept escort
3. wait 10 seconds (or 9 minutes if unmodified)
4. char 1 and char 2 have quest completed

reset if needed to test conditions, like dead or out of range

Known Issues and TODO List:

• could move the npc to DB like in TC, but the same issue appears where quest credit is only granted to the summoner of the custodian TrinityCore/TrinityCore@07d1b5e
• [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.