-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release version 1.0.0 and set up deployments to PyPi from master #81
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! As far as the deployment, is there any harm in continuing to deploy to test.pypi.org
whenever there's a merge to develop
? That seems like it would be a useful test to run on a continuing basis.
For the encrypted variables, I think that you shouldn't have any problem accessing them from this PR since they're coming from the same repository, according to the docs:
Travis CI makes encrypted variables and data available only to pull requests coming from the same repository. These are considered trustworthy, as only members with write access to the repository can send them.
https://docs.travis-ci.com/user/pull-requests/
Did you try it and run into issues?
Also, our standard practice is to enable both branch and pull request builds: https://docs.travis-ci.com/user/pull-requests/#%E2%80%98Double-builds%E2%80%99-on-pull-requests Can you make sure both of those are enabled?
Last thing, if you had to set up any accounts in order to get this working, can you make sure that the passwords are in LastPass?
Thanks for the comments @ddohler! Replying inline:
Good point! It'd be nice to continually test published packages on
I didn't know encrypted environmental variables were available in PRs originating within the source repo, that makes a lot more sense. In this case the deployment seems not to be working, not because the environment variables aren't decrypted but because of some specific rule around pull requests, which raises the warning:
I'm not sure yet if this is PyPi specific, or global to travis
Yep, both are enabled in this case. It isn't pushing branch builds because I'm restricting it to build from
The credentials were all already in LastPass, so we're good to go! |
Yep, we usually end up with two builds for each branch, one for the branch itself and the other for the PR. Everything else sounds good! |
Overview
This PR bumps Ashlar to version 1.0.0, updates the package metadata with more details, and sets up Travis to deploy to PyPi from commits to the
master
branch.Checklist
Notes
Once this PR gets approved, I'll squash and merge and then do the following things to wrap up packaging:
develop
intomaster
to cut the 1.0.0 release to PyPiv1.0.0
develop
Testing Instructions
develop
, it will deploy the package to the PyPi test instance at https://test.pypi.org/project/ashlar/ to confirm that the package is being published properly. In a subsequent PR, I'll remove this deployment directive from Travis. Unfortunately, there doesn't seem to be a reliable way to test PyPi package CI from a PR, since encrypted variables are not available from pull requests in Travis; if you can think of a better way to test this, I'm all ears.Closes azavea/grout-2018-fellowship#23.