Bump CMake MacOS compilation target to MacOS 13 #714
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The minimum required MacOS version was already MacOS 13 due to dependencies, but until now the compilation target was set to MacOS 11
|
Testing checklist:
|
|
If you can make pre compiled binaries for Mac of this branch I can test this out on my m4 mini and Intel MBP |
There already are, see here: https://github.com/azahar-emu/azahar/actions/runs/13922856943?pr=714 |
|
app launches on both intel and macos arm think this is ok to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The minimum required MacOS version was already documented as MacOS 13, but until now the compilation target was set to MacOS 11.
This may allow the compiler to introduce additional micro-optimizations or something? Not really sure what this done on a low level. Regardless, this probably can't hurt.
Was originally going to include this in 2120, but was unable to due to build failures caused by an outdated dependency of dynarmic, however now that dynarmic's dependencies have been updated in 2120-rc2, this change can now be evaluated for 2121.
Will self-review this as I have access to the necessary hardware.