Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various savestate bugfixes #656

Merged
merged 5 commits into from
Mar 12, 2025
Merged

Conversation

PabloMK7
Copy link
Member

Fixes a few issues with savestates:

  • A class was missing the boost export, so apps with extdata opened at all times (such as the home menu) would fail to serialize.
  • RunAsync callbacks are not serializable nor deterministic. Fixed this in two ways:
    • The core will wait for all async callbacks to finish, and then do the savestate. If it takes more than 5 seconds the core throws an error.
    • Added an option to make async callbacks deterministic by not putting them in a new thread. This fixes TASes not working properly depending on load times.
  • Disabled savestates when LLE modules are being used. To be figured out why this happens.

@PabloMK7
Copy link
Member Author

@OpenSauce04 this is a large PR, and there is no need to dig deep into it as everything is tested. You can review UI and style changes.

@OpenSauce04 OpenSauce04 added bug Something isn't working rebase labels Mar 12, 2025
@PabloMK7 PabloMK7 merged commit 4cbfba8 into azahar-emu:master Mar 12, 2025
12 checks passed
@PabloMK7 PabloMK7 deleted the savestatefixes branch March 12, 2025 19:50
@kage2051 kage2051 mentioned this pull request Mar 19, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working rebase size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants