-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
citra_qt: Use stylesheet with light colored icons if dark mode is used by the system #623
Conversation
@OpenSauce04 Can you try on macOS and let me know if it works there I need to know if the issue is isolated to Linux. Most likely dark mode isn't being detected properly on Linux |
Works on MacOS. Seems to be a Linux thing. |
At some point in the next few days I'm going to spin up a Gentoo VM and install full-fat KDE to see if it's just my minimal KDE install being a bit weird. |
6db7c11
to
3ff4b64
Compare
3ff4b64
to
87d4146
Compare
Yeah that previous problem was totally just a skill issue on my part in some way, I tested using a Gentoo VM and it worked fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks fine to me
Fixes #520
Now the icon stylesheet isn't always black but dynamically changes depending on dark/light mode system state
TO:DO
Test Linux and macOS
Demo::