Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

citra_qt: Use stylesheet with light colored icons if dark mode is used by the system #623

Closed
wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 4, 2025

Fixes #520

Now the icon stylesheet isn't always black but dynamically changes depending on dark/light mode system state

TO:DO

Test Linux and macOS

Demo::

Screenshot 2025-03-04 151224
Screenshot 2025-03-04 151212

@OpenSauce04 OpenSauce04 added the bug Something isn't working label Mar 4, 2025
@OpenSauce04 OpenSauce04 self-requested a review March 4, 2025 17:44
@OpenSauce04
Copy link
Member

OpenSauce04 commented Mar 4, 2025

This PR doesn't seem to resolve the problem you're referring to, on Linux at least.
This is what the System theme looks like with Breeze Dark enabled in KDE Plasma 6:
Screenshot_20250304_180125
I'm going to convert this PR to a draft. It can be marked as ready for review when it's working properly across the board.

@OpenSauce04 OpenSauce04 marked this pull request as draft March 4, 2025 18:02
@ghost
Copy link
Author

ghost commented Mar 4, 2025

@OpenSauce04 Can you try on macOS and let me know if it works there

I need to know if the issue is isolated to Linux. Most likely dark mode isn't being detected properly on Linux

@ghost
Copy link
Author

ghost commented Mar 4, 2025

image

Working fine on windows 11

@OpenSauce04
Copy link
Member

Works on MacOS. Seems to be a Linux thing.

@ghost
Copy link
Author

ghost commented Mar 5, 2025

Fedora KDE 41
For some reason light mode doesn't use the stylesheet icons for me but system native ones instead however dark mode works

That's the way the normal build behaved gor me too

Screenshot (working fine on Fedora)

Screenshot_20250305_154422

@OpenSauce04
Copy link
Member

OpenSauce04 commented Mar 5, 2025

At some point in the next few days I'm going to spin up a Gentoo VM and install full-fat KDE to see if it's just my minimal KDE install being a bit weird.
If it's the latter we'll just progress with this PR.

@OpenSauce04
Copy link
Member

OpenSauce04 commented Mar 13, 2025

Yeah that previous problem was totally just a skill issue on my part in some way, I tested using a Gentoo VM and it worked fine.
Will review now.

@OpenSauce04 OpenSauce04 marked this pull request as ready for review March 13, 2025 18:13
Copy link
Member

@OpenSauce04 OpenSauce04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks fine to me

@OpenSauce04
Copy link
Member

Merged as 420b803, e6ca711

@ghost ghost deleted the qt-themed-icons branch March 13, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working manual merge size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lime3ds_qt doesn't change icons on native QT6 system light/dark mode theme
2 participants