Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send pre_save and post_save signals before and after bulk_update #74

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion django_bulk_update/helper.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from collections import defaultdict

from django.db import connections, models
from django.db.models.query import QuerySet
from django.db.models.signals import post_save, pre_save
from django.db.models.sql import UpdateQuery


Expand Down Expand Up @@ -219,6 +219,27 @@ def bulk_update(objs, meta=None, update_fields=None, exclude_fields=None,

lenpks += n_pks

signal_kwargs = {
'raw': False,
'using': using,
'update_fields': update_fields,
}

for obj in objs_batch:
pre_save.send(
sender=obj.__class__,
instance=obj,
**signal_kwargs
)

connection.cursor().execute(sql, parameters)

for obj in objs_batch:
post_save.send(
sender=obj.__class__,
instance=obj,
created=False,
**signal_kwargs
)

return lenpks
2 changes: 1 addition & 1 deletion tests/requirements/requirements_base.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
dj_database_url==0.4.2
jsonfield==2.0.1
pillow==4.1.1
psycopg2==2.7.3
psycopg2-binary==2.7.5
six==1.10.0
34 changes: 32 additions & 2 deletions tests/tests.py
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
import random

import collections
from datetime import date, time, timedelta
from decimal import Decimal
from unittest import skipUnless

from django.conf import settings
from django.db.models import F, Func, Value
from django.db.models.functions import Concat
from django.db.models.signals import pre_save, post_save
from django.dispatch import receiver
from django.test import TestCase
from django.utils import timezone

Expand Down Expand Up @@ -888,3 +889,32 @@ def test_validate_fields(self):
exclude_fields = ['jobs']
self.assertRaises(TypeError, helper.get_fields,
update_fields, exclude_fields, meta)

def test_signals(self):
signal_calls = collections.defaultdict(int)

@receiver(pre_save)
def pre_save_handler(sender, instance, raw, using, update_fields, **kwargs):
self.assertIs(sender, Person)
self.assertIsInstance(instance, Person)
self.assertFalse(raw)
self.assertEquals(using, 'default')
self.assertListEqual(update_fields, ['age'])
signal_calls['pre_save'] += 1

@receiver(post_save)
def post_save_handler(sender, instance, created, raw, using, update_fields, **kwargs):
self.assertIs(sender, Person)
self.assertIsInstance(instance, Person)
self.assertFalse(created)
self.assertFalse(raw)
self.assertEquals(using, 'default')
self.assertListEqual(update_fields, ['age'])
signal_calls['post_save'] += 1

people = Person.objects.all()
Person.objects.bulk_update(people, update_fields=['age'])

self.assertGreater(len(people), 0)
self.assertEquals(signal_calls['pre_save'], len(people))
self.assertEquals(signal_calls['post_save'], len(people))