Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump version to 0.9.4 #35

Merged
merged 4 commits into from
Feb 26, 2025
Merged

Conversation

vadorovsky
Copy link
Member

@vadorovsky vadorovsky commented Feb 26, 2025

This change is Reviewable

@vadorovsky vadorovsky requested a review from tamird February 26, 2025 15:53
Copy link
Member

@tamird tamird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @vadorovsky)


-- commits line 4 at r2:
can you make this a revert of 1c4a991 so it's linked properly? obvious keep the CI (and maybe add a cargo package step)

Copy link
Member Author

@vadorovsky vadorovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @tamird)


-- commits line 4 at r2:

Previously, tamird (Tamir Duberstein) wrote…

can you make this a revert of 1c4a991 so it's linked properly? obvious keep the CI (and maybe add a cargo package step)

Done.

Copy link
Member

@tamird tamird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @vadorovsky)


-- commits line 4 at r2:

Previously, vadorovsky (Michal Rostecki) wrote…

Done.

nit: still include the rationale in the body: "cargo package works fine without this cleanup now."

did you mean to add cargo package to CI?

This reverts commit 1c4a991.

`cargo package` works fine without this cleanup now.
Copy link
Member

@tamird tamird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @vadorovsky)

@vadorovsky vadorovsky mentioned this pull request Feb 26, 2025
Copy link
Member

@tamird tamird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r7, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @vadorovsky)

@vadorovsky vadorovsky merged commit d0cbf35 into aya-rs:main Feb 26, 2025
4 checks passed
@vadorovsky vadorovsky deleted the bump-version branch February 26, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants