core/vm: Add Venoki header's fields when verify double sign #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chiphamskymavis
force-pushed
the
fix/double-sign-header-verify
branch
4 times, most recently
from
21466cf to
e8c38a4
Compare
chiphamskymavis
changed the title
minh-bq
reviewed
Dec 5, 2024
chiphamskymavis
force-pushed
the
fix/double-sign-header-verify
branch
from
e8c38a4 to
cadbe69
Compare
minh-bq
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After Venoki, these fields are added into block's header: BaseFee, BlodGasUsed, ExceedBlobGas.
We need to add them into the double sign verification process to make sure the logic up to date.
The separated struct due to lack off optional and null support of contract Abi