Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Staking/Validator] Add bonus per block #7

Merged
merged 2 commits into from
Sep 13, 2022
Merged

[Staking/Validator] Add bonus per block #7

merged 2 commits into from
Sep 13, 2022

Conversation

ducthotran2010
Copy link
Contributor

@ducthotran2010 ducthotran2010 commented Sep 13, 2022 •
edited
Loading

Description

  • Add block reward per block in StakingVesting contract
  • Request block bonus while submitting block reward - RoninValidatorSet.submitBlockReward()
  • Update the contract deployment order

Config changes (devnet)

  • Top up 10.000 RON to StakingVesting contract in the initializing transaction.
  • Add 1 RON as the bonus reward for each block

Checklist

  • I have clearly commented on all the main functions followed the NatSpec Format
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works

phuctd95
phuctd95 reviewed Sep 13, 2022
View reviewed changes
Copy link
Collaborator

@phuctd95 phuctd95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deposit to RoninValidatorSet instead of Staking contract.
Remove requestBlockBonus method.

nxqbao
nxqbao suggested changes Sep 13, 2022
View reviewed changes
contracts/interfaces/IStaking.sol Outdated Show resolved Hide resolved
contracts/staking/Staking.sol Outdated Show resolved Hide resolved
nxqbao
nxqbao reviewed Sep 13, 2022
View reviewed changes
contracts/StakingVesting.sol Outdated Show resolved Hide resolved
contracts/interfaces/IStakingVesting.sol Outdated Show resolved Hide resolved
@ducthotran2010 ducthotran2010 merged commit d2fcd65 into axieinfinity:main Sep 13, 2022
@ducthotran2010 ducthotran2010 deleted the feat/staking-reward branch September 13, 2022 08:10
@nxqbao nxqbao mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nxqbao nxqbao nxqbao approved these changes

@phuctd95 phuctd95 Awaiting requested review from phuctd95

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ducthotran2010 @phuctd95 @nxqbao