Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[StakingVesting] Request bonus should not be reverted #45

Merged
merged 8 commits into from
Nov 2, 2022
Merged

[StakingVesting] Request bonus should not be reverted #45

merged 8 commits into from
Nov 2, 2022

Conversation

nxqbao
Copy link
Contributor

@nxqbao nxqbao commented Nov 2, 2022 •
edited
Loading

Description

https://skymavis.atlassian.net/browse/PSC-97?atlOrigin=eyJpIjoiYzc0YmUyMjhjMmRiNDY0MjllOWUzNzA4Y2JlYmFjZGYiLCJwIjoiaiJ9

Checklist

  • I have clearly commented on all the main functions followed the NatSpec Format
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works

@nxqbao nxqbao force-pushed the fix/request-bonus-should-not-be-reverted branch from 40653dd to 124d77c Compare November 2, 2022 07:08
@nxqbao nxqbao requested a review from ducthotran2010 November 2, 2022 07:19
@nxqbao nxqbao marked this pull request as ready for review November 2, 2022 07:58
@nxqbao nxqbao changed the title Request bonus should not be reverted [StakingVesting] Request bonus should not be reverted Nov 2, 2022
@nxqbao nxqbao merged commit ee6e3eb into main Nov 2, 2022
@nxqbao nxqbao deleted the fix/request-bonus-should-not-be-reverted branch November 11, 2022 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ducthotran2010 ducthotran2010 ducthotran2010 requested changes

@DNK90 DNK90 DNK90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nxqbao @DNK90 @ducthotran2010