Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add renounce function #20

Merged
merged 6 commits into from
Sep 29, 2022
Merged

Add renounce function #20

merged 6 commits into from
Sep 29, 2022

Conversation

ducthotran2010
Copy link
Contributor

Description

  • Add requestRenounce function: remove candidates at the end of the next period.
  • Filter candidates which are insufficient balance at the end of each period.
  • Checks and removes the one renounced at the end of each epoch.

Checklist

  • I have clearly commented on all the main functions followed the NatSpec Format
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works

@ducthotran2010 ducthotran2010 marked this pull request as ready for review September 27, 2022 05:52
nxqbao
nxqbao reviewed Sep 28, 2022
View reviewed changes
contracts/interfaces/IStaking.sol Show resolved Hide resolved
test/maintainance/Maintenance.test.ts Outdated Show resolved Hide resolved
contracts/interfaces/ICandidateManager.sol Outdated Show resolved Hide resolved
contracts/staking/StakingManager.sol Outdated Show resolved Hide resolved
contracts/interfaces/ICandidateManager.sol Outdated Show resolved Hide resolved
@ducthotran2010 ducthotran2010 merged commit 684682a into axieinfinity:main Sep 29, 2022
@ducthotran2010 ducthotran2010 deleted the feat/renouncing branch September 29, 2022 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nxqbao nxqbao nxqbao left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ducthotran2010 @nxqbao