Validator set contract excludes under balance validators in updating set #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ducthotran2010
approved these changes
Sep 15, 2022
Comment on lines
133
to
153
| function getCandidateWeights() external view returns (address[] memory _candidates, uint256[] memory _weights) { | ||
| uint256 _length = validatorCandidates.length; | ||
| uint256 _newLength = _length; | ||
| _candidates = new address[](_length); | ||
| _weights = new uint256[](_length); | ||
|
|
||
| for (uint256 _i; _i < _length; _i++) { | ||
| ValidatorCandidate storage _candidate = validatorCandidates[_i]; | ||
| if (_candidate.stakedAmount < _minValidatorBalance) { | ||
| _newLength--; | ||
| continue; | ||
| } | ||
| _candidates[_i] = _candidate.consensusAddr; | ||
| _weights[_i] = _candidate.delegatedAmount; | ||
| } | ||
|
|
||
| assembly { | ||
| mstore(_candidates, _newLength) | ||
| mstore(_weights, _newLength) | ||
| } | ||
| } |
There was a problem hiding this comment.
This should be a temporary fix since we don't have a final decision for the slashing issue. Plz note sth here for future fixing
nxqbao
deleted the
feat/validator-set-excludes-under-balance-validators
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist