Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Differentiate corresponding addresses of validators and trusted orgs #101

Merged
merged 12 commits into from
Nov 28, 2022
Merged

Differentiate corresponding addresses of validators and trusted orgs #101

merged 12 commits into from
Nov 28, 2022

Conversation

nxqbao
Copy link
Contributor

@nxqbao nxqbao commented Nov 25, 2022 •
edited
Loading

Description

Checklist

  • I have clearly commented on all the main functions following the NatSpec Format
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works

@nxqbao nxqbao marked this pull request as draft November 25, 2022 10:31
nxqbao
nxqbao commented Nov 27, 2022
View reviewed changes
test/maintainance/Maintenance.test.ts
@@ -114,16 +124,16 @@ describe('Maintenance test', () => {
await network.provider.send('hardhat_setCoinbase', [coinbase.address]);

localEpochController = new EpochController(minOffsetToStartSchedule, numberOfBlocksInEpoch);
await localEpochController.mineToBeforeEndOfEpoch();
await localEpochController.mineToBeforeEndOfEpoch(2);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idk why it needed to be set to 2. Before this PR, this number is 1 and the code ran well.

@nxqbao nxqbao marked this pull request as ready for review November 27, 2022 17:14
@nxqbao
Copy link
Contributor Author

nxqbao commented Nov 28, 2022

Unlink 57.

@nxqbao nxqbao merged commit 2d858ef into dev Nov 28, 2022
@nxqbao nxqbao deleted the PSC-105-differentiate-corresponding-addresses-of-a-validator branch November 28, 2022 12:45
ducthotran2010 pushed a commit that referenced this pull request Dec 6, 2022
@nxqbao @ducthotran2010
Differentiate corresponding addresses of validators and trusted orgs (#…
17a2553 
…101)

* Update contracts

* Add test helper

* Fix BridgeTracking.test.ts

* Fix integration tests

* Fix GovernanceAdmin.test.ts

* Increase number of hardhat signers

* Fix maintenance and slashing tests

* Rename variable for consistency

* Revert renaming

* Fix Staking test

* Fix validator tests

* Move hasDuplicate function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ducthotran2010 ducthotran2010 ducthotran2010 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nxqbao @ducthotran2010