Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ValidatorSet] Support withdrawing jailed reward #78

Closed
nxqbao opened this issue Nov 11, 2022 · 1 comment · Fixed by #95
Closed

[ValidatorSet] Support withdrawing jailed reward #78

nxqbao opened this issue Nov 11, 2022 · 1 comment · Fixed by #95
Labels
edge case Something is overlooked and needs proper handling enhancement New feature or request

Comments

@nxqbao
Copy link
Contributor

nxqbao commented Nov 11, 2022 

    Should this contract support withdraw function to withdraw jailed reward?

Originally posted by @minh-bq in #22 (comment)
@nxqbao nxqbao added the edge case Something is overlooked and needs proper handling label Nov 14, 2022
@ducthotran2010 ducthotran2010 added the enhancement New feature or request label Nov 21, 2022
@nxqbao
Copy link
Contributor Author

nxqbao commented Nov 22, 2022

The implementation for this feature should be as follows:

  • Only the admin should be able to call the withdraw function;
  • The amount to be withdrawn includes: deprecated reward for bridge, deprecated reward for validators, and deprecated reward for delegators; and excludes the block reward submitted by the invalid validators;
  • The recipient of the withdraw is always the staking vesting contract.

nxqbao added a commit that referenced this issue Nov 22, 2022
@nxqbao
Fix: [ValidatorSet] Support withdrawing jailed reward #78
4c4388d
@nxqbao nxqbao linked a pull request Nov 22, 2022 that will close this issue
[ValidatortSet] Support withdrawing jailed reward #95
Merged
3 tasks
nxqbao added a commit that referenced this issue Nov 22, 2022
@nxqbao
Fix: [ValidatorSet] Support withdrawing jailed reward #78
fc78c65
@nxqbao nxqbao mentioned this issue Nov 22, 2022
Merged
3 tasks
nxqbao added a commit that referenced this issue Nov 23, 2022
@nxqbao
Fix: [ValidatorSet] Support withdrawing jailed reward #78
7354040
nxqbao added a commit that referenced this issue Nov 23, 2022
@nxqbao
[ValidatortSet] Support withdrawing jailed reward (#95)
4ccaa96 
* Fix: [ValidatorSet] Support withdrawing jailed reward #78

* Update contract

* Add test
@nxqbao nxqbao closed this as completed Nov 23, 2022
ducthotran2010 pushed a commit that referenced this issue Dec 6, 2022
@nxqbao @ducthotran2010
[ValidatortSet] Support withdrawing jailed reward (#95)
ead4bd3 
* Fix: [ValidatorSet] Support withdrawing jailed reward #78

* Update contract

* Add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
edge case Something is overlooked and needs proper handling enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ValidatortSet] Support withdrawing jailed reward axieinfinity/ronin-dpos-contracts
2 participants
@nxqbao @ducthotran2010