Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review variable casting #49

Closed
ducthotran2010 opened this issue Nov 4, 2022 · 0 comments · Fixed by #77
Closed

Review variable casting #49

ducthotran2010 opened this issue Nov 4, 2022 · 0 comments · Fixed by #77

Comments

@ducthotran2010
Copy link
Contributor

ronin-dpos-contracts/contracts/ronin/validator/RoninValidatorSet.sol

Line 215 in 2ef51c7

IStaking(_stakingContract).sinkPendingReward(_validatorAddr);

ronin-dpos-contracts/contracts/ronin/validator/RoninValidatorSet.sol

Line 222 in 2ef51c7

IStaking(_stakingContract).deductStakedAmount(_validatorAddr, _slashAmount); 

   Redundant castings, and local variables

Originally posted by @nxqbao in #22 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Minor fixes in docs, naming, etc. Clean up. axieinfinity/ronin-dpos-contracts
1 participant
@ducthotran2010